Linux Container Development
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: "Serge E. Hallyn"
	<serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 0/3][V2] remove the ns_cgroup
Date: Tue, 28 Sep 2010 15:50:17 +0200	[thread overview]
Message-ID: <4CA1F299.3000603@free.fr> (raw)
In-Reply-To: <20100927134619.ecefe9f4.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>

On 09/27/2010 10:46 PM, Andrew Morton wrote:
> On Mon, 27 Sep 2010 15:36:58 -0500
> "Serge E. Hallyn"<serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>  wrote:
>
>    
>>>> This patchset removes the ns_cgroup by adding a new flag to the cgroup
>>>> and the cgroupfs mount option. It enables the copy of the parent cgroup
>>>> when a child cgroup is created. We can then safely remove the ns_cgroup as
>>>> this flag brings a compatibility. We have now to manually create and add the
>>>> task to a cgroup, which is consistent with the cgroup framework.
>>>>          
>>> So this is a non-backward-compatible userspace-visible change?
>>>        
>> Yes, it is.
>>
>> Patch 1 is needed to let lxc and libvirt both control containers with
>> same cgroup setup.  Patch 3 however isn't *necessary* for that.  Daniel,
>> what do you think about holding off on patch 3?
>>      
> One way of handling this would be to merge patches 1&2 which add the
> new interface and also arrange for usage of the old interface(s) to
> emit a printk, telling people that they're using a feature which is
> scheduled for removal.
>    

Right, that makes sense.

Do you will take the patches #1 and #2, drop the patch #3, and I send a 
new patch with the printk warning ?
Or shall I resend all ?

Thanks
   -- Daniel

  parent reply	other threads:[~2010-09-28 13:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 10:14 [PATCH 0/3][V2] remove the ns_cgroup Daniel Lezcano
     [not found] ` <1285582453-6127-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2010-09-27 10:14   ` [PATCH 1/3][V2] cgroup : add clone_children control file Daniel Lezcano
     [not found]     ` <1285582453-6127-2-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2010-09-27 13:34       ` Serge E. Hallyn
2010-09-27 14:11       ` Balbir Singh
2010-09-29 23:12       ` Paul Menage
2010-09-27 10:14   ` [PATCH 2/3][V2] cgroup : make the mount options parsing more accurate Daniel Lezcano
2010-09-27 10:14   ` [PATCH 3/3][V2] cgroup : remove the ns_cgroup Daniel Lezcano
2010-09-27 19:57   ` [PATCH 0/3][V2] " Andrew Morton
     [not found]     ` <20100927125741.0df22f09.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-09-27 20:36       ` Serge E. Hallyn
     [not found]         ` <20100927203658.GA5320-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2010-09-27 20:45           ` Eric W. Biederman
     [not found]             ` <m1zkv2ncex.fsf-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2010-09-27 20:50               ` Andrew Morton
     [not found]                 ` <20100927135025.74e297c3.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-09-27 21:13                   ` Eric W. Biederman
2010-09-27 20:46           ` Andrew Morton
     [not found]             ` <20100927134619.ecefe9f4.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-09-27 20:53               ` Serge E. Hallyn
2010-09-28 13:50               ` Daniel Lezcano [this message]
     [not found]                 ` <4CA1F299.3000603-GANU6spQydw@public.gmane.org>
2010-09-28 21:27                   ` Andrew Morton
2010-09-27 20:43       ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA1F299.3000603@free.fr \
    --to=daniel.lezcano-ganu6spqydw@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox