From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org,
mhocko-AlSwsSmVLrQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 10/12] cgroup: attach cgroup_open_file to all cgroup files
Date: Wed, 4 Dec 2013 14:04:36 +0800 [thread overview]
Message-ID: <529EC5F4.10708@huawei.com> (raw)
In-Reply-To: <1385595759-17656-11-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> @@ -2353,10 +2338,18 @@ static int cgroup_file_open(struct inode *inode, struct file *file)
> WARN_ON_ONCE(cfe->css && cfe->css != css);
> cfe->css = css;
>
> - if (cft->open)
> + if (cft->open) {
> err = cft->open(inode, file);
> - else
> - err = single_open(file, cgroup_seqfile_show, cfe);
> + } else {
> + err = single_open_size(file, cgroup_seqfile_show, cfe,
> + sizeof(struct cgroup_open_file));
This is wrong.
I guess you wanted to use single_open_private(), which doesn't exist.
> + if (!err) {
> + struct seq_file *sf = file->private_data;
> + struct cgroup_open_file *of = sf->private;
> +
> + of->cfe = cfe;
> + }
> + }
>
> if (css->ss && err)
> css_put(css);
next prev parent reply other threads:[~2013-12-04 6:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1385595759-17656-1-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-27 23:42 ` [PATCH 01/12] cgroup, sched: convert away from cftype->read_map() Tejun Heo
2013-11-27 23:42 ` [PATCH 02/12] cpuset: convert away from cftype->read() Tejun Heo
2013-11-27 23:42 ` [PATCH 03/12] memcg: convert away from cftype->read() and ->read_map() Tejun Heo
2013-11-27 23:42 ` [PATCH 04/12] netprio_cgroup: convert away from cftype->read_map() Tejun Heo
2013-11-27 23:42 ` [PATCH 05/12] hugetlb_cgroup: convert away from cftype->read() Tejun Heo
2013-11-27 23:42 ` [PATCH 06/12] cgroup: remove cftype->read(), ->read_map() and ->write() Tejun Heo
2013-11-27 23:42 ` [PATCH 07/12] cgroup: unify cgroup_write_X64() and cgroup_write_string() Tejun Heo
2013-11-27 23:42 ` [PATCH 08/12] cgroup: unify read path so that seq_file is always used Tejun Heo
2013-11-27 23:42 ` [PATCH 09/12] cgroup: generalize cgroup_pidlist_open_file Tejun Heo
2013-11-27 23:42 ` [PATCH 10/12] cgroup: attach cgroup_open_file to all cgroup files Tejun Heo
2013-11-27 23:42 ` [PATCH 11/12] cgroup: replace cftype->read_seq_string() with cftype->seq_show() Tejun Heo
2013-11-27 23:42 ` [PATCH 12/12] cgroup: unify pidlist and other file handling Tejun Heo
2013-12-05 1:48 ` [PATCHSET cgroup/for-3.14] cgroup: consolidate " Li Zefan
2013-12-05 17:26 ` Tejun Heo
[not found] ` <1385595759-17656-4-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-28 8:26 ` [PATCH 03/12] memcg: convert away from cftype->read() and ->read_map() Michal Hocko
[not found] ` <1385595759-17656-6-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-28 8:29 ` [PATCH 05/12] hugetlb_cgroup: convert away from cftype->read() Michal Hocko
[not found] ` <1385595759-17656-8-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-8-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-28 11:18 ` [PATCH 07/12] cgroup: unify cgroup_write_X64() and cgroup_write_string() Michal Hocko
[not found] ` <20131128111818.GG2761-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-11-29 20:05 ` Tejun Heo
[not found] ` <20131129200525.GC21755-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-12-02 9:54 ` Michal Hocko
[not found] ` <20131202095401.GA18838-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-12-02 13:30 ` Tejun Heo
[not found] ` <20131202133059.GA3626-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-02 14:12 ` Michal Hocko
[not found] ` <20131202141242.GD18838-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-12-03 20:41 ` Tejun Heo
[not found] ` <20131203204155.GL8277-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-03 21:04 ` Michal Hocko
2013-12-02 16:44 ` Johannes Weiner
[not found] ` <20131202164406.GP3556@cmpxchg.org>
[not found] ` <20131202164406.GP3556-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2013-12-03 7:35 ` Li Zefan
[not found] ` <1385595759-17656-5-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-29 1:56 ` [PATCH 04/12] netprio_cgroup: convert away from cftype->read_map() Neil Horman
2013-11-29 8:52 ` Daniel Wagner
[not found] ` <1385595759-17656-12-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-12-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-28 9:07 ` [PATCH 11/12] cgroup: replace cftype->read_seq_string() with cftype->seq_show() Daniel Wagner
2013-11-28 11:25 ` Michal Hocko
2013-12-02 14:41 ` Aristeu Rozanski
2013-12-02 14:52 ` Vivek Goyal
[not found] ` <1385595759-17656-11-git-send-email-tj@kernel.org>
[not found] ` <1385595759-17656-11-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-12-04 6:04 ` Li Zefan [this message]
[not found] ` <529EC5F4.10708-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-12-04 13:04 ` [PATCH 10/12] cgroup: attach cgroup_open_file to all cgroup files Tejun Heo
2013-12-04 15:09 ` [PATCH v2 " Tejun Heo
[not found] ` <1385595759-17656-13-git-send-email-tj@kernel.org>
[not found] ` <529EC9A6.903@huawei.com>
[not found] ` <529EC9A6.903-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-12-04 13:08 ` [PATCH 12/12] cgroup: unify pidlist and other file handling Tejun Heo
[not found] ` <1385595759-17656-13-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-12-04 6:20 ` Li Zefan
2013-12-04 15:09 ` [PATCH v3 " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529EC5F4.10708@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox