* [REVIEW][PATCH] pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes [not found] ` <874lwqyo8i.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> @ 2017-05-12 17:55 ` Eric W. Biederman [not found] ` <87d1bex8mt.fsf_-_-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Eric W. Biederman @ 2017-05-12 17:55 UTC (permalink / raw) To: Guenter Roeck Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Linux Containers, Ingo Molnar, Vovo Yang Date: Thu, 11 May 2017 18:21:01 -0500 The code can potentially sleep for an indefinite amount of time in zap_pid_ns_processes triggering the hung task timeout, and increasing the system average. This is undesirable. Sleep with a task state of TASK_INTERRUPTIBLE instead of TASK_UNINTERRUPTIBLE to remove these undesirable side effects. Apparently under heavy load this has been allowing Chrome to trigger the hung time task timeout error and cause ChromeOS to reboot. Reported-by: Vovo Yang <vovoy-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Reported-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Fixes: 6347e9009104 ("pidns: guarantee that the pidns init will be the last pidns process reaped") Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Signed-off-by: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> --- This is what I have queued up posting so it is public knowledge and so that if anyone can see a flaw it can get fixed. kernel/pid_namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index de461aa0bf9a..6e51b8820495 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -277,7 +277,7 @@ void zap_pid_ns_processes(struct pid_namespace *pid_ns) * if reparented. */ for (;;) { - set_current_state(TASK_UNINTERRUPTIBLE); + set_current_state(TASK_INTERRUPTIBLE); if (pid_ns->nr_hashed == init_pids) break; schedule(); -- 2.10.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <87d1bex8mt.fsf_-_-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>]
* Re: [REVIEW][PATCH] pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes [not found] ` <87d1bex8mt.fsf_-_-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> @ 2017-05-12 19:33 ` Guenter Roeck 0 siblings, 0 replies; 2+ messages in thread From: Guenter Roeck @ 2017-05-12 19:33 UTC (permalink / raw) To: Eric W. Biederman Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Linux Containers, Ingo Molnar, Vovo Yang On Fri, May 12, 2017 at 12:55:22PM -0500, Eric W. Biederman wrote: > Date: Thu, 11 May 2017 18:21:01 -0500 > > The code can potentially sleep for an indefinite amount of time in > zap_pid_ns_processes triggering the hung task timeout, and increasing > the system average. This is undesirable. Sleep with a task state of > TASK_INTERRUPTIBLE instead of TASK_UNINTERRUPTIBLE to remove these > undesirable side effects. > > Apparently under heavy load this has been allowing Chrome to trigger > the hung time task timeout error and cause ChromeOS to reboot. > > Reported-by: Vovo Yang <vovoy-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> > Reported-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Tested-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> > Fixes: 6347e9009104 ("pidns: guarantee that the pidns init will be the last pidns process reaped") > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> > --- > > This is what I have queued up posting so it is public knowledge and so > that if anyone can see a flaw it can get fixed. > > kernel/pid_namespace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c > index de461aa0bf9a..6e51b8820495 100644 > --- a/kernel/pid_namespace.c > +++ b/kernel/pid_namespace.c > @@ -277,7 +277,7 @@ void zap_pid_ns_processes(struct pid_namespace *pid_ns) > * if reparented. > */ > for (;;) { > - set_current_state(TASK_UNINTERRUPTIBLE); > + set_current_state(TASK_INTERRUPTIBLE); > if (pid_ns->nr_hashed == init_pids) > break; > schedule(); > -- > 2.10.1 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-12 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170511171108.GB15063@roeck-us.net>
[not found] ` <87shkbfggm.fsf@xmission.com>
[not found] ` <20170511202104.GA14720@roeck-us.net>
[not found] ` <87y3u3axx8.fsf@xmission.com>
[not found] ` <20170511224724.GB15676@roeck-us.net>
[not found] ` <8760h79e22.fsf@xmission.com>
[not found] ` <CAASEscF4eajN_-F-VMq_4C+Hf9j3eXj1V5iESvyjT0B+911Q9A@mail.gmail.com>
[not found] ` <8760h66wak.fsf@xmission.com>
[not found] ` <20170512165214.GA12960@roeck-us.net>
[not found] ` <874lwqyo8i.fsf@xmission.com>
[not found] ` <874lwqyo8i.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-12 17:55 ` [REVIEW][PATCH] pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes Eric W. Biederman
[not found] ` <87d1bex8mt.fsf_-_-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-12 19:33 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox