[PATCH 1/2] cpufreq: exynos4210: make needlessly global symbols static

[PATCH 1/2] cpufreq: exynos4210: make needlessly global symbols static

[Axel Lin]

The following symbols are needlessly defined global:
  exynos4_verify_speed
  exynos4_getspeed
  exynos4_set_clkdiv

Make them static.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/cpufreq/exynos4210-cpufreq.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210-cpufreq.c
index 54025fc..b7c3a84 100644
--- a/drivers/cpufreq/exynos4210-cpufreq.c
+++ b/drivers/cpufreq/exynos4210-cpufreq.c
@@ -191,17 +191,17 @@ static unsigned int exynos4_apll_pms_table[CPUFREQ_LEVEL_END] = {
 	((200 << 16) | (6 << 8) | 4),
 };
 
-int exynos4_verify_speed(struct cpufreq_policy *policy)
+static int exynos4_verify_speed(struct cpufreq_policy *policy)
 {
 	return cpufreq_frequency_table_verify(policy, exynos4_freq_table);
 }
 
-unsigned int exynos4_getspeed(unsigned int cpu)
+static unsigned int exynos4_getspeed(unsigned int cpu)
 {
 	return clk_get_rate(cpu_clk) / 1000;
 }
 
-void exynos4_set_clkdiv(unsigned int div_index)
+static void exynos4_set_clkdiv(unsigned int div_index)
 {
 	unsigned int tmp;
 
-- 
1.7.4.1

[PATCH 2/2] cpufreq: s5pv210: make needlessly global symbols static

[Axel Lin]

The following symbols are needlessly defined global:
  s5pv210_verify_speed
  s5pv210_getspeed

Make them static.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/cpufreq/s5pv210-cpufreq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index a7cb338..806408e 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -121,7 +121,7 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port ch, unsigned long freq)
 	__raw_writel(tmp1, reg);
 }
 
-int s5pv210_verify_speed(struct cpufreq_policy *policy)
+static int s5pv210_verify_speed(struct cpufreq_policy *policy)
 {
 	if (policy->cpu)
 		return -EINVAL;
@@ -129,7 +129,7 @@ int s5pv210_verify_speed(struct cpufreq_policy *policy)
 	return cpufreq_frequency_table_verify(policy, s5pv210_freq_table);
 }
 
-unsigned int s5pv210_getspeed(unsigned int cpu)
+static unsigned int s5pv210_getspeed(unsigned int cpu)
 {
 	if (cpu)
 		return 0;
-- 
1.7.4.1

RE: [PATCH 1/2] cpufreq: exynos4210: make needlessly global symbols static

[Kukjin Kim]

Axel Lin wrote:
> 
> The following symbols are needlessly defined global:
>   exynos4_verify_speed
>   exynos4_getspeed
>   exynos4_set_clkdiv
> 
> Make them static.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Yes :)

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  drivers/cpufreq/exynos4210-cpufreq.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/exynos4210-cpufreq.c b/drivers/cpufreq/exynos4210-
> cpufreq.c
> index 54025fc..b7c3a84 100644
> --- a/drivers/cpufreq/exynos4210-cpufreq.c
> +++ b/drivers/cpufreq/exynos4210-cpufreq.c
> @@ -191,17 +191,17 @@ static unsigned int
> exynos4_apll_pms_table[CPUFREQ_LEVEL_END] = {
>  	((200 << 16) | (6 << 8) | 4),
>  };
> 
> -int exynos4_verify_speed(struct cpufreq_policy *policy)
> +static int exynos4_verify_speed(struct cpufreq_policy *policy)
>  {
>  	return cpufreq_frequency_table_verify(policy, exynos4_freq_table);
>  }
> 
> -unsigned int exynos4_getspeed(unsigned int cpu)
> +static unsigned int exynos4_getspeed(unsigned int cpu)
>  {
>  	return clk_get_rate(cpu_clk) / 1000;
>  }
> 
> -void exynos4_set_clkdiv(unsigned int div_index)
> +static void exynos4_set_clkdiv(unsigned int div_index)
>  {
>  	unsigned int tmp;
> 
> --
> 1.7.4.1

RE: [PATCH 2/2] cpufreq: s5pv210: make needlessly global symbols static

[Kukjin Kim]

Axel Lin wrote:
> 
> The following symbols are needlessly defined global:
>   s5pv210_verify_speed
>   s5pv210_getspeed
> 
> Make them static.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  drivers/cpufreq/s5pv210-cpufreq.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> index a7cb338..806408e 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -121,7 +121,7 @@ static void s5pv210_set_refresh(enum s5pv210_dmc_port
> ch, unsigned long freq)
>  	__raw_writel(tmp1, reg);
>  }
> 
> -int s5pv210_verify_speed(struct cpufreq_policy *policy)
> +static int s5pv210_verify_speed(struct cpufreq_policy *policy)
>  {
>  	if (policy->cpu)
>  		return -EINVAL;
> @@ -129,7 +129,7 @@ int s5pv210_verify_speed(struct cpufreq_policy *policy)
>  	return cpufreq_frequency_table_verify(policy, s5pv210_freq_table);
>  }
> 
> -unsigned int s5pv210_getspeed(unsigned int cpu)
> +static unsigned int s5pv210_getspeed(unsigned int cpu)
>  {
>  	if (cpu)
>  		return 0;
> --
> 1.7.4.1