* [PATCH] Cpufreq: Remove fossil comment in the cpufreq_governor_dbs()
@ 2013-11-15 5:54 Lan Tianyu
2013-11-15 8:43 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Lan Tianyu @ 2013-11-15 5:54 UTC (permalink / raw)
To: rjw, viresh.kumar; +Cc: Lan Tianyu, cpufreq, linux-pm, linux-kernel
The related code has been changed and the comment is out of data.
So remove it.
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
---
drivers/cpufreq/cpufreq_governor.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
index 0806c31..e6be635 100644
--- a/drivers/cpufreq/cpufreq_governor.c
+++ b/drivers/cpufreq/cpufreq_governor.c
@@ -328,10 +328,6 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy,
dbs_data->cdata->gov_dbs_timer);
}
- /*
- * conservative does not implement micro like ondemand
- * governor, thus we are bound to jiffes/HZ
- */
if (dbs_data->cdata->governor == GOV_CONSERVATIVE) {
cs_dbs_info->down_skip = 0;
cs_dbs_info->enable = 1;
--
1.8.4.rc0.1.g8f6a3e5.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Cpufreq: Remove fossil comment in the cpufreq_governor_dbs()
2013-11-15 5:54 [PATCH] Cpufreq: Remove fossil comment in the cpufreq_governor_dbs() Lan Tianyu
@ 2013-11-15 8:43 ` Viresh Kumar
2013-11-16 1:11 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2013-11-15 8:43 UTC (permalink / raw)
To: Lan Tianyu
Cc: Rafael J. Wysocki, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, Linux Kernel Mailing List
On 15 November 2013 11:24, Lan Tianyu <tianyu.lan@intel.com> wrote:
> The related code has been changed and the comment is out of data.
> So remove it.
>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> ---
> drivers/cpufreq/cpufreq_governor.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> index 0806c31..e6be635 100644
> --- a/drivers/cpufreq/cpufreq_governor.c
> +++ b/drivers/cpufreq/cpufreq_governor.c
> @@ -328,10 +328,6 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy,
> dbs_data->cdata->gov_dbs_timer);
> }
>
> - /*
> - * conservative does not implement micro like ondemand
> - * governor, thus we are bound to jiffes/HZ
> - */
> if (dbs_data->cdata->governor == GOV_CONSERVATIVE) {
> cs_dbs_info->down_skip = 0;
> cs_dbs_info->enable = 1;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Cpufreq: Remove fossil comment in the cpufreq_governor_dbs()
2013-11-15 8:43 ` Viresh Kumar
@ 2013-11-16 1:11 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2013-11-16 1:11 UTC (permalink / raw)
To: Viresh Kumar
Cc: Lan Tianyu, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
On Friday, November 15, 2013 02:13:26 PM Viresh Kumar wrote:
> On 15 November 2013 11:24, Lan Tianyu <tianyu.lan@intel.com> wrote:
> > The related code has been changed and the comment is out of data.
> > So remove it.
> >
> > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> > ---
> > drivers/cpufreq/cpufreq_governor.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> > index 0806c31..e6be635 100644
> > --- a/drivers/cpufreq/cpufreq_governor.c
> > +++ b/drivers/cpufreq/cpufreq_governor.c
> > @@ -328,10 +328,6 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy,
> > dbs_data->cdata->gov_dbs_timer);
> > }
> >
> > - /*
> > - * conservative does not implement micro like ondemand
> > - * governor, thus we are bound to jiffes/HZ
> > - */
> > if (dbs_data->cdata->governor == GOV_CONSERVATIVE) {
> > cs_dbs_info->down_skip = 0;
> > cs_dbs_info->enable = 1;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Queued up for the next PM pull request, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-16 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 5:54 [PATCH] Cpufreq: Remove fossil comment in the cpufreq_governor_dbs() Lan Tianyu
2013-11-15 8:43 ` Viresh Kumar
2013-11-16 1:11 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox