From: Ducrot Bruno <ducrot@poupinou.org>
To: Dave Jones <davej@redhat.com>
Cc: cpufreq@www.linux.org.uk, Dominik Brodowski <linux@brodo.de>
Subject: Re: [PATCH][DOCUMENTATION BUGFIX] latency in micro-, not nanoseconds
Date: Mon, 10 Nov 2003 18:15:33 +0100 [thread overview]
Message-ID: <20031110171533.GS21970@poupinou.org> (raw)
In-Reply-To: <20031110163209.GP10144@redhat.com>
On Mon, Nov 10, 2003 at 04:32:09PM +0000, Dave Jones wrote:
> On Tue, Nov 04, 2003 at 05:08:16PM +0100, Dominik Brodowski wrote:
> > All drivers [davej, can you please verify for powernow-k7?] set the
> > transition_latency time in microseconds, even though the core demanded
> > nanoseconds. Instead of fixing up the drivers, fix up the core...
>
> Hmm, I think you've unearthed a bug.
>
> The 'latency' we read from the BIOS is in microseconds, but the hardware
> wants it in units of 10ns. We do the necessary maths, and everything is fine.
> But we're also storing that result in ..
>
> policy->cpuinfo.transition_latency = latency;
>
> Which is possibly not the right thing to be doing.
> I think we want to be storing the 'pre 10ns munging' value here correct?
>
Well, maybe we have to double it as well (there is actually 2 steps, the
VID change and the FID change, each having 'latency' 1e(-8) second)...
something like:
policy->cpuinfo.transition_latency = latency / 50;
perhaps?
--
Ducrot Bruno
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
next prev parent reply other threads:[~2003-11-10 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-04 16:08 [PATCH][DOCUMENTATION BUGFIX] latency in micro-, not nanoseconds Dominik Brodowski
2003-11-10 16:32 ` Dave Jones
2003-11-10 17:15 ` Ducrot Bruno [this message]
2003-11-10 17:22 ` Dave Jones
2003-11-10 20:50 ` Dominik Brodowski
2003-11-10 21:16 ` Dave Jones
2003-11-11 18:54 ` Dominik Brodowski
2003-11-11 22:45 ` Dave Jones
2003-11-12 11:01 ` Ducrot Bruno
2003-11-12 14:17 ` Dave Jones
2003-11-12 15:02 ` Ducrot Bruno
-- strict thread matches above, loose matches on Subject: below --
2003-11-11 19:57 Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031110171533.GS21970@poupinou.org \
--to=ducrot@poupinou.org \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux@brodo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox