From: Dominik Brodowski <linux@dominikbrodowski.de>
To: Dave Jones <davej@redhat.com>
Cc: cpufreq@www.linux.org.uk
Subject: Re: [PATCH] fix up CPU detection in p4-clockmod
Date: Sat, 10 Jan 2004 17:19:13 +0100 [thread overview]
Message-ID: <20040110161913.GA4983@dominikbrodowski.de> (raw)
In-Reply-To: <20040110155048.GA17500@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1026 bytes --]
On Sat, Jan 10, 2004 at 03:50:48PM +0000, Dave Jones wrote:
> On Sat, Jan 10, 2004 at 04:12:48PM +0100, Dominik Brodowski wrote:
> > Too many users use the p4-clockmod cpufreq driver instead of the more
> > advanced speedstep-centrino, speedstep-ich or even acpi drivers. All of the
> > latter (usually) provide voltage scaling, while the p4-clockmod driver only
> > offers a variant of frequency scaling. So, warn users if they try out this
> > driver instead.
> >
> > Also, instead of using a local copy, use the speedstep_lib infrastructure
> > for detecting the processor speed. Adding the Pentium-M get_frequency
> > function to that module only costs about 200 bytes in object size.
>
> another idea might be putting the cpu identify code into a speedstep.ko
> and have that request_module the right module
That's not a valid option as a replacement -- there _are_ different modules
possible for the same CPU. However, it's a good idea if it is implemented as
an "autoloader".
Dominik
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq
next prev parent reply other threads:[~2004-01-10 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 15:12 [PATCH] fix up CPU detection in p4-clockmod Dominik Brodowski
2004-01-10 15:50 ` Dave Jones
2004-01-10 16:19 ` Dominik Brodowski [this message]
2004-01-10 22:19 ` Andrew Morton
2004-01-11 11:33 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040110161913.GA4983@dominikbrodowski.de \
--to=linux@dominikbrodowski.de \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox