Re: [PATCH] fix up CPU detection in p4-clockmod

[Dominik Brodowski <linux@dominikbrodowski.de>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1312 bytes --]

On Sat, Jan 10, 2004 at 02:19:46PM -0800, Andrew Morton wrote:
> Dave Jones <davej@redhat.com> wrote:
> >
> > On Sat, Jan 10, 2004 at 04:12:48PM +0100, Dominik Brodowski wrote:
> >  > Too many users use the p4-clockmod cpufreq driver instead of the more
> >  > advanced speedstep-centrino, speedstep-ich or even acpi drivers. All of the
> >  > latter (usually) provide voltage scaling, while the p4-clockmod driver only
> >  > offers a variant of frequency scaling. So, warn users if they try out this
> >  > driver instead.
> >  > 
> >  > Also, instead of using a local copy, use the speedstep_lib infrastructure
> >  > for detecting the processor speed. Adding the Pentium-M get_frequency
> >  > function to that module only costs about 200 bytes in object size.
> > 
> > another idea might be putting the cpu identify code into a speedstep.ko
> > and have that request_module the right module
> > 
> 
> That seems like a more user-friendly approach to me.
> 
> I'll merge Dominik's patch while we think about it.

We still need cpu identification code in the various speedstep-* drivers as
they need to do a few things differently on different CPUs...

The "request_modul"ing of the right module could be done more easily in
userspace, IMHO. A small sample is attached.

	Dominik

[-- Attachment #1.1.2: cpufreq_x86.sh --]
[-- Type: application/x-sh, Size: 2875 bytes --]

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq