From: Dave Jones <davej@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.de>,
cpufreq list <cpufreq@www.linux.org.uk>
Subject: Re: my dothan didn't work with cpufreq...
Date: Mon, 2 Aug 2004 20:26:08 +0100 [thread overview]
Message-ID: <20040802192608.GA17023@redhat.com> (raw)
In-Reply-To: <1090632444.2950.1.camel@localhost>
On Fri, Jul 23, 2004 at 06:27:24PM -0700, Jeremy Fitzhardinge wrote:
> On Fri, 2004-07-23 at 21:38 +0200, Dominik Brodowski wrote:
> > Again IIRC, it's less about CodingStyle and more about some GCC 3.?
> > warnings? Though, gcc 3.3.4 doesn't complain...
>
> You mean the "[idx] = " syntax?
>
> Anyway, having said that, I got it wrong (I had vendor and family
> switched). Fixed patch attached.
I merged this, but something occurred to me whilst eyeballing
the diffs. Rather than duplicating X86_VENDOR_INTEL in every
entry of the struct, how about we check it in one place?
I'm unaware of any vendor planning to duplicate speedstep,
but even if AMD/VIA threw away their current implementations
in favour of a bit-for-bit compatible implementation, it
wouldn't be hard to add an extra if()
comments?
Dave
next prev parent reply other threads:[~2004-08-02 19:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-12 20:54 my dothan didn't work with cpufreq Damien Marchal
2004-07-13 9:49 ` Dominik Brodowski
2004-07-14 10:50 ` Damien Marchal
2004-07-16 8:19 ` Dominik Brodowski
2004-07-22 1:55 ` Jeremy Fitzhardinge
2004-07-22 6:04 ` Dominik Brodowski
2004-07-22 6:56 ` Jeremy Fitzhardinge
2004-07-22 9:31 ` Dominik Brodowski
2004-07-22 17:34 ` Jeremy Fitzhardinge
2004-07-23 19:38 ` Dominik Brodowski
2004-07-24 1:27 ` Jeremy Fitzhardinge
2004-07-24 7:06 ` Dominik Brodowski
2004-08-02 19:26 ` Dave Jones [this message]
2004-08-02 20:17 ` Jeremy Fitzhardinge
2004-08-02 20:29 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040802192608.GA17023@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@www.linux.org.uk \
--cc=jeremy@goop.org \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox