From: Dominik Brodowski <linux@dominikbrodowski.de>
To: Alexander Clouter <alex@digriz.org.uk>
Cc: cpufreq@lists.linux.org.uk
Subject: Re: [PATCH] cpufreq_(ondemand|conservative)
Date: Sat, 29 Jan 2005 21:00:20 +0100 [thread overview]
Message-ID: <20050129200020.GA9542@dominikbrodowski.de> (raw)
In-Reply-To: <20050123150000.GA3888@inskipp>
concerning patch #1:
On Sun, Jan 23, 2005 at 03:00:01PM +0000, Alexander Clouter wrote:
> @@ -398,10 +455,10 @@
>
> j_dbs_info->prev_cpu_idle_up =
> kstat_cpu(j).cpustat.idle +
> - kstat_cpu(j).cpustat.iowait;
> - j_dbs_info->prev_cpu_idle_down =
> - kstat_cpu(j).cpustat.idle +
> - kstat_cpu(j).cpustat.iowait;
> + kstat_cpu(j).cpustat.iowait +
> + kstat_cpu(j).cpustat.nice;
Why are you adding cpustat.nice here unconditionally? You don't do so in the
sysfs write method, so I assume you should make this dependant on
ignore_nice here as well.
Dominik
next prev parent reply other threads:[~2005-01-29 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 15:00 [PATCH] cpufreq_(ondemand|conservative) Alexander Clouter
2005-01-29 20:00 ` Dominik Brodowski [this message]
2005-01-29 23:20 ` Alexander Clouter
2005-01-29 20:09 ` Dominik Brodowski
-- strict thread matches above, loose matches on Subject: below --
2005-01-31 22:37 Pallipadi, Venkatesh
2005-02-01 9:02 ` Alexander Clouter
2005-01-31 23:40 Pallipadi, Venkatesh
2005-02-04 20:39 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050129200020.GA9542@dominikbrodowski.de \
--to=linux@dominikbrodowski.de \
--cc=alex@digriz.org.uk \
--cc=cpufreq@lists.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox