Re: [PATCH] cpufreq_(ondemand|conservative)

[Dominik Brodowski <linux@dominikbrodowski.de>]

On Mon, Jan 31, 2005 at 03:40:24PM -0800, Pallipadi, Venkatesh wrote:
> >> > @@ -398,10 +455,10 @@
> >> >  		
> >> >  			j_dbs_info->prev_cpu_idle_up = 
> >> >  				kstat_cpu(j).cpustat.idle +
> >> > -				kstat_cpu(j).cpustat.iowait;
> >> > -			j_dbs_info->prev_cpu_idle_down = 
> >> > -				kstat_cpu(j).cpustat.idle +
> >> > -				kstat_cpu(j).cpustat.iowait;
> >> > +				kstat_cpu(j).cpustat.iowait +
> >> > +				kstat_cpu(j).cpustat.nice;
> >> 
> >> Why are you adding cpustat.nice here unconditionally? You 
> >don't do so in the
> >> sysfs write method, so I assume you should make this dependant on 
> >> ignore_nice here as well.
> >> 
> >Well by default 'ignore_nice = 0' so is there a need?  Look in 
> >the next hunk.
> >
> 
> Probably it is better idea to have a if, even if the default is 0, as
> If we change the default in future, we don't have to look for all these
> dependent changes.

AFAICS we _do_ need it, as prev_cpu_idle_up is calculated
	idle time +
	iowait time +
	(ignore_nice ? ignore time : NULL)
in many other places.

	Dominik