Re: [PATCH] AMD Elan SC520 cpufreq driver

[Dominik Brodowski <linux@dominikbrodowski.net>]

Hi,

> +#include <linux/slab.h>

What do you need slab.h for?

> +	printk(KERN_INFO "sc520_freq: attempting to set frequency to %i kHz\n",
> +			sc520_freq_table[state].frequency);

Please change this to a dprintk and use the cpufreq_debug infrastructure for
that -- users who want to use dynamic frequency scaling don't want to have
their dmesg flooded with printk's :)

> +	policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;

Do you know how long a transition takes and for how long no other transition
may be done?

> +        cpufreq_frequency_table_get_attr(sc520_freq_table, policy->cpu);

broken indenting

> +	/* Test if we have the right hardware */
> +	if (c->x86_vendor != X86_VENDOR_AMD ||
> +		c->x86 != 4 || c->x86_model != 9) {
> +		printk(KERN_INFO "sc520_freq: error: no Elan SC520 processor found!\n");

please do only a dprintk here as well, and I think a tab is missing, too.


Nice work :)

Thanks,
	Dominik