From: Dominik Brodowski <linux@dominikbrodowski.net>
To: davej@redhat.com, Eric Piel <Eric.Piel@tremplin-utc.net>
Cc: cpufreq@lists.linux.org.uk
Subject: [PATCH] cpufreq: fix latency comment in cpufreq.h [Was: Re: [PATCH] AMD Elan SC520 cpufreq driver]
Date: Sat, 9 Apr 2005 22:20:55 +0200 [thread overview]
Message-ID: <20050409202055.GA30626@dominikbrodowski.de> (raw)
In-Reply-To: <425081E0.6070205@tremplin-utc.net>
On Mon, Apr 04, 2005 at 01:53:04AM +0200, Eric Piel wrote:
> Sean Young a écrit :
> >- policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;
> >+ policy->cpuinfo.transition_latency = 1000; /* 1ms */
>
> transition_latency is expressed in nanoseconds, so it should be 1000000.
> I guess the confusion comes from cpufreq.h, where there are two comments
> about it, one saying it's nanosecond, another one (older) saying it's
> microseconds. Dominik, maybe this typo should be fixed, do you want me
> to send a patch?
Nice catch.
Fix up comment in cpufreq.h stating transition latency should be passed
in microseconds -- it was decided long ago to switch to nanoseconds.
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Index: 2.6.12-rc2/include/linux/cpufreq.h
===================================================================
--- 2.6.12-rc2.orig/include/linux/cpufreq.h 2005-03-02 18:23:48.000000000 +0100
+++ 2.6.12-rc2/include/linux/cpufreq.h 2005-04-09 22:19:04.000000000 +0200
@@ -49,7 +49,7 @@
/* Frequency values here are CPU kHz so that hardware which doesn't run
* with some frequencies can complain without having to guess what per
* cent / per mille means.
- * Maximum transition latency is in microseconds - if it's unknown,
+ * Maximum transition latency is in nanoseconds - if it's unknown,
* CPUFREQ_ETERNAL shall be used.
*/
next prev parent reply other threads:[~2005-04-09 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 21:36 [PATCH] AMD Elan SC520 cpufreq driver Sean Young
2005-03-29 21:50 ` Eric Piel
2005-03-29 23:42 ` Sean Young
2005-03-29 22:04 ` Dominik Brodowski
2005-04-03 16:27 ` Sean Young
2005-04-03 23:53 ` Eric Piel
2005-04-09 20:20 ` Dominik Brodowski [this message]
2005-04-09 21:43 ` [PATCH] cpufreq: fix latency comment in cpufreq.h [Was: Re: [PATCH] AMD Elan SC520 cpufreq driver] Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050409202055.GA30626@dominikbrodowski.de \
--to=linux@dominikbrodowski.net \
--cc=Eric.Piel@tremplin-utc.net \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox