cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Braun <Felix.Braun@mail.mcgill.ca>
To: CPUFreq@lists.linux.org.uk
Subject: [PATCH 2.6.14] cpufreq: don't suggest speedstep-centrino for Dothan-based Celeron-M processors
Date: Fri, 2 Dec 2005 14:57:11 +0100	[thread overview]
Message-ID: <20051202145711.33191cef@tilion.getrex.org> (raw)

Hi there,

I recently bought a laptop which is reported by Intel's CPUid tool as a
Celeron-M 373. Linux identifies this processor like this (/proc/cpuinfo)

processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 13
model name	: Intel(R) Celeron(R) M processor         1.00GHz
stepping	: 8
cpu MHz		: 999.915
cache size	: 512 KB
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr
pge mca cmov pat clflush dts acpi mmx fxsr sse sse2 ss tm pbe
bogomips	: 2001.80

I would like to use CPU frequency scaling to increase my battery life. As
this processor can't do EnhancedSpeedStep (Celerons seem to be unable to
do so in general) I've been using the p4-clockmod driver.

However, as my processor is based on the Dothan architecture (cpu_family
6, model 13), I get a warning that I should use speedstep_centrino
instead. This warning is misleading because I have a Celeron. Therefore, I
suggest the following patch to silence this warning.

================
We only have a Pentium-M (Dothan) if the cache size is 2048K. Don't print
the warning for Dothan-based Celeron-M processors which have a cache size
of 512K or 1024K.

Signed-off-by: Felix Braun <Felix.Braun@mail.McGill.ca>

--- a/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c  2005-12-01 23:47:01 +0100
+++ b/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c  2005-12-01 23:50:11 +0100
@@ -171,7 +171,8 @@
                return speedstep_get_processor_frequency(SPEEDSTEP_PROCESSOR_PM);
        }
 
-       if ((c->x86 == 0x06) && (c->x86_model == 0x0D)) {
+       if ((c->x86 == 0x06) && (c->x86_model == 0x0D)
+                       && (c->x86_cache_size == 2048)) {
                /* Pentium M (Dothan) */
                printk(KERN_WARNING PFX "Warning: Pentium M detected. "
                       "The speedstep_centrino module offers voltage scaling"

             reply	other threads:[~2005-12-02 13:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-02 13:57 Felix Braun [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-12-02 14:26 [PATCH 2.6.14] cpufreq: don't suggest speedstep-centrino for Dothan-based Celeron-M processors Pallipadi, Venkatesh
2005-12-02 14:52 ` Felix Braun
2005-12-02 15:04 ` Bruno Ducrot
2005-12-02 16:58 Pallipadi, Venkatesh
2005-12-02 19:29 ` Felix Braun
2005-12-02 21:06 ` Bruno Ducrot
2005-12-02 21:19 Pallipadi, Venkatesh
2005-12-04 16:46 ` Dominik Brodowski
2005-12-05 11:00   ` Bruno Ducrot
2005-12-06  6:01     ` Dominik Brodowski
2005-12-06 10:03       ` Bruno Ducrot
2005-12-06 10:10         ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051202145711.33191cef@tilion.getrex.org \
    --to=felix.braun@mail.mcgill.ca \
    --cc=CPUFreq@lists.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox