From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Eric Piel <Eric.Piel@lifl.fr>,
CPUFreq Mailing List <cpufreq@lists.linux.org.uk>,
Eric Piel <eric.piel@tremplin-utc.net>,
davej@redhat.com
Subject: Re: [PATCH 1/2] Move PMBASE reading away and do it only once at initialization time
Date: Sun, 4 Dec 2005 17:58:42 +0100 [thread overview]
Message-ID: <20051204165842.GD8422@isilmar.linta.de> (raw)
In-Reply-To: <20051130210059.GC3620@inferi.kami.home>
On Wed, Nov 30, 2005 at 10:00:59PM +0100, Mattia Dongili wrote:
> On Wed, Nov 30, 2005 at 12:02:59PM +0100, Eric Piel wrote:
> [...]
> > >@@ -400,6 +415,10 @@ static int __init speedstep_init(void)
> > > return -EINVAL;
> > > }
> > >
> > >+ if (speedstep_find_register()) {
> > >+ return -ENODEV;
> > >+ }
> > >+
> > Please, keep it simple and do put { and } when there is only one line.
>
> I assume you meant "do not put" :)
> attached the fixed patch (with removed extra white space also).
>
> This patch moves away PMBASE reading and only performs it at
> cpufreq_register_driver time by exiting with -ENODEV if unable to read
> the value.
>
> Signed-off-by: Mattia Dongili <malattia@linux.it>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
prev parent reply other threads:[~2005-12-04 16:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-29 23:58 [RFC][PATCH 0/0] measure speedstep-ich transition latency at CPU initialization Mattia Dongili
2005-11-29 23:58 ` [PATCH 1/2] Move PMBASE reading away and do it only once at initialization time Mattia Dongili
2005-11-29 23:58 ` [PATCH 2/2] Measure transition latency at driver initialization Mattia Dongili
2005-11-30 11:46 ` Eric Piel
2005-11-30 22:30 ` Mattia Dongili
2005-11-30 23:41 ` Eric Piel
2005-12-01 19:31 ` [PATCH 2/2 updated] " Mattia Dongili
2005-12-01 21:05 ` Eric Piel
2005-12-01 23:34 ` Mattia Dongili
2005-12-02 11:37 ` Eric Piel
2005-12-02 13:34 ` Mattia Dongili
2005-12-02 20:59 ` Mattia Dongili
2005-12-02 23:43 ` Eric Piel
2005-12-04 17:00 ` Dominik Brodowski
2005-12-02 4:38 ` Ville Syrjälä
2005-11-30 11:02 ` [PATCH 1/2] Move PMBASE reading away and do it only once at initialization time Eric Piel
2005-11-30 21:00 ` Mattia Dongili
2005-12-04 16:58 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051204165842.GD8422@isilmar.linta.de \
--to=linux@dominikbrodowski.net \
--cc=Eric.Piel@lifl.fr \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@redhat.com \
--cc=eric.piel@tremplin-utc.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox