Re: [PATCH 1/2] Move PMBASE reading away and do it only once at initialization time

[Eric Piel <Eric.Piel@lifl.fr>]

IMHO, this looks very fine :-)


11/30/2005 12:58 AM, Mattia Dongili wrote/a écrit:
> Signed-off-by: Mattia Dongili <malattia@linux.it>
> 
> ---
> 
>  arch/i386/kernel/cpu/cpufreq/speedstep-ich.c |   45 ++++++++++++++++++--------
>  1 files changed, 32 insertions(+), 13 deletions(-)
> 
> applies-to: 41c86716d1584bad6ddf55c9132ef8b820bc1b15
> 31c370b9ba20188340635fd7cebc150c4b71b097
> diff --git a/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c b/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c
> index 5b7d18a..17b7864 100644
> --- a/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c
> +++ b/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c
:
> @@ -400,6 +415,10 @@ static int __init speedstep_init(void)
>  		return -EINVAL;
>  	}
>  
> +	if (speedstep_find_register()) {
> +		return -ENODEV;
> +	}
> +
Please, keep it simple and do put { and } when there is only one line.


>  	return cpufreq_register_driver(&speedstep_driver);
>  }
>