cpufreq and modular build

cpufreq and modular build

[Goran]

Hello.

I have a question regarding cpufreq and modular build.

Looking in Kconfig file for 2.6.24.5 kernel version I see this:

---------------------------------------------------------------------------
config CPU_FREQ
        bool "CPU Frequency scaling"
        help
          CPU Frequency scaling allows you to change the clock speed of
          CPUs on the fly. This is a nice method to save power, because
          the lower the CPU clock speed, the less power the CPU consumes.

          Note that this driver doesn't automatically change the CPU
          clock speed, you need to either enable a dynamic cpufreq governor
          (see below) after boot, or use a userspace tool.

          To compile this driver as a module, choose M here: the
          module will be called cpufreq.

          For details, take a look at <file:Documentation/cpu-freq>.

          If in doubt, say N.
---------------------------------------------------------------------------

So there's a discrepancy between the way this setting is added in the
Kconfig file and the help text.  Help text suggests this can be built as a
module, and there is also (some?) support for that in the source code,
but Kconfig file does not allow one to build it as a module.

Which bit needs fixing - help text or the "bool" setting?

Please cc: me on replies as I am not subscribed to the list.

Regards,
        Goran

Re: cpufreq and modular build

[Thomas Renninger]

On Mon, 2008-05-05 at 17:58 +0200, Goran wrote:
>           To compile this driver as a module, choose M here: the
>           module will be called cpufreq.

This should just be cut out. Could you send a patch?

Thanks,

   Thomas

Re: cpufreq and modular build

[Goran]

On Tue, 06 May 2008 17:12:43 +0200
Thomas Renninger <trenn@suse.de> wrote:

Hi again.

> >           To compile this driver as a module, choose M here: the
> >           module will be called cpufreq.
> 
> This should just be cut out. Could you send a patch?

I have checked cpufreq git tree as well as latest official linux-2.6 tree
and it has been fixed already in both (as early as february).  Sorry for
the noise, I should have checked the git repositories before asking.

Thanks,
        Goran

Re: cpufreq and modular build

[Dave Jones]

On Tue, May 06, 2008 at 05:12:43PM +0200, Thomas Renninger wrote:
 >
 > On Mon, 2008-05-05 at 17:58 +0200, Goran wrote:
 > >           To compile this driver as a module, choose M here: the
 > >           module will be called cpufreq.
 >
 > This should just be cut out. Could you send a patch?

We fixed this back in November!
Commit 232e8884cb62f865d69383e42ef333215da504d4

        Dave