From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk
Subject: Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE
Date: Mon, 06 Jan 2014 02:08:21 +0100 [thread overview]
Message-ID: <39696841.2xGCnmPGdl@vostro.rjw.lan> (raw)
In-Reply-To: <a76f7b6a290d9174a24e15b13df21f53e3f5655f.1388736624.git.viresh.kumar@linaro.org>
On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote:
> arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence
> must be dependent on CONFIG_BIG_LITTLE.
>
> This was highlighted by Russell earlier when he reported this issue:
>
> drivers/built-in.o: In function `bL_cpufreq_set_rate':
> powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb'
>
> Reported-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Queued up for 3.14, thanks!
> ---
> drivers/cpufreq/Kconfig.arm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 456ba5e..3275e9c 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -4,7 +4,7 @@
>
> config ARM_BIG_LITTLE_CPUFREQ
> tristate "Generic ARM big LITTLE CPUfreq driver"
> - depends on ARM && ARM_CPU_TOPOLOGY && HAVE_CLK
> + depends on ARM && BIG_LITTLE && ARM_CPU_TOPOLOGY && HAVE_CLK
> select PM_OPP
> help
> This enables the Generic CPUfreq driver for ARM big.LITTLE platforms.
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-01-06 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 10:21 [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE Viresh Kumar
2014-01-06 1:08 ` Rafael J. Wysocki [this message]
2014-01-06 0:58 ` Russell King - ARM Linux
2014-01-06 1:23 ` Rafael J. Wysocki
2014-01-06 1:11 ` Russell King - ARM Linux
2014-01-06 1:32 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39696841.2xGCnmPGdl@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox