* RE: [2.6 PATCH] Missing default governors choices
@ 2004-08-26 16:40 Pallipadi, Venkatesh
2004-08-26 19:23 ` GoatZilla
0 siblings, 1 reply; 3+ messages in thread
From: Pallipadi, Venkatesh @ 2004-08-26 16:40 UTC (permalink / raw)
To: Michal Rokos, cpufreq; +Cc: linux-kernel
Ondemand govrenor not being one of the default governors is intentional.
Ondemand governor is in-kernel cpu frequency governor, that will
Be beneficial for CPUs that supports frequency change with low
transition_latency. If transition_latency is high, the ondemand governor
initialization will fail (User level governor is suggested in this
case).
Hence it cannot be used as a default governor.
Thanks,
Venki
>-----Original Message-----
>From: cpufreq-bounces@www.linux.org.uk
>[mailto:cpufreq-bounces@www.linux.org.uk] On Behalf Of Michal Rokos
>Sent: Thursday, August 26, 2004 12:07 AM
>To: cpufreq@www.linux.org.uk
>Cc: linux-kernel@vger.kernel.org
>Subject: [2.6 PATCH] Missing default governors choices
>
>Hello,
>
>aren't these 2 missing in "Default CPUFreq governor" menu?
>
>Thank you.
>
> Michal
>
>PS: CC to me (I'm off the lists)
>
># This is a BitKeeper generated diff -Nru style patch.
>#
># ChangeSet
># 2004/08/26 08:57:24+02:00 michal@rokos.info
># Add missing governors to "Default CPUFreq governor" menu.
>#
># drivers/cpufreq/Kconfig
># 2004/08/26 08:57:13+02:00 michal@rokos.info +16 -0
># Add missing governors to "Default CPUFreq governor" menu.
>#
>diff -Nru a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
>--- a/drivers/cpufreq/Kconfig 2004-08-26 09:00:15 +02:00
>+++ b/drivers/cpufreq/Kconfig 2004-08-26 09:00:15 +02:00
>@@ -27,6 +27,14 @@
> the frequency statically to the highest frequency supported by
> the CPU.
>
>+config CPU_FREQ_DEFAULT_GOV_POWERSAVE
>+ bool "powersave"
>+ select CPU_FREQ_GOV_POWERSAVE
>+ help
>+ Use the CPUFreq governor 'powersave' as default. This sets
>+ the frequency statically to the lowest frequency supported by
>+ the CPU.
>+
> config CPU_FREQ_DEFAULT_GOV_USERSPACE
> bool "userspace"
> select CPU_FREQ_GOV_USERSPACE
>@@ -35,6 +43,14 @@
> you to set the CPU frequency manually or when an userspace
> programm shall be able to set the CPU dynamically without having
> to enable the userspace governor manually.
>+
>+config CPU_FREQ_DEFAULT_GOV_ONDEMAND
>+ bool "ondemand"
>+ select CPU_FREQ_GOV_ONDEMAND
>+ help
>+ Use the CPUFreq governor 'ondemand' as default. This does
>+ a periodic polling and changes frequency based on the CPU
>+ utilization.
>
> endchoice
>
>
>
>_______________________________________________
>Cpufreq mailing list
>Cpufreq@www.linux.org.uk
>http://www.linux.org.uk/mailman/listinfo/cpufreq
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 PATCH] Missing default governors choices
2004-08-26 16:40 [2.6 PATCH] Missing default governors choices Pallipadi, Venkatesh
@ 2004-08-26 19:23 ` GoatZilla
0 siblings, 0 replies; 3+ messages in thread
From: GoatZilla @ 2004-08-26 19:23 UTC (permalink / raw)
To: cpufreq
What's the reason for the powersave governor not being selectable as default?
On Thu, 26 Aug 2004 09:40:08 -0700, Pallipadi, Venkatesh
<venkatesh.pallipadi@intel.com> wrote:
>
>
> Ondemand govrenor not being one of the default governors is intentional.
>
> Ondemand governor is in-kernel cpu frequency governor, that will
> Be beneficial for CPUs that supports frequency change with low
> transition_latency. If transition_latency is high, the ondemand governor
>
> initialization will fail (User level governor is suggested in this
> case).
> Hence it cannot be used as a default governor.
>
> Thanks,
> Venki
>
>
>
> >-----Original Message-----
> >From: cpufreq-bounces@www.linux.org.uk
> >[mailto:cpufreq-bounces@www.linux.org.uk] On Behalf Of Michal Rokos
> >Sent: Thursday, August 26, 2004 12:07 AM
> >To: cpufreq@www.linux.org.uk
> >Cc: linux-kernel@vger.kernel.org
> >Subject: [2.6 PATCH] Missing default governors choices
> >
> >Hello,
> >
> >aren't these 2 missing in "Default CPUFreq governor" menu?
> >
> >Thank you.
> >
> > Michal
> >
> >PS: CC to me (I'm off the lists)
> >
> ># This is a BitKeeper generated diff -Nru style patch.
> >#
> ># ChangeSet
> ># 2004/08/26 08:57:24+02:00 michal@rokos.info
> ># Add missing governors to "Default CPUFreq governor" menu.
> >#
> ># drivers/cpufreq/Kconfig
> ># 2004/08/26 08:57:13+02:00 michal@rokos.info +16 -0
> ># Add missing governors to "Default CPUFreq governor" menu.
> >#
> >diff -Nru a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> >--- a/drivers/cpufreq/Kconfig 2004-08-26 09:00:15 +02:00
> >+++ b/drivers/cpufreq/Kconfig 2004-08-26 09:00:15 +02:00
> >@@ -27,6 +27,14 @@
> > the frequency statically to the highest frequency supported by
> > the CPU.
> >
> >+config CPU_FREQ_DEFAULT_GOV_POWERSAVE
> >+ bool "powersave"
> >+ select CPU_FREQ_GOV_POWERSAVE
> >+ help
> >+ Use the CPUFreq governor 'powersave' as default. This sets
> >+ the frequency statically to the lowest frequency supported by
> >+ the CPU.
> >+
> > config CPU_FREQ_DEFAULT_GOV_USERSPACE
> > bool "userspace"
> > select CPU_FREQ_GOV_USERSPACE
> >@@ -35,6 +43,14 @@
> > you to set the CPU frequency manually or when an userspace
> > programm shall be able to set the CPU dynamically without having
> > to enable the userspace governor manually.
> >+
> >+config CPU_FREQ_DEFAULT_GOV_ONDEMAND
> >+ bool "ondemand"
> >+ select CPU_FREQ_GOV_ONDEMAND
> >+ help
> >+ Use the CPUFreq governor 'ondemand' as default. This does
> >+ a periodic polling and changes frequency based on the CPU
> >+ utilization.
> >
> > endchoice
> >
> >
> >
> >_______________________________________________
> >Cpufreq mailing list
> >Cpufreq@www.linux.org.uk
> >http://www.linux.org.uk/mailman/listinfo/cpufreq
> >
>
> _______________________________________________
> Cpufreq mailing list
> Cpufreq@www.linux.org.uk
> http://www.linux.org.uk/mailman/listinfo/cpufreq
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 PATCH] Missing default governors choices
@ 2004-08-26 7:07 Michal Rokos
0 siblings, 0 replies; 3+ messages in thread
From: Michal Rokos @ 2004-08-26 7:07 UTC (permalink / raw)
To: cpufreq; +Cc: linux-kernel
Hello,
aren't these 2 missing in "Default CPUFreq governor" menu?
Thank you.
Michal
PS: CC to me (I'm off the lists)
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/08/26 08:57:24+02:00 michal@rokos.info
# Add missing governors to "Default CPUFreq governor" menu.
#
# drivers/cpufreq/Kconfig
# 2004/08/26 08:57:13+02:00 michal@rokos.info +16 -0
# Add missing governors to "Default CPUFreq governor" menu.
#
diff -Nru a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
--- a/drivers/cpufreq/Kconfig 2004-08-26 09:00:15 +02:00
+++ b/drivers/cpufreq/Kconfig 2004-08-26 09:00:15 +02:00
@@ -27,6 +27,14 @@
the frequency statically to the highest frequency supported by
the CPU.
+config CPU_FREQ_DEFAULT_GOV_POWERSAVE
+ bool "powersave"
+ select CPU_FREQ_GOV_POWERSAVE
+ help
+ Use the CPUFreq governor 'powersave' as default. This sets
+ the frequency statically to the lowest frequency supported by
+ the CPU.
+
config CPU_FREQ_DEFAULT_GOV_USERSPACE
bool "userspace"
select CPU_FREQ_GOV_USERSPACE
@@ -35,6 +43,14 @@
you to set the CPU frequency manually or when an userspace
programm shall be able to set the CPU dynamically without having
to enable the userspace governor manually.
+
+config CPU_FREQ_DEFAULT_GOV_ONDEMAND
+ bool "ondemand"
+ select CPU_FREQ_GOV_ONDEMAND
+ help
+ Use the CPUFreq governor 'ondemand' as default. This does
+ a periodic polling and changes frequency based on the CPU
+ utilization.
endchoice
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-08-26 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-26 16:40 [2.6 PATCH] Missing default governors choices Pallipadi, Venkatesh
2004-08-26 19:23 ` GoatZilla
-- strict thread matches above, loose matches on Subject: below --
2004-08-26 7:07 Michal Rokos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox