public inbox for cpufreq@vger.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: cpufreq@vger.kernel.org
Subject: [Bug 66751] [BISECTED]Does not resume from suspend (bisected)
Date: Mon, 09 Dec 2013 14:39:09 +0000	[thread overview]
Message-ID: <bug-66751-12968-PGuJtoyaAv@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-66751-12968@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=66751

--- Comment #3 from Bj√∏rn Mork <bjorn@mork.no> ---
Yes, this is a pretty interesting one. The bug is caused by the combination of
two commits added between -rc2 and -rc3:

 5a87182aa21d cpufreq: suspend governors on system suspend/hibernate
 2167e2399dc5 cpufreq: fix garbage kobjects on errors during suspend/resume

The order these are applied is really arbitrary, and the bisect will point to
the last one applied. Which happens to be 2167e2399dc5. But I will still claim
that it was commit 5a87182aa21d that caused this bug by adding even more
special handling of cpufreq suspend.  This needs to be done properly if it is
done at all, including hooks for drivers and governors. Adding special cases
and "if suspending" tests here and there with subtle implicit dependencies
between the different code blocks is not going to fly.

Note that reverting only 5a87182aa21d will fix the problem, with simpler code
and no dangling sysfs files as a result.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2013-12-09 14:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07 12:30 [Bug 66751] New: Does not resume from suspend (bisected) bugzilla-daemon
2013-12-07 13:50 ` [Bug 66751] " bugzilla-daemon
2013-12-07 21:19 ` bugzilla-daemon
2013-12-09 13:41 ` [Bug 66751] [BISECTED]Does " bugzilla-daemon
2013-12-09 13:41 ` bugzilla-daemon
2013-12-09 14:39 ` bugzilla-daemon [this message]
2013-12-10  6:55 ` bugzilla-daemon
2013-12-10  6:55 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-66751-12968-PGuJtoyaAv@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=cpufreq@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox