* [PATCH] Add mbedtls to PKGMODULES
@ 2026-06-01 20:37 Anton Lundin
2026-06-02 11:41 ` Milan Broz
0 siblings, 1 reply; 4+ messages in thread
From: Anton Lundin @ 2026-06-01 20:37 UTC (permalink / raw)
To: cryptsetup; +Cc: Anton Lundin
When cryptsetup is built with --with-crypto_backend=mbedtls, the
pkg-config file for libcryptsetup should include mbedtls.
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 52ddf11b..260b0ab6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -741,6 +741,7 @@ case $with_crypto_backend in
openssl) PKGMODULES="$PKGMODULES openssl" ;;
nss) PKGMODULES="$PKGMODULES nss" ;;
nettle) PKGMODULES="$PKGMODULES nettle" ;;
+ mbedtls) PKGMODULES="$PKGMODULES mbedtls" ;;
esac
if test "x$enable_libargon2" = "xyes"; then
PKGMODULES="$PKGMODULES libargon2"
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Add mbedtls to PKGMODULES
2026-06-01 20:37 [PATCH] Add mbedtls to PKGMODULES Anton Lundin
@ 2026-06-02 11:41 ` Milan Broz
2026-06-05 17:11 ` Anton Lundin
0 siblings, 1 reply; 4+ messages in thread
From: Milan Broz @ 2026-06-02 11:41 UTC (permalink / raw)
To: Anton Lundin; +Cc: cryptsetup development
Hi,
I added the patch to MR for review
https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/931
Thanks,
Milan
On 6/1/26 10:37 PM, Anton Lundin wrote:
> When cryptsetup is built with --with-crypto_backend=mbedtls, the
> pkg-config file for libcryptsetup should include mbedtls.
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index 52ddf11b..260b0ab6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -741,6 +741,7 @@ case $with_crypto_backend in
> openssl) PKGMODULES="$PKGMODULES openssl" ;;
> nss) PKGMODULES="$PKGMODULES nss" ;;
> nettle) PKGMODULES="$PKGMODULES nettle" ;;
> + mbedtls) PKGMODULES="$PKGMODULES mbedtls" ;;
> esac
> if test "x$enable_libargon2" = "xyes"; then
> PKGMODULES="$PKGMODULES libargon2"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add mbedtls to PKGMODULES
2026-06-02 11:41 ` Milan Broz
@ 2026-06-05 17:11 ` Anton Lundin
2026-06-05 18:42 ` Milan Broz
0 siblings, 1 reply; 4+ messages in thread
From: Anton Lundin @ 2026-06-05 17:11 UTC (permalink / raw)
To: Milan Broz; +Cc: cryptsetup development
On 02 juni, 2026 - Milan Broz wrote:
> Hi,
>
> I added the patch to MR for review
> https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/931
>
I was trying to figure out what the projects workflow was, and it looked
like there were both patches on the mailing list and MR's on gitlab, and
due to me not having a gitlab account since earlier it was just easier
to send it to the ML.
Thanks for the review and merging the code.
//Anton
> On 6/1/26 10:37 PM, Anton Lundin wrote:
> > When cryptsetup is built with --with-crypto_backend=mbedtls, the
> > pkg-config file for libcryptsetup should include mbedtls.
> > ---
> > configure.ac | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 52ddf11b..260b0ab6 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -741,6 +741,7 @@ case $with_crypto_backend in
> > openssl) PKGMODULES="$PKGMODULES openssl" ;;
> > nss) PKGMODULES="$PKGMODULES nss" ;;
> > nettle) PKGMODULES="$PKGMODULES nettle" ;;
> > + mbedtls) PKGMODULES="$PKGMODULES mbedtls" ;;
> > esac
> > if test "x$enable_libargon2" = "xyes"; then
> > PKGMODULES="$PKGMODULES libargon2"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add mbedtls to PKGMODULES
2026-06-05 17:11 ` Anton Lundin
@ 2026-06-05 18:42 ` Milan Broz
0 siblings, 0 replies; 4+ messages in thread
From: Milan Broz @ 2026-06-05 18:42 UTC (permalink / raw)
To: Anton Lundin; +Cc: cryptsetup development
On 6/5/26 7:11 PM, Anton Lundin wrote:
> On 02 juni, 2026 - Milan Broz wrote:
>
>> Hi,
>>
>> I added the patch to MR for review
>> https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/931
>>
>
> I was trying to figure out what the projects workflow was, and it looked
> like there were both patches on the mailing list and MR's on gitlab, and
> due to me not having a gitlab account since earlier it was just easier
> to send it to the ML.
Just for info (but I guess you already read that), workflow is documented here
https://gitlab.com/cryptsetup/cryptsetup/-/blob/main/CONTRIBUTING.md
Milan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-05 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-01 20:37 [PATCH] Add mbedtls to PKGMODULES Anton Lundin
2026-06-02 11:41 ` Milan Broz
2026-06-05 17:11 ` Anton Lundin
2026-06-05 18:42 ` Milan Broz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox