Re: [RFC PATCH v2.2 06/28] mm/damon/core: introduce damon_ops->apply_probes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing detailed kernel-doc description and execution flow integration for the new `apply_probes` callback.
- [Low] Mismatch between the callback name in the commit message and the actual code.
--

commit 3622281217bcbb69d269a9ab7a22730a743ca395
Author: SeongJae Park <sj@kernel.org>

mm/damon/core: introduce damon_ops->apply_probes

This commit extends the damon_operations structure by adding a new
apply_probes callback. This callback will be used for monitoring data
attributes, applying damon_probe objects to regions, and updating counters.

> Extend damon_operations struct with a new callback, namely apply_probe.

This isn't a bug, but there is a slight mismatch in the callback name here.
The code implements it as apply_probes (plural), while the commit message
calls it apply_probe (singular).

> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index bf78ad849a9be..36a1162b6185a 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -621,6 +621,7 @@ enum damon_ops_id {
>   * @update:			Update operations-related data structures.
>   * @prepare_access_checks:	Prepare next access check of target regions.
>   * @check_accesses:		Check the accesses to target regions.
> + * @apply_probes:		Apply probes for each region.
>   * @get_scheme_score:		Get the score of a region for a scheme.
>   * @apply_scheme:		Apply a DAMON-based operation scheme.
>   * @target_valid:		Determine if the target is valid.

Looking at the rest of the kernel-doc for struct damon_operations, there are
usually detailed explanation paragraphs for each callback, as well as a
paragraph describing the overall execution order in the monitoring thread.

Should this patch also include a detailed description paragraph for
apply_probes and update the execution flow documentation to clarify exactly
when this new callback is invoked during the monitoring loop?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515004433.128933-1-sj@kernel.org?part=6