Re: [RFC PATCH v2.2 10/28] mm/damon/sysfs: implement probe dir

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced kobj_type structure 'damon_sysfs_probe_ktype' is missing the 'static' keyword.
--

commit 6edcbcf176b612eae059c59f709c455cff251235
Author: SeongJae Park <sj@kernel.org>

mm/damon/sysfs: implement probe dir

This commit implements a sysfs directory to let users install individual
data probes.

> diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> index 5f3b253f50ebf..c028e4b1281e6 100644
> --- a/mm/damon/sysfs.c
> +++ b/mm/damon/sysfs.c

[ ... ]

> +static struct attribute *damon_sysfs_probe_attrs[] = {
> +	NULL,
> +};
> +ATTRIBUTE_GROUPS(damon_sysfs_probe);
> +
> +const struct kobj_type damon_sysfs_probe_ktype = {

This isn't a bug, but should damon_sysfs_probe_ktype be marked as static?

It appears to only be used locally within this file, and omitting the
static keyword will needlessly expose the symbol globally and might
trigger warnings from static analysis tools.

> +	.release = damon_sysfs_probe_release,
> +	.sysfs_ops = &kobj_sysfs_ops,
> +	.default_groups = damon_sysfs_probe_groups,
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515004433.128933-1-sj@kernel.org?part=10