DAMON development mailing list
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Zenghui Yu <zenghui.yu@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
	Shardul Deshpande <iamsharduld@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org, damon@lists.linux.dev
Subject: Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt
Date: Sat, 13 Jun 2026 09:39:56 -0700	[thread overview]
Message-ID: <20260613163957.2441-1-sj@kernel.org> (raw)
In-Reply-To: <4072c971-0a54-4bbe-8cb1-c06e13b22f05@linux.dev>

On Sat, 13 Jun 2026 10:32:43 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:

> On 6/13/26 8:07 AM, SeongJae Park wrote:
> > On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:
> > 
> > > Several comments and one documentation file transpose the letters in
> > > "assigned" and "unsigned", spelling them with "sing" instead of "sign".
> > > Correct all of them.
> > >
> > > Of these, the misspelling of "assigned" is not yet flagged by
> > > checkpatch, so also add it to scripts/spelling.txt.
> > >
> > > The remaining matches of `grep -ri singed` are RISINGEDGE register and
> > > enum names, not typos.
> > >
> > > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > > Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
> > > ---
> > >  Documentation/mm/damon/design.rst          | 2 +-
> > >  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
> > >  drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
> > >  drivers/scsi/elx/efct/efct_hw.h            | 2 +-
> > >  drivers/scsi/isci/host.c                   | 2 +-
> > >  drivers/scsi/isci/port.c                   | 2 +-
> > >  drivers/scsi/isci/port_config.c            | 2 +-
> > >  kernel/bpf/helpers.c                       | 2 +-
> > >  scripts/spelling.txt                       | 1 +
> > >  9 files changed, 9 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > > index afc7d52bd..899ac9c69 100644
> > > --- a/Documentation/mm/damon/design.rst
> > > +++ b/Documentation/mm/damon/design.rst
> > > @@ -140,7 +140,7 @@ as Idle page tracking does.
> > >  Address Unit
> > >  ------------
> > >  
> > > -DAMON core layer uses ``unsinged long`` type for monitoring target address
> > > +DAMON core layer uses ``unsigned long`` type for monitoring target address
> > >  ranges.  In some cases, the address space for a given operations set could be
> > >  too large to be handled with the type.  ARM (32-bit) with large physical
> > >  address extension is an example.  For such cases, a per-operations set
> > 
> > For the above DAMON part,
> > 
> > Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> This one has already been fixed in mm-new. See
> https://lore.kernel.org/20260520012104.93602-3-sj@kernel.org .

Ah, you're right.  Thank you for catching this!  Please drop the DAMON part.
That said, now I reviewed all the rest parts of this patch, and all look good.
Please feel free to keep having my R-b: tag.


Thanks,
SJ

[...]

      reply	other threads:[~2026-06-13 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260612181633.734458-1-iamsharduld@gmail.com>
2026-06-13  0:07 ` [PATCH] treewide: fix transposed "sign" typos and update spelling.txt SeongJae Park
2026-06-13  2:32   ` Zenghui Yu
2026-06-13 16:39     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260613163957.2441-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=iamsharduld@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zenghui.yu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox