Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

[SeongJae Park]

On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:

> Several comments and one documentation file transpose the letters in
> "assigned" and "unsigned", spelling them with "sing" instead of "sign".
> Correct all of them.
> 
> Of these, the misspelling of "assigned" is not yet flagged by
> checkpatch, so also add it to scripts/spelling.txt.
> 
> The remaining matches of `grep -ri singed` are RISINGEDGE register and
> enum names, not typos.
> 
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
> ---
>  Documentation/mm/damon/design.rst          | 2 +-
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
>  drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
>  drivers/scsi/elx/efct/efct_hw.h            | 2 +-
>  drivers/scsi/isci/host.c                   | 2 +-
>  drivers/scsi/isci/port.c                   | 2 +-
>  drivers/scsi/isci/port_config.c            | 2 +-
>  kernel/bpf/helpers.c                       | 2 +-
>  scripts/spelling.txt                       | 1 +
>  9 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index afc7d52bd..899ac9c69 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -140,7 +140,7 @@ as Idle page tracking does.
>  Address Unit
>  ------------
>  
> -DAMON core layer uses ``unsinged long`` type for monitoring target address
> +DAMON core layer uses ``unsigned long`` type for monitoring target address
>  ranges.  In some cases, the address space for a given operations set could be
>  too large to be handled with the type.  ARM (32-bit) with large physical
>  address extension is an example.  For such cases, a per-operations set

For the above DAMON part,

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

[Zenghui Yu]

On 6/13/26 8:07 AM, SeongJae Park wrote:
> On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:
> 
> > Several comments and one documentation file transpose the letters in
> > "assigned" and "unsigned", spelling them with "sing" instead of "sign".
> > Correct all of them.
> >
> > Of these, the misspelling of "assigned" is not yet flagged by
> > checkpatch, so also add it to scripts/spelling.txt.
> >
> > The remaining matches of `grep -ri singed` are RISINGEDGE register and
> > enum names, not typos.
> >
> > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
> > ---
> >  Documentation/mm/damon/design.rst          | 2 +-
> >  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
> >  drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
> >  drivers/scsi/elx/efct/efct_hw.h            | 2 +-
> >  drivers/scsi/isci/host.c                   | 2 +-
> >  drivers/scsi/isci/port.c                   | 2 +-
> >  drivers/scsi/isci/port_config.c            | 2 +-
> >  kernel/bpf/helpers.c                       | 2 +-
> >  scripts/spelling.txt                       | 1 +
> >  9 files changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > index afc7d52bd..899ac9c69 100644
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> > @@ -140,7 +140,7 @@ as Idle page tracking does.
> >  Address Unit
> >  ------------
> >  
> > -DAMON core layer uses ``unsinged long`` type for monitoring target address
> > +DAMON core layer uses ``unsigned long`` type for monitoring target address
> >  ranges.  In some cases, the address space for a given operations set could be
> >  too large to be handled with the type.  ARM (32-bit) with large physical
> >  address extension is an example.  For such cases, a per-operations set
> 
> For the above DAMON part,
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

This one has already been fixed in mm-new. See
https://lore.kernel.org/20260520012104.93602-3-sj@kernel.org .

Thanks,
Zenghui

Re: [PATCH] treewide: fix transposed "sign" typos and update spelling.txt

[SeongJae Park]

On Sat, 13 Jun 2026 10:32:43 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:

> On 6/13/26 8:07 AM, SeongJae Park wrote:
> > On Fri, 12 Jun 2026 23:46:32 +0530 Shardul Deshpande <iamsharduld@gmail.com> wrote:
> > 
> > > Several comments and one documentation file transpose the letters in
> > > "assigned" and "unsigned", spelling them with "sing" instead of "sign".
> > > Correct all of them.
> > >
> > > Of these, the misspelling of "assigned" is not yet flagged by
> > > checkpatch, so also add it to scripts/spelling.txt.
> > >
> > > The remaining matches of `grep -ri singed` are RISINGEDGE register and
> > > enum names, not typos.
> > >
> > > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > > Signed-off-by: Shardul Deshpande <iamsharduld@gmail.com>
> > > ---
> > >  Documentation/mm/damon/design.rst          | 2 +-
> > >  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 +-
> > >  drivers/gpu/drm/drm_color_mgmt.c           | 2 +-
> > >  drivers/scsi/elx/efct/efct_hw.h            | 2 +-
> > >  drivers/scsi/isci/host.c                   | 2 +-
> > >  drivers/scsi/isci/port.c                   | 2 +-
> > >  drivers/scsi/isci/port_config.c            | 2 +-
> > >  kernel/bpf/helpers.c                       | 2 +-
> > >  scripts/spelling.txt                       | 1 +
> > >  9 files changed, 9 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > > index afc7d52bd..899ac9c69 100644
> > > --- a/Documentation/mm/damon/design.rst
> > > +++ b/Documentation/mm/damon/design.rst
> > > @@ -140,7 +140,7 @@ as Idle page tracking does.
> > >  Address Unit
> > >  ------------
> > >  
> > > -DAMON core layer uses ``unsinged long`` type for monitoring target address
> > > +DAMON core layer uses ``unsigned long`` type for monitoring target address
> > >  ranges.  In some cases, the address space for a given operations set could be
> > >  too large to be handled with the type.  ARM (32-bit) with large physical
> > >  address extension is an example.  For such cases, a per-operations set
> > 
> > For the above DAMON part,
> > 
> > Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> This one has already been fixed in mm-new. See
> https://lore.kernel.org/20260520012104.93602-3-sj@kernel.org .

Ah, you're right.  Thank you for catching this!  Please drop the DAMON part.
That said, now I reviewed all the rest parts of this patch, and all look good.
Please feel free to keep having my R-b: tag.


Thanks,
SJ

[...]