[PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list()

[PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list()

[Enze Li]

In damon_migrate_folio_list(), we're redeclaring folio inside the first
while loop, but it just shadows the outer one.  Since the second loop
uses the outer folio anyway, the inner declaration is pointless.

Remove it to consistently reuse the same variable throughout the
function and improve readability.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
 mm/damon/ops-common.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
index 89c694f6e4fa..e59f5268d503 100644
--- a/mm/damon/ops-common.c
+++ b/mm/damon/ops-common.c
@@ -339,8 +339,6 @@ static unsigned int damon_migrate_folio_list(struct list_head *folio_list,
 	LIST_HEAD(migrate_folios);
 
 	while (!list_empty(folio_list)) {
-		struct folio *folio;
-
 		cond_resched();
 
 		folio = lru_to_folio(folio_list);

base-commit: 5093dba1014c1d7f7e247fd118f0fa8f22136046
-- 
2.43.0

Re: [PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list()

[SJ Park]

Hello Enze,

get_maintainer.pl suggests to Cc linux-kernel@vger.kernel.org too.  Adding it
to Cc list.

On Sat, 18 Jul 2026 08:21:25 +0800 Enze Li <lienze@kylinos.cn> wrote:

> In damon_migrate_folio_list(), we're redeclaring folio inside the first
> while loop, but it just shadows the outer one.  Since the second loop
> uses the outer folio anyway, the inner declaration is pointless.
> 
> Remove it to consistently reuse the same variable throughout the
> function and improve readability.

Nice catch!

> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>

This patch is applied to damon/next [1] tree.  If this patch is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]