DAMON development mailing list
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hari Mishal <harimishal1@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	SJ Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 4/7] selftests/damon/sysfs.py: clean up sh processes used for obsolete_target test
Date: Mon, 31 Aug 2026 07:26:06 -0700	[thread overview]
Message-ID: <20260831142611.77572-5-sj@kernel.org> (raw)
In-Reply-To: <20260831142611.77572-1-sj@kernel.org>

From: Hari Mishal <harimishal1@gmail.com>

The obsolete_target test spawns three sh processes and uses their pids
as DAMON monitoring targets.  These processes are never terminated or
waited on, so they are left running (or become zombies) as orphaned
children after the test program exits.

Terminate each process and communicate() with it after the targets are
no longer needed, so it exits and gets reaped instead of being leaked.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Hari Mishal <harimishal1@gmail.com>
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: SJ Park <sj@kernel.org>
---
Changes from v2
- v2: https://lore.kernel.org/20260722012349.9738-1-harimishal1@gmail.com
- Collect R-b: from SJ.
- Rebase to latest mm-new.
Changes from v1
- v1: https://lore.kernel.org/20260721190404.135937-1-harimishal1@gmail.com
- Terminate each sh process directly instead of giving it its own stdin
  pipe to close, dropping the stdin=PIPE changes and shrinking the diff.

 tools/testing/selftests/damon/sysfs.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py
index 3ffa054b63867..88a26422ff44c 100755
--- a/tools/testing/selftests/damon/sysfs.py
+++ b/tools/testing/selftests/damon/sysfs.py
@@ -385,6 +385,10 @@ def main():
     assert_ctxs_committed(kdamonds)
     kdamonds.stop()
 
+    for proc in (proc1, proc2, proc3):
+        proc.terminate()
+        proc.communicate()
+
     test_memcg_filter_memcg_path_staging()
 
 if __name__ == '__main__':
-- 
2.47.3

  parent reply	other threads:[~2026-08-31 14:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 14:26 [PATCH 0/7] mm/damon: misc cleanups SJ Park
2026-08-31 14:26 ` [PATCH 1/7] mm/damon/core: remove declaration of __damon_commit_ctx() SJ Park
2026-08-31 17:44   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 2/7] mm/damon/core: introduce damon_set_target_pid() SJ Park
2026-08-31 17:58   ` sashiko-bot
2026-08-31 23:31   ` Andrew Morton
2026-09-01  0:40     ` SJ Park
2026-08-31 14:26 ` [PATCH 3/7] mm/damon/ops-common: factor out damon_putback_folio_list() SJ Park
2026-08-31 18:00   ` sashiko-bot
2026-08-31 14:26 ` SJ Park [this message]
2026-08-31 18:06   ` [PATCH 4/7] selftests/damon/sysfs.py: clean up sh processes used for obsolete_target test sashiko-bot
2026-08-31 14:26 ` [PATCH 5/7] mm/damon/tests: use scoped_guard() for damon_test_ops_registration SJ Park
2026-08-31 18:12   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 6/7] selftests/damon: prevent remaining cross-object state pollution SJ Park
2026-08-31 18:17   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 7/7] samples/damon/mtier: add comment for struct region_range SJ Park
2026-08-31 18:18   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831142611.77572-5-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=harimishal1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox