DAMON development mailing list
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: SJ Park <sj@kernel.org>
Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Enze Li <lienze@kylinos.cn>
Subject: Re: [PATCH 2/7] mm/damon/core: introduce damon_set_target_pid()
Date: Mon, 31 Aug 2026 16:31:19 -0700	[thread overview]
Message-ID: <20260831163119.66bcfdd8a4ee66b3609be63a@linux-foundation.org> (raw)
In-Reply-To: <20260831142611.77572-3-sj@kernel.org>

On Mon, 31 Aug 2026 07:26:04 -0700 SJ Park <sj@kernel.org> wrote:

> The logic that finds the struct pid for a given pid number and assigns
> it to a damon_target is duplicated in multiple places.  Including
> damon_sysfs_add_target() of mm/damon/sysfs.c and the start functions
> of the two sample modules, samples/damon/wsse.c and
> samples/damon/prcl.c.  Add a function that does the work, and replace
> the duplicated code in the places with calls to the function.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> Reviewed-by: SJ Park <sj@kernel.org>
> Signed-off-by: SJ Park <sj@kernel.org>

I assumed that From:Enze was intended here.


  parent reply	other threads:[~2026-08-31 23:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 14:26 [PATCH 0/7] mm/damon: misc cleanups SJ Park
2026-08-31 14:26 ` [PATCH 1/7] mm/damon/core: remove declaration of __damon_commit_ctx() SJ Park
2026-08-31 17:44   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 2/7] mm/damon/core: introduce damon_set_target_pid() SJ Park
2026-08-31 17:58   ` sashiko-bot
2026-08-31 23:31   ` Andrew Morton [this message]
2026-09-01  0:40     ` SJ Park
2026-08-31 14:26 ` [PATCH 3/7] mm/damon/ops-common: factor out damon_putback_folio_list() SJ Park
2026-08-31 18:00   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 4/7] selftests/damon/sysfs.py: clean up sh processes used for obsolete_target test SJ Park
2026-08-31 18:06   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 5/7] mm/damon/tests: use scoped_guard() for damon_test_ops_registration SJ Park
2026-08-31 18:12   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 6/7] selftests/damon: prevent remaining cross-object state pollution SJ Park
2026-08-31 18:17   ` sashiko-bot
2026-08-31 14:26 ` [PATCH 7/7] samples/damon/mtier: add comment for struct region_range SJ Park
2026-08-31 18:18   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831163119.66bcfdd8a4ee66b3609be63a@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=lienze@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox