From: sashiko-bot@kernel.org
To: "Liew Rui Yan" <aethernet65535@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH] Docs/mm/damon/design: clarify when qt_exceeds increases
Date: Tue, 08 Sep 2026 17:55:47 +0000 [thread overview]
Message-ID: <20260908175548.2D95F1F00ACA@smtp.kernel.org> (raw)
In-Reply-To: <20260908175105.42558-2-aethernet65535@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Grammar and punctuation errors in the newly added documentation paragraph.
--
commit 25ab17e2d03e88ea28912107d200a293e1a57614
Author: Liew Rui Yan <aethernet65535@gmail.com>
Docs/mm/damon/design: clarify when qt_exceeds increases
This commit updates the DAMON design documentation to clarify how
qt_exceeds behaves when quotas are unset versus when they have a zero
effective size quota due to the temporal auto-tuning algorithm.
> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index d036340dae8af..e083b74d618b5 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -863,6 +863,16 @@ scheme's execution.
> completely tried to be applied.
> - ``max_nr_snapshots``: Upper limit of ``nr_snapshots``.
>
> +``qt_exceeds`` is increased for schemes with set quotas when the quota is found
> +full at a quota reset interval boundary. While the quotas are unset,
> +``qt_exceeds`` never increased. However, a zero effective size quota does not
> +always mean the quotas are unset, if the ``temporal`` :ref:`auto-tuning
[Severity: Low]
This isn't a bug, but would it be clearer to use the present tense
("never increases" or "is never increased") instead of "never increased"
to match the surrounding text?
Additionally, would it be better to separate the comma splice before
"if the ``temporal``" into two sentences?
> +algorithm <damon_design_damos_quotas_auto_tuning>` is used, the effective size
> +quota is set to zero once the goal is [over-]achieved. Since a set quota of
> +zero effective size is always considered full, ``qt_exceeds`` keeps being
> +increased once per quota reset interval in that case, until the goal is
> +under-achieved again.
> +
> "A scheme is tried to be applied to a region" means DAMOS core logic determined
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908175105.42558-2-aethernet65535@gmail.com?part=1
next prev parent reply other threads:[~2026-09-08 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 17:50 [RFC PATCH] Docs/mm/damon/design: clarify when qt_exceeds increases Liew Rui Yan
2026-09-08 17:55 ` sashiko-bot [this message]
2026-09-08 19:08 ` Liew Rui Yan
2026-09-09 0:38 ` SJ Park
2026-09-09 10:07 ` Liew Rui Yan
2026-09-10 0:17 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908175548.2D95F1F00ACA@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aethernet65535@gmail.com \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox