Re: [RFC PATCH] Docs/mm/damon/design: clarify when qt_exceeds increases

[Liew Rui Yan <aethernet65535@gmail.com>]

On Tue, 08 Sep 2026 17:55:47 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Grammar and punctuation errors in the newly added documentation paragraph.
> --
> 
> commit 25ab17e2d03e88ea28912107d200a293e1a57614
> Author: Liew Rui Yan <aethernet65535@gmail.com>
> 
> Docs/mm/damon/design: clarify when qt_exceeds increases
> 
> This commit updates the DAMON design documentation to clarify how
> qt_exceeds behaves when quotas are unset versus when they have a zero
> effective size quota due to the temporal auto-tuning algorithm.
> 
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > index d036340dae8af..e083b74d618b5 100644
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> > @@ -863,6 +863,16 @@ scheme's execution.
> >    completely tried to be applied.
> >  - ``max_nr_snapshots``: Upper limit of ``nr_snapshots``.
> >  
> > +``qt_exceeds`` is increased for schemes with set quotas when the quota is found
> > +full at a quota reset interval boundary.  While the quotas are unset,
> > +``qt_exceeds`` never increased.  However, a zero effective size quota does not
> > +always mean the quotas are unset, if the ``temporal`` :ref:`auto-tuning
> 
> [Severity: Low]
> This isn't a bug, but would it be clearer to use the present tense 
> ("never increases" or "is never increased") instead of "never increased" 
> to match the surrounding text?

Thank you for pointing this out!

Yes, "never increases" may be clearer.

> 
> Additionally, would it be better to separate the comma splice before 
> "if the ``temporal``" into two sentences?

If this is okay, I will change to:

    [...] quotas are unset.  Specifically, when the ``temporal`` [...]

> 
> > +algorithm <damon_design_damos_quotas_auto_tuning>` is used, the effective size
> > +quota is set to zero once the goal is [over-]achieved.  Since a set quota of
> > +zero effective size is always considered full, ``qt_exceeds`` keeps being
> > +increased once per quota reset interval in that case, until the goal is
> > +under-achieved again.
> > +
> >  "A scheme is tried to be applied to a region" means DAMOS core logic determined
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260908175105.42558-2-aethernet65535@gmail.com?part=1
> 

Best regards,
Rui Yan