Re: [PATCH 3/7] mm/damon/core: support probe_hits_wsum damos core filter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing KUnit test coverage for the new DAMOS_FILTER_TYPE_PROBE_HITS_WSUM filter.
--

commit c30ab09af6b4b9ef8cab31ff2d43ce4d72f9e904
Author: SJ Park <sj@kernel.org>

mm/damon/core: support probe_hits_wsum damos core filter

This commit implements the probe_hits_wsum DAMOS core filter support. It updates
the core layer to treat it as a core filter, copy its range parameters, and
match regions based on their weighted sum.

> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index e9630f41e51fe..d9d56f4be1a97 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c

[ ... ]

> @@ -1332,6 +1333,10 @@ static void damos_commit_filter_arg(
>  	case DAMOS_FILTER_TYPE_HUGEPAGE_SIZE:
>  		dst->sz_range = src->sz_range;
>  		break;
> +	case DAMOS_FILTER_TYPE_PROBE_HITS_WSUM:
> +		dst->range_min = src->range_min;
> +		dst->range_max = src->range_max;
> +		break;
>  	default:
>  		break;
>  	}

[Severity: Low]
Should this patch also update the KUnit tests to cover the new filter type?

The new DAMOS_FILTER_TYPE_PROBE_HITS_WSUM filter is not validated by the 
DAMON core KUnit tests, leaving this argument copying logic untested.

For example, it appears missing from the validation switch in 
damos_test_commit_filter_for():

mm/damon/tests/core-kunit.h:damos_test_commit_filter_for() {
	switch (src->type) {
	case DAMOS_FILTER_TYPE_MEMCG:
		KUNIT_EXPECT_EQ(test, dst->memcg_id, src->memcg_id);
		break;
	...
}

And the orchestrator function damos_test_commit_filter() does not seem to 
invoke a test case for the new probe_hits_wsum filter.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910141849.170896-1-sj@kernel.org?part=3