[PATCH] mm/damon: fix typos in comments

[PATCH] mm/damon: fix typos in comments

[Zhijian Han]

Fix spelling errors found by codespell in mm/damon/core.c:

- "widnow" -> "window"
- "makrs" -> "marks"

No functional changes.

Signed-off-by: Zhijian Han <hanzhijian1991@gmail.com>
---
 mm/damon/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 644daf5a1..c01b7e2a1 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2328,7 +2328,7 @@ static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
  * This function checks if a given region should be skipped or not for the
  * reason.  If only the starting part of the region has previously charged,
  * this function splits the region into two so that the second one covers the
- * area that not charged in the previous charge widnow, and return true.  The
+ * area that not charged in the previous charge window, and return true.  The
  * caller can see the second one on the next iteration of the region walk.
  * Note that this means the caller should use damon_for_each_region() instead
  * of damon_for_each_region_safe().  If damon_for_each_region_safe() is used,
@@ -2486,7 +2486,7 @@ static void damos_walk_call_walk(struct damon_ctx *ctx, struct damon_target *t,
  * This function is called when kdamond finished applying the action of a DAMOS
  * scheme to all regions that eligible for the given &damos->apply_interval_us.
  * If every scheme of @ctx including @s now finished walking for at least one
- * &damos->apply_interval_us, this function makrs the handling of the given
+ * &damos->apply_interval_us, this function marks the handling of the given
  * DAMOS walk request is done, so that damos_walk() can wake up and return.
  */
 static void damos_walk_complete(struct damon_ctx *ctx, struct damos *s)
-- 
2.43.0

Re: [PATCH] mm/damon: fix typos in comments

[sashiko-bot]

> Fix spelling errors found by codespell in mm/damon/core.c:
> 
> - "widnow" -> "window"
> - "makrs" -> "marks"
> 
> No functional changes.
> 
> Signed-off-by: Zhijian Han <hanzhijian1991@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922033618.2862687-1-hanzhijian1991@gmail.com?part=1

Re: [PATCH] mm/damon: fix typos in comments

[SJ Park]

Hi Zhijian,

On Tue, 22 Sep 2026 11:36:18 +0800 Zhijian Han <hanzhijian1991@gmail.com> wrote:

> Fix spelling errors found by codespell in mm/damon/core.c:
> 
> - "widnow" -> "window"
> - "makrs" -> "marks"
> 
> No functional changes.

Thank you for sharing this patch.  However, same fix is already posted by
Adrian already [1] and accepted.  So unfortunately we cannot accept this patch.
Please set the baseline of your work with recommended ones [2] from the next
time.

I also found that you posted another bigger typos fix patch [3] that contains
this patch's change.  That's confusing.  Please post only the bigger one or a
series of smaller ones from the next time.

[1] https://lore.kernel.org/20260921151547.78472-4-sj@kernel.org
[2] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
[2] https://lore.kernel.org/20260922031843.2857104-1-hanzhijian1991@gmail.com


Thanks,
SJ

[...]

[PATCH] mm/damon: fix typos in comments

[klourencodev]

From: kevin <kevin@desktop-mu90jgd.home>

Correct minor spelling mistakes in several files under mm/damon.
No functional changes.

Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
---
 mm/damon/core.c             | 6 +++---
 mm/damon/lru_sort.c         | 2 +-
 mm/damon/reclaim.c          | 2 +-
 mm/damon/stat.c             | 2 +-
 mm/damon/tests/core-kunit.h | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 68dd2f7acba2..da4820110e48 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -284,7 +284,7 @@ struct damos_filter *damos_new_filter(enum damos_filter_type type,
 }
 
 /**
- * damos_filter_for_ops() - Return if the filter is ops-hndled one.
+ * damos_filter_for_ops() - Return if the filter is ops-handled one.
  * @type:	type of the filter.
  *
  * Return: true if the filter of @type needs to be handled by ops layer, false
@@ -1586,7 +1586,7 @@ static unsigned long damon_get_intervals_adaptation_bp(struct damon_ctx *c)
 	adaptation_bp = damon_feed_loop_next_input(100000000, score_bp) /
 		10000;
 	/*
-	 * adaptaion_bp ranges from 1 to 20,000.  Avoid too rapid reduction of
+	 * adaptation_bp ranges from 1 to 20,000.  Avoid too rapid reduction of
 	 * the intervals by rescaling [1,10,000] to [5000, 10,000].
 	 */
 	if (adaptation_bp <= 10000)
@@ -2756,7 +2756,7 @@ static int kdamond_fn(void *data)
 				 *
 				 * Reset ->next_aggregation_sis to avoid that.
 				 * It will anyway correctly updated after this
-				 * if caluse.
+				 * if clause.
 				 */
 				ctx->next_aggregation_sis =
 					next_aggregation_sis;
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 49b4bc294f4e..9388b091deb7 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -34,7 +34,7 @@ static bool enabled __read_mostly;
  *
  * Input parameters that updated while DAMON_LRU_SORT is running are not
  * applied by default.  Once this parameter is set as ``Y``, DAMON_LRU_SORT
- * reads values of parametrs except ``enabled`` again.  Once the re-reading is
+ * reads values of parameters except ``enabled`` again.  Once the re-reading is
  * done, this parameter is set as ``N``.  If invalid parameters are found while
  * the re-reading, DAMON_LRU_SORT will be disabled.
  */
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index 36a582e09eae..8463a5a5032f 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -34,7 +34,7 @@ static bool enabled __read_mostly;
  *
  * Input parameters that updated while DAMON_RECLAIM is running are not applied
  * by default.  Once this parameter is set as ``Y``, DAMON_RECLAIM reads values
- * of parametrs except ``enabled`` again.  Once the re-reading is done, this
+ * of parameters except ``enabled`` again.  Once the re-reading is done, this
  * parameter is set as ``N``.  If invalid parameters are found while the
  * re-reading, DAMON_RECLAIM will be disabled.
  */
diff --git a/mm/damon/stat.c b/mm/damon/stat.c
index ef0a1195a584..5e18b164f6d8 100644
--- a/mm/damon/stat.c
+++ b/mm/damon/stat.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Shows data access monitoring resutls in simple metrics.
+ * Shows data access monitoring results in simple metrics.
  */
 
 #define pr_fmt(fmt) "damon-stat: " fmt
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 8cb369b63e08..f59ae7ee19a0 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1159,7 +1159,7 @@ static void damon_test_set_filters_default_reject(struct kunit *test)
 	damos_set_filters_default_reject(&scheme);
 	/*
 	 * A core-handled allow-filter is installed.
-	 * Rejct by default on core layer filtering stage due to the last
+	 * Reject by default on core layer filtering stage due to the last
 	 * core-layer-filter's behavior.
 	 * Allow by default on ops layer filtering stage due to the absence of
 	 * ops layer filters.
-- 
2.47.3

Re: [PATCH] mm/damon: fix typos in comments

[SeongJae Park]

On Wed, 17 Dec 2025 19:12:16 +0100 klourencodev@gmail.com wrote:

> From: kevin <kevin@desktop-mu90jgd.home>

I think this should match with 'Signed-off-by:' tag below?

> 
> Correct minor spelling mistakes in several files under mm/damon.
> No functional changes.

Thank you for catching this!

> 
> Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>

Other than the inconsistency between the author and the Signed-off-by,

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH] mm/damon: fix typos in comments

[SeongJae Park]

Hi Andrew,

On Wed, 17 Dec 2025 14:26:09 -0800 SeongJae Park <sj@kernel.org> wrote:

> On Wed, 17 Dec 2025 19:12:16 +0100 klourencodev@gmail.com wrote:
> 
> > From: kevin <kevin@desktop-mu90jgd.home>
> 
> I think this should match with 'Signed-off-by:' tag below?
> 
> > 
> > Correct minor spelling mistakes in several files under mm/damon.
> > No functional changes.
> 
> Thank you for catching this!
> 
> > 
> > Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
> 
> Other than the inconsistency between the author and the Signed-off-by,

I saw you addeed this patch to mm tree after fixing the above commented
inconsistency, as commit e8dd7a6b54a8 ("mm/damon: fix typos in comments").
Thank you!

> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

But I just found you didn't add the above Reviewed-by: tag from mine, to the
patch.  Sorry for catching this late, but could you please add it to the patch?


Thanks,
SJ

[...]

Re: [PATCH] mm/damon: fix typos in comments

[Andrew Morton]

On Wed,  7 Jan 2026 21:12:49 -0800 SeongJae Park <sj@kernel.org> wrote:

> > 
> > Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> But I just found you didn't add the above Reviewed-by: tag from mine, to the
> patch.  Sorry for catching this late, but could you please add it to the patch?

yep, thanks.