Re: [RFC PATCH v4 7/7] Docs/ABI/damon: update for quota goal metric complement sysfs file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mm/damon: build failure due to typo 'complementfalse' in tests
--

commit c13d1579fc49797d69a40d8e22286757e16cdd20
Author: SJ Park <sj@kernel.org>

mm/damon/core: add complement argument to damos_new_quota_goal()

This commit extends the damos_new_quota_goal() constructor to receive and
set a complement flag argument. It updates all API callers to use the new
signature to prevent manual assignment mistakes.

[ ... ]

> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index df84d9cc7d204..20bba7421a406 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
> @@ -930,6 +930,7 @@ static void damos_test_commit_quota_goals_for(struct kunit *test,
>  		 * Make it kfree()-able.
>  		 */
>  		goal = damos_new_quota_goal(dst_goals[i].metric,
> +				dst_goals[i].complementfalse,
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Does this code cause a build failure when CONFIG_DAMON_KUNIT_TEST=y is
enabled?

The struct damos_quota_goal does not have a member named complementfalse,
so accessing dst_goals[i].complementfalse in
damos_test_commit_quota_goals_for() fails to compile. Should this be
dst_goals[i].complement instead?

>  				dst_goals[i].target_value);
>  		if (!goal)
>  			goto out;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927120533.50484-1-sj@kernel.org?part=7