Re: [RFC PATCH v4 2/7] mm/damon/core: add complement argument to damos_new_quota_goal()

[SJ Park <sj@kernel.org>]

On Sun, 27 Sep 2026 12:12:29 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] damon: build failure in KUnit tests due to 'complementfalse' typo
> --
> 
> commit c13d1579fc49797d69a40d8e22286757e16cdd20
> Author: SJ Park <sj@kernel.org>
> 
> mm/damon/core: add complement argument to damos_new_quota_goal()
> 
> Extend the quota goal constructor, damos_new_quota_goal(), to receive and
> set the complement flag value. This commit also updates all callers to use
> the new signature.
> 
> > diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> > index df84d9cc7d204..20bba7421a406 100644
> > --- a/mm/damon/tests/core-kunit.h
> > +++ b/mm/damon/tests/core-kunit.h
> > @@ -930,6 +930,7 @@ static void damos_test_commit_quota_goals_for(struct kunit *test,
> >  		 * Make it kfree()-able.
> >  		 */
> >  		goal = damos_new_quota_goal(dst_goals[i].metric,
> > +				dst_goals[i].complementfalse,
> 
> [Severity: Low]
> Does this code cause a build failure when compiling the KUnit tests?
> 
> In damos_test_commit_quota_goals_for() within mm/damon/tests/core-kunit.h,
> it looks like there is a typo (complementfalse) which will break the
> build when CONFIG_DAMON_KUNIT_TEST=y is set.

Good catch.  I will fix in the next revision.

> 
> >  				dst_goals[i].target_value);
> >  		if (!goal)
> >  			goto out;
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260927120533.50484-1-sj@kernel.org?part=2


Thanks,
SJ