From: sashiko-bot@kernel.org
To: "Suhaas Joshi" <suhaas@s-joshi.in>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v2 1/2] mm/damon/core: Use only installed probe in damon_merge_two_regions()
Date: Thu, 08 Oct 2026 15:31:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-164345@kernel.org> (raw)
In-Reply-To: <20261008151944.113714-2-suhaas@s-joshi.in>
> While merging 2 regions, we iterate over the entire probe_hits[] array,
> whose size is determined by the DAMON_MAX_PROBES macro. However, it is
> possible that we have fewer probes installed than DAMON_MAX_PROBES. In such
> cases, we end up making redundant iterations. Therefore, to remedy this,
> iterate over the list of installed probes instead of iterating over the
> entire array. For doing this, start accepting a struct damon_ctx in
> damon_merge_two_regions(), and update calling functions to pass this
> argument.
>
> Update the damon_test_merge_two() test to use this new signature for
> damon_merge_two_regions() as well.
>
> Signed-off-by: Suhaas Joshi <suhaas@s-joshi.in>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008151944.113714-2-suhaas@s-joshi.in?part=1
next prev parent reply other threads:[~2026-10-08 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261008151944.113714-1-suhaas@s-joshi.in>
2026-10-08 15:19 ` [PATCH v2 1/2] mm/damon/core: Use only installed probe in damon_merge_two_regions() Suhaas Joshi
2026-10-08 15:31 ` sashiko-bot [this message]
2026-10-08 15:33 ` Suhaas Joshi
2026-10-09 7:46 ` SJ Park
2026-10-09 7:43 ` SJ Park
2026-10-08 15:19 ` [PATCH v2 2/2] mm/damon/core: Copy only installed probe in damon_split_region_at() Suhaas Joshi
2026-10-08 15:32 ` sashiko-bot
2026-10-09 2:40 ` kernel test robot
2026-10-09 8:21 ` SJ Park
2026-10-09 15:43 ` Suhaas Joshi
2026-10-09 4:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-164345@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=suhaas@s-joshi.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox