From: maximilian attems <max@stro.at>
To: dash@vger.kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
klibc@zytor.com
Subject: [patch v2] dash fix for job control off warning
Date: Wed, 7 Apr 2010 00:19:25 +0200 [thread overview]
Message-ID: <20100406221925.GE7863@stro.at> (raw)
fix subject and added warning to patch mail,
thanks for review.
----- Forwarded message from "H. Peter Anvin" <hpa@zytor.com> -----
Date: Mon, 29 Mar 2010 15:07:01 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: maximilian attems <max@stro.at>
Cc: Colin Watson <cjwatson@ubuntu.com>, klibc@zytor.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Subject: Re: [klibc] dash fix for job control off warning
There seems to be a problem with the new version of dash
with job control off. I can't tell if it is just a warning or is a
manifest bug.
usr/dash/trap.c: In function `exitshell':
usr/dash/trap.c:376: warning: suggest braces around empty body in an `if' statement
The solution is simple:
--- a/usr/dash/jobs.h
+++ b/usr/dash/jobs.h
@@ -105,5 +105,5 @@ int waitforjob(struct job *);
int stoppedjobs(void);
#if ! JOBS
-#define setjobctl(on) /* do nothing */
+#define setjobctl(on) ((void)(on)) /* do nothing */
#endif
... to keep the code syntactically valid even when setjobctl() is used
as the body of an if statement.
-hpa
----- End forwarded message -----
--
maks
next reply other threads:[~2010-04-07 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 22:19 maximilian attems [this message]
2010-04-15 5:50 ` [patch v2] dash fix for job control off warning Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406221925.GE7863@stro.at \
--to=max@stro.at \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=klibc@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox