[patch v2] dash fix for job control off warning

[patch v2] dash fix for job control off warning

[maximilian attems]

fix subject and added warning to patch mail,
thanks for review.

----- Forwarded message from "H. Peter Anvin" <hpa@zytor.com> -----

Date: Mon, 29 Mar 2010 15:07:01 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: maximilian attems <max@stro.at>
Cc: Colin Watson <cjwatson@ubuntu.com>, klibc@zytor.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Subject: Re: [klibc] dash fix for job control off warning

There seems to be a problem with the new version of dash
with job control off.  I can't tell if it is just a warning or is a
manifest bug.

usr/dash/trap.c: In function `exitshell':
usr/dash/trap.c:376: warning: suggest braces around empty body in an `if' statement

The solution is simple:

--- a/usr/dash/jobs.h
+++ b/usr/dash/jobs.h
@@ -105,5 +105,5 @@ int waitforjob(struct job *);
 int stoppedjobs(void);

 #if ! JOBS
-#define setjobctl(on)  /* do nothing */
+#define setjobctl(on) ((void)(on))     /* do nothing */
 #endif

... to keep the code syntactically valid even when setjobctl() is used
as the body of an if statement.

	-hpa

----- End forwarded message -----
-- 
maks

Re: [patch v2] dash fix for job control off warning

[Herbert Xu]

On Wed, Apr 07, 2010 at 12:19:25AM +0200, maximilian attems wrote:
> fix subject and added warning to patch mail,
> thanks for review.
> 
> ----- Forwarded message from "H. Peter Anvin" <hpa@zytor.com> -----
> 
> Date: Mon, 29 Mar 2010 15:07:01 -0700
> From: "H. Peter Anvin" <hpa@zytor.com>
> To: maximilian attems <max@stro.at>
> Cc: Colin Watson <cjwatson@ubuntu.com>, klibc@zytor.com,
> 	Herbert Xu <herbert@gondor.apana.org.au>,
> 	Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Subject: Re: [klibc] dash fix for job control off warning
> 
> There seems to be a problem with the new version of dash
> with job control off.  I can't tell if it is just a warning or is a
> manifest bug.
> 
> usr/dash/trap.c: In function `exitshell':
> usr/dash/trap.c:376: warning: suggest braces around empty body in an `if' statement

Patch applied.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt