dash klibc DEBUG compile question

dash klibc DEBUG compile question

[maximilian attems]

now with the proper flags passed and the jobs.c fix dash
allmost compiles in DEBUG mode, the last two failures happen
in show.c, which assumes some buffering functions that klibc
doesn't provide:
usr/dash/show.o: In function `opentrace':
show.c:(.text+0x36): undefined reference to `freopen'
show.c:(.text+0x86): undefined reference to `setlinebuf'

afais this code dates from the initial git import.
any preferences on how to fix those Herbert?


-- 
maks

Re: dash klibc DEBUG compile question

[Herbert Xu]

On Thu, Sep 09, 2010 at 10:16:11AM +0200, maximilian attems wrote:
> now with the proper flags passed and the jobs.c fix dash
> allmost compiles in DEBUG mode, the last two failures happen
> in show.c, which assumes some buffering functions that klibc
> doesn't provide:
> usr/dash/show.o: In function `opentrace':
> show.c:(.text+0x36): undefined reference to `freopen'
> show.c:(.text+0x86): undefined reference to `setlinebuf'
> 
> afais this code dates from the initial git import.
> any preferences on how to fix those Herbert?

setlinebuf is easy I guess if klibc doesn't do buffering.  You
can just skip it.

freopen is trickier.  However, it's only needed if you enable
history.  So I guess you could put it inside ifndef SMALL and
use fclose/fopen when not using history support.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt