From: "H. Peter Anvin" <hpa@zytor.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Eric Blake <ebb9@byu.net>, dash@vger.kernel.org
Subject: Re: avoid compiler warning
Date: Tue, 11 Aug 2009 15:06:24 -0700 [thread overview]
Message-ID: <4A81EB60.1020004@zytor.com> (raw)
In-Reply-To: <20090811215615.GA31592@gondor.apana.org.au>
On 08/11/2009 02:56 PM, Herbert Xu wrote:
> On Tue, Aug 11, 2009 at 09:33:43AM -0700, H. Peter Anvin wrote:
>> Herbert... the *type* is int, but the *value* has to be in the range
>> [-1,UCHAR_MAX] or the behavior is undefined in both the C and POSIX
>> standards.
>
> Good point. I'll apply the patch. I'd be very surprised though
> if this was the only instance in which we pass a char along.
>
Personally I have a habit of wrapping most ctype things in macros or
inlines which cast the argument to (unsigned char), then it's up to me
to make sure EOF doesn't slink in.
-hpa
next prev parent reply other threads:[~2009-08-11 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 12:55 avoid compiler warning Eric Blake
2009-08-11 4:03 ` Herbert Xu
2009-08-11 16:33 ` H. Peter Anvin
2009-08-11 21:56 ` Herbert Xu
2009-08-11 22:06 ` H. Peter Anvin [this message]
2009-08-12 3:19 ` Eric Blake
2009-08-31 11:30 ` Eric Blake
2009-08-31 11:31 ` Herbert Xu
2009-08-12 3:32 ` Eric Blake
2009-08-12 3:30 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A81EB60.1020004@zytor.com \
--to=hpa@zytor.com \
--cc=dash@vger.kernel.org \
--cc=ebb9@byu.net \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox