From: Eric Blake <ebb9@byu.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "H. Peter Anvin" <hpa@zytor.com>, dash@vger.kernel.org
Subject: Re: avoid compiler warning
Date: Tue, 11 Aug 2009 21:19:40 -0600 [thread overview]
Message-ID: <4A8234CC.8020007@byu.net> (raw)
In-Reply-To: <20090811215615.GA31592@gondor.apana.org.au>
According to Herbert Xu on 8/11/2009 3:56 PM:
> On Tue, Aug 11, 2009 at 09:33:43AM -0700, H. Peter Anvin wrote:
>> Herbert... the *type* is int, but the *value* has to be in the range
>> [-1,UCHAR_MAX] or the behavior is undefined in both the C and POSIX
>> standards.
>
> Good point. I'll apply the patch. I'd be very surprised though
> if this was the only instance in which we pass a char along.
I would be surprised, too, but this was the only instance that triggered a
-Wall warning from gcc for my libc (more details in another mail, as
requested), so all other use of ctype is either through unsigned char or
int, rather than straight char.
--
Don't work too hard, make some time for fun as well!
Eric Blake ebb9@byu.net
next prev parent reply other threads:[~2009-08-12 3:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 12:55 avoid compiler warning Eric Blake
2009-08-11 4:03 ` Herbert Xu
2009-08-11 16:33 ` H. Peter Anvin
2009-08-11 21:56 ` Herbert Xu
2009-08-11 22:06 ` H. Peter Anvin
2009-08-12 3:19 ` Eric Blake [this message]
2009-08-31 11:30 ` Eric Blake
2009-08-31 11:31 ` Herbert Xu
2009-08-12 3:32 ` Eric Blake
2009-08-12 3:30 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8234CC.8020007@byu.net \
--to=ebb9@byu.net \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox