From: Eric Blake <ebb9@byu.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dash@vger.kernel.org
Subject: Re: test -x should use faccessat, not stat
Date: Fri, 02 Apr 2010 08:57:59 -0600 [thread overview]
Message-ID: <4BB605F7.8030505@byu.net> (raw)
In-Reply-To: <20100402140353.GA31098@gondor.apana.org.au>
According to Herbert Xu on 4/2/2010 8:03 AM:
> After much deliberation (alright, I've simply been busy elsewhere :)
> I've committed this patch.
>
> commit 1d68712ba2e439f36874c4ed1e3d9ffec177a06c
> Note that faccessat doesn't handle ACLs when euid != uid, as
> this case is currently implemented by glibc instead of the kernel,
> using code similar to the existing dash test.
That faccessat bug is only true for current Linux kernels. Cygwin
faccessat does the correct thing, even when euid != uid.
Thanks for applying this.
--
Don't work too hard, make some time for fun as well!
Eric Blake ebb9@byu.net
prev parent reply other threads:[~2010-04-02 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 15:32 test -x should use faccessat, not stat Eric Blake
2010-02-14 6:11 ` Herbert Xu
2010-02-15 13:31 ` Eric Blake
2010-02-16 12:04 ` Herbert Xu
2010-04-02 14:03 ` Herbert Xu
2010-04-02 14:57 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB605F7.8030505@byu.net \
--to=ebb9@byu.net \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox