From: Eric Blake <ebb9@byu.net>
To: dash@vger.kernel.org
Subject: test -x should use faccessat, not stat
Date: Wed, 10 Feb 2010 15:32:30 +0000 (UTC) [thread overview]
Message-ID: <loom.20100210T162915-629@post.gmane.org> (raw)
This report was originally raised on the cygwin list:
http://cygwin.com/ml/cygwin/2010-02/msg00239.html
In short, in the presence of ACLs, dash's implementation of test -r, test -w,
and test -x gives incorrect answers, when the current user has permissions to
access a file that were granted by ACLs but not by the current stat()
permissions. dash should be using faccessat(,AT_EACCESS) (or
eaccess/euidaccess) if available, rather than stat(), to determine whether a
file is accessible.
--
Eric Blake
next reply other threads:[~2010-02-10 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 15:32 Eric Blake [this message]
2010-02-14 6:11 ` test -x should use faccessat, not stat Herbert Xu
2010-02-15 13:31 ` Eric Blake
2010-02-16 12:04 ` Herbert Xu
2010-04-02 14:03 ` Herbert Xu
2010-04-02 14:57 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20100210T162915-629@post.gmane.org \
--to=ebb9@byu.net \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox