* dash-0.5.8 bug report
@ 2014-11-21 13:55 David Binderman
2014-11-21 17:38 ` Harald van Dijk
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2014-11-21 13:55 UTC (permalink / raw)
To: dash@vger.kernel.org
Hello there,
eval.c:273:19: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
if (!exitstatus == isor)
Maybe
if (exitstatus != isor)
was intended.
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dash-0.5.8 bug report
2014-11-21 13:55 dash-0.5.8 bug report David Binderman
@ 2014-11-21 17:38 ` Harald van Dijk
0 siblings, 0 replies; 2+ messages in thread
From: Harald van Dijk @ 2014-11-21 17:38 UTC (permalink / raw)
To: David Binderman, dash@vger.kernel.org
On 21/11/2014 14:55, David Binderman wrote:
> Hello there,
>
> eval.c:273:19: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>
> if (!exitstatus == isor)
>
> Maybe
>
> if (exitstatus != isor)
>
> was intended.
This looks correct to me. isor represents the type of command
composition. It can be 0 (&&), 1 (||) or 2 (;). If isor == 0, the second
command should not be executed if exitstatus != 0. If isor == 1, the
second command should not be executed if exitstatus == 0. If isor == 2,
the second command should be executed.
Cheers,
Harald van Dijk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-21 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-21 13:55 dash-0.5.8 bug report David Binderman
2014-11-21 17:38 ` Harald van Dijk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox