* [PATCH 1/5]: Receiver does not set CCVal
@ 2007-06-14 9:05 Gerrit Renker
2007-06-24 21:25 ` Ian McDonald
0 siblings, 1 reply; 2+ messages in thread
From: Gerrit Renker @ 2007-06-14 9:05 UTC (permalink / raw)
To: dccp
[CCID 3]: Receiver does not set CCVal
This removes an unnecessary statement, since the receiver of a half-connection
does not set window counter values: as specified in RFCs 3448 and 4342,
the sender provides the RTT estimates to the receiver [RFC 3448, 3.2.1], which
in the particular case of CCID3 means that only the sender sets window counters
[RFC 4342, sections 5 and 8.1].
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
net/dccp/ccids/ccid3.c | 2 --
1 file changed, 2 deletions(-)
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -745,8 +745,6 @@ static int ccid3_hc_rx_insert_options(st
if (!(sk->sk_state = DCCP_OPEN || sk->sk_state = DCCP_PARTOPEN))
return 0;
- DCCP_SKB_CB(skb)->dccpd_ccval = hcrx->ccid3hcrx_ccval_last_counter;
-
if (dccp_packet_without_ack(skb))
return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/5]: Receiver does not set CCVal
2007-06-14 9:05 [PATCH 1/5]: Receiver does not set CCVal Gerrit Renker
@ 2007-06-24 21:25 ` Ian McDonald
0 siblings, 0 replies; 2+ messages in thread
From: Ian McDonald @ 2007-06-24 21:25 UTC (permalink / raw)
To: dccp
On 6/14/07, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> [CCID 3]: Receiver does not set CCVal
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
--
Web: http://wand.net.nz/~iam4/
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-24 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-14 9:05 [PATCH 1/5]: Receiver does not set CCVal Gerrit Renker
2007-06-24 21:25 ` Ian McDonald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox