DCCP protocol discussions
 help / color / mirror / Atom feed
* [PATCHES 0/8][DCCP] More core work
@ 2007-09-26 18:39 Arnaldo Carvalho de Melo
  2007-09-26 21:08 ` David Miller
  2007-09-26 21:34 ` Arnaldo Carvalho de Melo
  0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2007-09-26 18:39 UTC (permalink / raw)
  To: dccp

Hi David,

	Please consider pulling from:

	master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24


Best Regards,

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHES 0/8][DCCP] More core work
  2007-09-26 18:39 [PATCHES 0/8][DCCP] More core work Arnaldo Carvalho de Melo
@ 2007-09-26 21:08 ` David Miller
  2007-09-26 21:34 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-09-26 21:08 UTC (permalink / raw)
  To: dccp

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Wed, 26 Sep 2007 15:39:00 -0300

> Hi David,
> 
> 	Please consider pulling from:
> 
> 	master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24

Pulled, but I'd like to make a small request.

Please remove the CONFIG_IP_DCCP_CCID3_DEBUG ifdef protection
for the BUG_ON(hctx = NULL)

Either the assertion is valid, and therefore it should always
be enabled, or it isn't.

If people want to turn off BUG checks, they turn off CONFIG_BUG.

Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHES 0/8][DCCP] More core work
  2007-09-26 18:39 [PATCHES 0/8][DCCP] More core work Arnaldo Carvalho de Melo
  2007-09-26 21:08 ` David Miller
@ 2007-09-26 21:34 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2007-09-26 21:34 UTC (permalink / raw)
  To: dccp

Em Wed, Sep 26, 2007 at 02:08:37PM -0700, David Miller escreveu:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Date: Wed, 26 Sep 2007 15:39:00 -0300
> 
> > Hi David,
> > 
> > 	Please consider pulling from:
> > 
> > 	master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24
> 
> Pulled, but I'd like to make a small request.
> 
> Please remove the CONFIG_IP_DCCP_CCID3_DEBUG ifdef protection
> for the BUG_ON(hctx = NULL)
> 
> Either the assertion is valid, and therefore it should always
> be enabled, or it isn't.
> 
> If people want to turn off BUG checks, they turn off CONFIG_BUG.

OK! I plead guilty for this one, Gerrit's patch didn't had that, will
fix it in the next batch.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-09-26 21:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-26 18:39 [PATCHES 0/8][DCCP] More core work Arnaldo Carvalho de Melo
2007-09-26 21:08 ` David Miller
2007-09-26 21:34 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox