From: Eric Dumazet <eric.dumazet@gmail.com>
To: dccp@vger.kernel.org
Subject: Re: SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implement
Date: Wed, 01 Aug 2018 11:28:47 +0000 [thread overview]
Message-ID: <cf751136-c459-853a-0210-abf16f54ad17@gmail.com> (raw)
In-Reply-To: <e3b48104-3efb-1896-0d46-792419f49a75@virtuozzo.com>
On 08/01/2018 03:34 AM, Dmitry Vyukov wrote:
> On Wed, Aug 1, 2018 at 12:23 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On 08/01/2018 02:03 AM, Andrey Ryabinin wrote:
>>
>>> I can't think of any advantage in not having the constructor.
>>
>> I can't see any advantage adding another indirect call,
>> in RETPOLINE world.
>
> Can you please elaborate what's the problem here?
> If slab ctor call have RETPOLINE, then using ctors more does not
> introduce any security problems and they are not _that_ slow.
They _are_ slow, when we have dozens of them in a code path.
I object "having to add" yet another indirect call, if this can be avoided [*]
If some people want to use ctor, fine, but do not request this.
[*] This can be tricky, but worth the pain.
next prev parent reply other threads:[~2018-08-01 11:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 17:01 SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementatio Andrey Ryabinin
2018-07-31 17:09 ` SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implement Florian Westphal
2018-07-31 17:32 ` Eric Dumazet
2018-07-31 17:36 ` Christopher Lameter
2018-07-31 17:41 ` Eric Dumazet
2018-07-31 17:49 ` Linus Torvalds
2018-07-31 17:51 ` Dmitry Vyukov
2018-07-31 18:16 ` Eric Dumazet
2018-07-31 18:51 ` Linus Torvalds
2018-08-01 8:46 ` Dmitry Vyukov
2018-08-01 9:03 ` Andrey Ryabinin
2018-08-01 9:10 ` Dmitry Vyukov
2018-08-01 10:23 ` Eric Dumazet
2018-08-01 10:34 ` Dmitry Vyukov
2018-08-01 10:35 ` Florian Westphal
2018-08-01 10:41 ` Dmitry Vyukov
2018-08-01 11:28 ` Eric Dumazet [this message]
2018-08-01 11:35 ` Dmitry Vyukov
2018-08-01 11:40 ` Florian Westphal
2018-08-01 12:38 ` Dmitry Vyukov
2018-08-01 13:46 ` Florian Westphal
2018-08-01 13:52 ` Dmitry Vyukov
2018-08-01 15:15 ` Christopher Lameter
2018-08-01 15:37 ` Eric Dumazet
2018-08-01 15:53 ` Dmitry Vyukov
2018-08-01 16:22 ` Christopher Lameter
2018-08-01 16:25 ` Eric Dumazet
2018-08-01 16:47 ` Dmitry Vyukov
2018-08-01 17:18 ` Eric Dumazet
2018-08-06 20:20 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf751136-c459-853a-0210-abf16f54ad17@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox