* [PATCH v3 01/15] fdtget: Use libfdt iterators instead of open coded loops
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 02/15] libfdt: Don't assume the root node is available at offset 0 Herve Codina
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
fdtget uses directly fdt_{first,next}_property_offset() with a while(1)
loop to iterate over node properties.
It also uses the low level primitive fdt_next_tag() with custom tags,
level and depth handling to iterates over subnodes.
It is worth noting that FDT_NOP can be returned by fdt_next_tag() and
this tag is not taken into account in the fdtget open coded loop. This
will lead to an incorrect error if a FDT_NOP tag is encountered.
libfdt provides iterators to iterate over node properties and subnodes.
The subnode iterator provided by libfdt is robust against FDT_NOP tags
and will be robust in the future when new tags are introduced.
Replace fdtget open coded loops by iterators provided by libfdt and
designed to perform those operations.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
fdtget.c | 73 ++++++++++++++++++--------------------------------------
1 file changed, 23 insertions(+), 50 deletions(-)
diff --git a/fdtget.c b/fdtget.c
index dd709854..c6169691 100644
--- a/fdtget.c
+++ b/fdtget.c
@@ -138,21 +138,20 @@ static int show_data(struct display_info *disp, const char *data, int len)
static int list_properties(const void *blob, int node)
{
const char *name;
+ const void *p;
int prop;
- prop = fdt_first_property_offset(blob, node);
- do {
- /* Stop silently when there are no more properties */
- if (prop < 0)
- return prop == -FDT_ERR_NOTFOUND ? 0 : prop;
- fdt_getprop_by_offset(blob, prop, &name, NULL);
- if (name)
+ fdt_for_each_property_offset(prop, blob, node) {
+ p = fdt_getprop_by_offset(blob, prop, &name, NULL);
+ if (p && name)
puts(name);
- prop = fdt_next_property_offset(blob, prop);
- } while (1);
-}
+ }
-#define MAX_LEVEL 32 /* how deeply nested we will go */
+ if ((prop < 0) && (prop != -FDT_ERR_NOTFOUND))
+ return prop;
+
+ return 0;
+}
/**
* List all subnodes in a node, one per line
@@ -163,47 +162,21 @@ static int list_properties(const void *blob, int node)
*/
static int list_subnodes(const void *blob, int node)
{
- int nextoffset; /* next node offset from libfdt */
- uint32_t tag; /* current tag */
- int level = 0; /* keep track of nesting level */
const char *pathp;
- int depth = 1; /* the assumed depth of this node */
-
- while (level >= 0) {
- tag = fdt_next_tag(blob, node, &nextoffset);
- switch (tag) {
- case FDT_BEGIN_NODE:
- pathp = fdt_get_name(blob, node, NULL);
- if (level <= depth) {
- if (pathp == NULL)
- pathp = "/* NULL pointer error */";
- if (*pathp == '\0')
- pathp = "/"; /* root is nameless */
- if (level == 1)
- puts(pathp);
- }
- level++;
- if (level >= MAX_LEVEL) {
- printf("Nested too deep, aborting.\n");
- return 1;
- }
- break;
- case FDT_END_NODE:
- level--;
- if (level == 0)
- level = -1; /* exit the loop */
- break;
- case FDT_END:
- return 1;
- case FDT_PROP:
- break;
- default:
- if (level <= depth)
- printf("Unknown tag 0x%08X\n", tag);
- return 1;
- }
- node = nextoffset;
+ int subnode;
+
+ fdt_for_each_subnode(subnode, blob, node) {
+ pathp = fdt_get_name(blob, subnode, NULL);
+ if (pathp == NULL)
+ pathp = "/* NULL pointer error */";
+ if (*pathp == '\0')
+ pathp = "/"; /* root is nameless */
+ puts(pathp);
}
+
+ if (subnode < 0 && (subnode != -FDT_ERR_NOTFOUND))
+ return subnode;
+
return 0;
}
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 02/15] libfdt: Don't assume the root node is available at offset 0
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
2026-08-26 8:31 ` [PATCH v3 01/15] fdtget: Use libfdt iterators instead of open coded loops Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 03/15] tests: " Herve Codina
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
In several places, libfdt assumes that the root offset (i.e. the first
FDT_BEGIN_NODE tag) is present at the offset 0 of the structure block.
This assumption is not correct. A FDT_NOP can be present at the offset 0
and this is a legit case. Indeed, the device-tree specification [0]
defines the FDT_NOP tag as follow:
The FDT_NOP token will be ignored by any program parsing the device
tree. This token has no extra data; so it is followed immediately by
the next token, which can be any valid token. A property or node
definition in the tree can be overwritten with FDT_NOP tokens to
remove it from the tree without needing to move other sections of
the tree’s representation in the devicetree blob.
Nothing refers to any location for this tag and it has to be simply
ignored. Having this tag at offset 0 doesn't make an exception, the tag
has to be ignored.
Introduce fdt_root_offset() in order to get the offset of the root
node (first FDT_BEGIN_NODE tag) available in a fdt blob taking care of
FDT_NOP tags.
Use this function to get the root node offset instead of looking for
this node at offset 0.
[0] https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter5-flattened-format.rst?plain=1#L317
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
libfdt/fdt.c | 39 +++++++++++++++++++++++++++++--
libfdt/fdt_ro.c | 57 ++++++++++++++++++++++++++++++++++++++--------
libfdt/fdt_rw.c | 12 ++++++++++
libfdt/libfdt.h | 15 +++++++++++-
libfdt/version.lds | 1 +
5 files changed, 111 insertions(+), 13 deletions(-)
diff --git a/libfdt/fdt.c b/libfdt/fdt.c
index 56d4dcb2..eb803e8a 100644
--- a/libfdt/fdt.c
+++ b/libfdt/fdt.c
@@ -252,13 +252,48 @@ int fdt_check_prop_offset_(const void *fdt, int offset)
return offset;
}
-int fdt_next_node(const void *fdt, int offset, int *depth)
+int fdt_root_offset(const void *fdt)
{
int nextoffset = 0;
+ int offset;
+ uint32_t tag;
+
+ do {
+ offset = nextoffset;
+ tag = fdt_next_tag(fdt, offset, &nextoffset);
+ switch (tag) {
+ case FDT_END_NODE:
+ case FDT_PROP:
+ return -FDT_ERR_BADSTRUCTURE;
+
+ case FDT_BEGIN_NODE:
+ return offset;
+
+ default:
+ break;
+ }
+ } while (tag != FDT_END);
+
+ return (nextoffset < 0) ? nextoffset : -FDT_ERR_NOTFOUND;
+}
+
+int fdt_next_node(const void *fdt, int offset, int *depth)
+{
+ int nextoffset = offset;
uint32_t tag;
+ /*
+ * Get the root node if asked for next node from the root node
+ * (offset == 0) or if the given offset is not valid (negative).
+ */
+ if (offset <= 0) {
+ nextoffset = fdt_root_offset(fdt);
+ if (nextoffset < 0)
+ return nextoffset;
+ }
+
if (offset >= 0)
- if ((nextoffset = fdt_check_node_offset_(fdt, offset)) < 0)
+ if ((nextoffset = fdt_check_node_offset_(fdt, nextoffset)) < 0)
return nextoffset;
do {
diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
index 11f2e2ee..856c62f1 100644
--- a/libfdt/fdt_ro.c
+++ b/libfdt/fdt_ro.c
@@ -231,6 +231,12 @@ int fdt_subnode_offset_namelen(const void *fdt, int offset,
FDT_RO_PROBE(fdt);
+ if (!offset) {
+ offset = fdt_root_offset(fdt);
+ if (offset < 0)
+ return offset;
+ }
+
for (depth = 0;
(offset >= 0) && (depth >= 0);
offset = fdt_next_node(fdt, offset, &depth))
@@ -253,13 +259,17 @@ int fdt_path_offset_namelen(const void *fdt, const char *path, int namelen)
{
const char *end = path + namelen;
const char *p = path;
- int offset = 0;
+ int offset;
FDT_RO_PROBE(fdt);
if (!can_assume(VALID_INPUT) && namelen <= 0)
return -FDT_ERR_BADPATH;
+ offset = fdt_root_offset(fdt);
+ if (offset < 0)
+ return offset;
+
/* see if we have an alias */
if (*path != '/') {
const char *q = memchr(path, '/', end - p);
@@ -304,14 +314,24 @@ int fdt_path_offset(const void *fdt, const char *path)
const char *fdt_get_name(const void *fdt, int nodeoffset, int *len)
{
- const struct fdt_node_header *nh = fdt_offset_ptr_(fdt, nodeoffset);
+ const struct fdt_node_header *nh;
const char *nameptr;
int err;
+ if (!nodeoffset) {
+ nodeoffset = fdt_root_offset(fdt);
+ if (nodeoffset < 0) {
+ err = nodeoffset;
+ goto fail;
+ }
+ }
+
+
if (!can_assume(VALID_DTB) && (((err = fdt_ro_probe_(fdt)) < 0)
|| ((err = fdt_check_node_offset_(fdt, nodeoffset)) < 0)))
goto fail;
+ nh = fdt_offset_ptr_(fdt, nodeoffset);
nameptr = nh->name;
if (!can_assume(LATEST) && fdt_version(fdt) < 0x10) {
@@ -344,6 +364,12 @@ int fdt_first_property_offset(const void *fdt, int nodeoffset)
{
int offset;
+ if (!nodeoffset) {
+ nodeoffset = fdt_root_offset(fdt);
+ if (nodeoffset < 0)
+ return nodeoffset;
+ }
+
if ((offset = fdt_check_node_offset_(fdt, nodeoffset)) < 0)
return offset;
@@ -581,7 +607,7 @@ int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen)
if (buflen < 2)
return -FDT_ERR_NOSPACE;
- for (offset = 0, depth = 0;
+ for (offset = fdt_root_offset(fdt), depth = 0;
(offset >= 0) && (offset <= nodeoffset);
offset = fdt_next_node(fdt, offset, &depth)) {
while (pdepth > depth) {
@@ -619,7 +645,7 @@ int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen)
else if (offset == -FDT_ERR_BADOFFSET)
return -FDT_ERR_BADSTRUCTURE;
- return offset; /* error from fdt_next_node() */
+ return offset; /* error from fdt_next_node() or fdt_root_offset() */
}
int fdt_supernode_atdepth_offset(const void *fdt, int nodeoffset,
@@ -627,13 +653,21 @@ int fdt_supernode_atdepth_offset(const void *fdt, int nodeoffset,
{
int offset, depth;
int supernodeoffset = -FDT_ERR_INTERNAL;
+ int root_offset;
FDT_RO_PROBE(fdt);
if (supernodedepth < 0)
return -FDT_ERR_NOTFOUND;
- for (offset = 0, depth = 0;
+ root_offset = fdt_root_offset(fdt);
+ if (root_offset < 0)
+ return root_offset;
+
+ if (!nodeoffset)
+ nodeoffset = root_offset;
+
+ for (offset = root_offset, depth = 0;
(offset >= 0) && (offset <= nodeoffset);
offset = fdt_next_node(fdt, offset, &depth)) {
if (depth == supernodedepth)
@@ -663,12 +697,15 @@ int fdt_supernode_atdepth_offset(const void *fdt, int nodeoffset,
int fdt_node_depth(const void *fdt, int nodeoffset)
{
int nodedepth;
- int err;
+ int offset;
+
+ offset = fdt_supernode_atdepth_offset(fdt, nodeoffset, 0, &nodedepth);
+ if (offset < 0)
+ return offset;
+
+ if (!can_assume(LIBFDT_FLAWLESS) && offset != fdt_root_offset(fdt))
+ return -FDT_ERR_INTERNAL;
- err = fdt_supernode_atdepth_offset(fdt, nodeoffset, 0, &nodedepth);
- if (err)
- return (can_assume(LIBFDT_FLAWLESS) || err < 0) ? err :
- -FDT_ERR_INTERNAL;
return nodedepth;
}
diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c
index 850aafe4..ceef49b8 100644
--- a/libfdt/fdt_rw.c
+++ b/libfdt/fdt_rw.c
@@ -226,6 +226,12 @@ static int fdt_add_property_(void *fdt, int nodeoffset, const char *name,
int err;
int allocated;
+ if (!nodeoffset) {
+ nodeoffset = fdt_root_offset(fdt);
+ if (nodeoffset < 0)
+ return nodeoffset;
+ }
+
if ((nextoffset = fdt_check_node_offset_(fdt, nodeoffset)) < 0)
return nextoffset;
@@ -377,6 +383,12 @@ int fdt_add_subnode_namelen(void *fdt, int parentoffset,
FDT_RW_PROBE(fdt);
+ if (!parentoffset) {
+ parentoffset = fdt_root_offset(fdt);
+ if (parentoffset < 0)
+ return parentoffset;
+ }
+
offset = fdt_subnode_offset_namelen(fdt, parentoffset, name, namelen);
if (offset >= 0)
return -FDT_ERR_EXISTS;
diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
index c69a18ed..7a1915a5 100644
--- a/libfdt/libfdt.h
+++ b/libfdt/libfdt.h
@@ -503,6 +503,19 @@ int fdt_num_mem_rsv(const void *fdt);
*/
int fdt_get_mem_rsv(const void *fdt, int n, uint64_t *address, uint64_t *size);
+/**
+ * fdt_root_offset - Get the offset of the root node
+ * @fdt: pointer to the device tree blob
+ *
+ * The root node can be located after the offset 0. Indeed FDT_NOP tags can be
+ * present at offset 0. fdt_root_offset() takes care of those possible FDT_NOP
+ * tags.
+ *
+ * returns: offset of the root node or negative libfdt error value otherwise
+ */
+int fdt_root_offset(const void *fdt);
+
+
/**
* fdt_subnode_offset_namelen - find a subnode based on substring
* @fdt: pointer to the device tree blob
@@ -1025,7 +1038,7 @@ int fdt_get_path(const void *fdt, int nodeoffset, char *buf, int buflen);
* at a specific depth from the root (where the root itself has depth
* 0, its immediate subnodes depth 1 and so forth). So
* fdt_supernode_atdepth_offset(fdt, nodeoffset, 0, NULL);
- * will always return 0, the offset of the root node. If the node at
+ * will always return the offset of the root node. If the node at
* nodeoffset has depth D, then:
* fdt_supernode_atdepth_offset(fdt, nodeoffset, D, NULL);
* will return nodeoffset itself.
diff --git a/libfdt/version.lds b/libfdt/version.lds
index cbfef546..d0b71669 100644
--- a/libfdt/version.lds
+++ b/libfdt/version.lds
@@ -7,6 +7,7 @@ LIBFDT_1.2 {
fdt_string;
fdt_num_mem_rsv;
fdt_get_mem_rsv;
+ fdt_root_offset;
fdt_subnode_offset_namelen;
fdt_subnode_offset;
fdt_path_offset_namelen;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 03/15] tests: Don't assume the root node is available at offset 0
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
2026-08-26 8:31 ` [PATCH v3 01/15] fdtget: Use libfdt iterators instead of open coded loops Herve Codina
2026-08-26 8:31 ` [PATCH v3 02/15] libfdt: Don't assume the root node is available at offset 0 Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 04/15] tests/nopulate: Add a FDT_NOP before the root node Herve Codina
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
Several tests uses offset 0 as the offset of the root node. Either to
check the offset returned by tested functions or to directly manipulate
the root node retrieved using fdt_offset_ptr(fdt, 0, ...).
The root node is not always at offset 0. Indeed, a FDT_NOP tag can be
present at offset 0. fdt_root_offset() returns the offset of the root
node taking care of possible FDT_NOP tag.
Use fdt_root_offset() to get the offset of the root node and use this
value whenever the offset of the root node is expected.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
tests/node_offset_by_compatible.c | 4 +++-
tests/node_offset_by_prop_value.c | 11 +++++++----
tests/path_offset.c | 13 +++++++++----
tests/root_node.c | 6 +++++-
4 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/tests/node_offset_by_compatible.c b/tests/node_offset_by_compatible.c
index a9e67835..1278a562 100644
--- a/tests/node_offset_by_compatible.c
+++ b/tests/node_offset_by_compatible.c
@@ -39,12 +39,14 @@ static void check_search(void *fdt, const char *compat, ...)
int main(int argc, char *argv[])
{
void *fdt;
+ int root_offset;
int subnode1_offset, subnode2_offset;
int subsubnode1_offset, subsubnode2_offset;
test_init(argc, argv);
fdt = load_blob_arg(argc, argv);
+ root_offset = fdt_root_offset(fdt);
subnode1_offset = fdt_path_offset(fdt, "/subnode@1");
subnode2_offset = fdt_path_offset(fdt, "/subnode@2");
subsubnode1_offset = fdt_path_offset(fdt, "/subnode@1/subsubnode");
@@ -54,7 +56,7 @@ int main(int argc, char *argv[])
|| (subsubnode1_offset < 0) || (subsubnode2_offset < 0))
FAIL("Can't find required nodes");
- check_search(fdt, "test_tree1", 0, -FDT_ERR_NOTFOUND);
+ check_search(fdt, "test_tree1", root_offset, -FDT_ERR_NOTFOUND);
check_search(fdt, "subnode1", subnode1_offset, -FDT_ERR_NOTFOUND);
check_search(fdt, "subsubnode1", subsubnode1_offset, -FDT_ERR_NOTFOUND);
check_search(fdt, "subsubnode2", subsubnode2_offset, -FDT_ERR_NOTFOUND);
diff --git a/tests/node_offset_by_prop_value.c b/tests/node_offset_by_prop_value.c
index 48ab1d93..329409b9 100644
--- a/tests/node_offset_by_prop_value.c
+++ b/tests/node_offset_by_prop_value.c
@@ -64,12 +64,14 @@ static void check_search_str(void *fdt, const char *propname,
int main(int argc, char *argv[])
{
void *fdt;
+ int root_offset;
int subnode1_offset, subnode2_offset;
int subsubnode1_offset, subsubnode2_offset;
test_init(argc, argv);
fdt = load_blob_arg(argc, argv);
+ root_offset = fdt_root_offset(fdt);
subnode1_offset = fdt_path_offset(fdt, "/subnode@1");
subnode2_offset = fdt_path_offset(fdt, "/subnode@2");
subsubnode1_offset = fdt_path_offset(fdt, "/subnode@1/subsubnode");
@@ -79,19 +81,20 @@ int main(int argc, char *argv[])
|| (subsubnode1_offset < 0) || (subsubnode2_offset < 0))
FAIL("Can't find required nodes");
- check_search_cell(fdt, "prop-int", TEST_VALUE_1, 0, subnode1_offset,
- subsubnode1_offset, -FDT_ERR_NOTFOUND);
+ check_search_cell(fdt, "prop-int", TEST_VALUE_1, root_offset,
+ subnode1_offset, subsubnode1_offset, -FDT_ERR_NOTFOUND);
check_search_cell(fdt, "prop-int", TEST_VALUE_2, subnode2_offset,
subsubnode2_offset, -FDT_ERR_NOTFOUND);
- check_search_str(fdt, "prop-str", TEST_STRING_1, 0, -FDT_ERR_NOTFOUND);
+ check_search_str(fdt, "prop-str", TEST_STRING_1, root_offset,
+ -FDT_ERR_NOTFOUND);
check_search_str(fdt, "prop-str", "no such string", -FDT_ERR_NOTFOUND);
check_search_cell(fdt, "prop-int", TEST_VALUE_1+1, -FDT_ERR_NOTFOUND);
- check_search(fdt, "no-such-prop", NULL, 0, -FDT_ERR_NOTFOUND);
+ check_search(fdt, "no-such-prop", NULL, root_offset, -FDT_ERR_NOTFOUND);
PASS();
}
diff --git a/tests/path_offset.c b/tests/path_offset.c
index ad8db833..d4f6553b 100644
--- a/tests/path_offset.c
+++ b/tests/path_offset.c
@@ -84,11 +84,16 @@ int main(int argc, char *argv[])
void *fdt;
int subnode1_offset, subnode2_offset;
int subsubnode1_offset, subsubnode2_offset, subsubnode2_offset2;
+ int root_offset;
test_init(argc, argv);
fdt = load_blob_arg(argc, argv);
- check_path_offset(fdt, "/", 0);
+ root_offset = fdt_root_offset(fdt);
+ if (root_offset < 0)
+ FAIL("fdt_root_offset()) failed: %s", fdt_strerror(root_offset));
+
+ check_path_offset(fdt, "/", root_offset);
subnode1_offset = check_subnode(fdt, 0, "subnode@1");
subnode2_offset = check_subnode(fdt, 0, "subnode@2");
@@ -106,8 +111,8 @@ int main(int argc, char *argv[])
/* Test paths with extraneous separators */
check_path_offset(fdt, "", -FDT_ERR_BADPATH);
- check_path_offset(fdt, "//", 0);
- check_path_offset(fdt, "///", 0);
+ check_path_offset(fdt, "//", root_offset);
+ check_path_offset(fdt, "///", root_offset);
check_path_offset(fdt, "//subnode@1", subnode1_offset);
check_path_offset(fdt, "/subnode@1/", subnode1_offset);
check_path_offset(fdt, "//subnode@1///", subnode1_offset);
@@ -116,7 +121,7 @@ int main(int argc, char *argv[])
/* Test fdt_path_offset_namelen() */
check_path_offset_namelen(fdt, "/subnode@1", -1, -FDT_ERR_BADPATH);
check_path_offset_namelen(fdt, "/subnode@1", 0, -FDT_ERR_BADPATH);
- check_path_offset_namelen(fdt, "/subnode@1", 1, 0);
+ check_path_offset_namelen(fdt, "/subnode@1", 1, root_offset);
check_path_offset_namelen(fdt, "/subnode@1/subsubnode", 10, subnode1_offset);
check_path_offset_namelen(fdt, "/subnode@1/subsubnode", 11, subnode1_offset);
check_path_offset_namelen(fdt, "/subnode@2TRAILINGGARBAGE", 10, subnode2_offset);
diff --git a/tests/root_node.c b/tests/root_node.c
index 37e6f059..30903f2b 100644
--- a/tests/root_node.c
+++ b/tests/root_node.c
@@ -19,12 +19,16 @@ int main(int argc, char *argv[])
{
void *fdt;
const struct fdt_node_header *nh;
+ int root_offset;
test_init(argc, argv);
fdt = load_blob_arg(argc, argv);
- nh = fdt_offset_ptr(fdt, 0, sizeof(*nh));
+ root_offset = fdt_root_offset(fdt);
+ if (root_offset < 0)
+ FAIL("fdt_root_offset() returns %d", root_offset);
+ nh = fdt_offset_ptr(fdt, root_offset, sizeof(*nh));
if (! nh)
FAIL("NULL retrieving root node");
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 04/15] tests/nopulate: Add a FDT_NOP before the root node
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (2 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 03/15] tests: " Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 05/15] tests: treegen: Introduce emit_fdt_header_vers() Herve Codina
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
A FDT_NOP tag can be present at the offset 0 and so before the root
node. This is a legit case.
The nopulate tool adds FDT_NOP tag after each tag encountered but it
doesn't add a FDT_NOP tag at offset 0.
Improve nopulate to fix this lack and add a FDT_NOP tag at offset 0.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
tests/nopulate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/nopulate.c b/tests/nopulate.c
index 06f8369a..050e69fb 100644
--- a/tests/nopulate.c
+++ b/tests/nopulate.c
@@ -22,7 +22,10 @@ static int nopulate_struct(char *buf, const char *fdt)
uint32_t tag;
char *p;
+ /* Add a FDT_NOP before the root node (first node) */
p = buf;
+ *((fdt32_t *)p) = cpu_to_fdt32(FDT_NOP);
+ p += FDT_TAGSIZE;
do {
offset = nextoffset;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 05/15] tests: treegen: Introduce emit_fdt_header_vers()
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (3 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 04/15] tests/nopulate: Add a FDT_NOP before the root node Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 06/15] Introduce structured tag value definition Herve Codina
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
treegen is used to generate custom dtbs. It uses emit_fdt_header()
to generate the header part.
The current definition of this function doesn't allow to set custom
settings related to version fields.
In order to easily generate some dtb with custom version values,
introduce emit_fdt_header_vers().
The modification doesn't introduce any functional changes.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
tests/treegen.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tests/treegen.c b/tests/treegen.c
index 6891bfd6..28943d43 100644
--- a/tests/treegen.c
+++ b/tests/treegen.c
@@ -105,7 +105,8 @@ static void fill_prop_name(struct buf *b, size_t strs, size_t prop, size_t strof
/* FDT structure helpers */
-static size_t emit_fdt_header(struct buf *b)
+static size_t emit_fdt_header_vers(struct buf *b, uint32_t version,
+ uint32_t last_comp_version)
{
size_t off = emit_u32(b, FDT_MAGIC);
@@ -113,14 +114,19 @@ static size_t emit_fdt_header(struct buf *b)
emit_u32(b, 0); /* off_dt_struct */
emit_u32(b, 0); /* off_dt_strings */
emit_u32(b, 0); /* off_mem_rsvmap */
- emit_u32(b, 0x11); /* version */
- emit_u32(b, 0x10); /* last_comp_version */
+ emit_u32(b, version); /* version */
+ emit_u32(b, last_comp_version); /* last_comp_version */
emit_u32(b, 0); /* boot_cpuid_phys */
emit_u32(b, 0); /* size_dt_strings */
emit_u32(b, 0); /* size_dt_struct */
return off;
}
+static size_t emit_fdt_header(struct buf *b)
+{
+ return emit_fdt_header_vers(b, 0x11, 0x10);
+}
+
static void finish_rsvmap(struct buf *b, size_t hdr, size_t rsvmap)
{
struct fdt_header *fh = (struct fdt_header *)(b->data + hdr);
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 06/15] Introduce structured tag value definition
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (4 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 05/15] tests: treegen: Introduce emit_fdt_header_vers() Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 07/15] fdtdump: Handle unknown tags Herve Codina
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
The goal of structured tag values is to ease the introduction of new
tags in future releases with the capability for an already existing
release to ignore those structured tags. In order to do that data length
related to the unknown tag needs to be identified.
Also add a flag to tell an old release if this tag can be simply skipped
or must lead to an error.
Structured tag value is defined on 32bit and is defined as follow:
Bits | 31 | 30 | 29 28 | 27 0|
------+----+-----------+-------------------+--------+
Fields| 1 | SKIP_SAFE | DATA_LEN_ENCODING | TAG_ID |
------+----+-----------+-------------------+--------+
Bit 31 is always set to 1 to identify a structured tag value.
Bit 30 (SKIP_SAFE) is set to 1 if the tag can be safely ignored when its
TAG_ID value is not a known value (unknown tag). If the SKIP_SAFE bit is
set to 0 this tag must not be ignored and an error should be reported
when its TAG_ID value is not a known value (unknown tag).
Bits 29..28 (DATA_LEN_ENCODING) indicates the length of the data related
to the tag. Following values are possible:
- 0b00: No data.
The tag is followed by the next tag value.
- 0b01: 1 cell data
The tag is followed by a 1 cell (u32) data. The next tag is
available after this cell.
- 0b10: 2 cells data
The tag is followed by a 2 cells (2 * u32) data. The next tag
is available after those two cells.
- 0b11: Data length encoding
The tag is followed by a cell (u32) indicating the size of the
data. This size is given in bytes. Data are available right
after this cell.
The next tag is available after the data. Padding is present
after the data in order to have the next tag aligned on 32bits.
This padding is not included in the size of the data.
Bits 27..0 (TAG_ID) is the tag identifier defining a specific tag.
Introduce the structured tag values definition and some specific tags
reserved for tests based on this structure definition.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
libfdt/fdt.h | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/libfdt/fdt.h b/libfdt/fdt.h
index a07abfcc..f41a355f 100644
--- a/libfdt/fdt.h
+++ b/libfdt/fdt.h
@@ -49,6 +49,7 @@ struct fdt_property {
#define FDT_MAGIC 0xd00dfeed /* 4: version, 4: total size */
#define FDT_TAGSIZE sizeof(fdt32_t)
+#define FDT_CELLSIZE sizeof(fdt32_t)
#define FDT_BEGIN_NODE 0x1 /* Start node: full name */
#define FDT_END_NODE 0x2 /* End node */
@@ -57,6 +58,28 @@ struct fdt_property {
#define FDT_NOP 0x4 /* nop */
#define FDT_END 0x9
+/* Tag values flags */
+#define FDT_TAG_STRUCTURED (1U<<31)
+#define FDT_TAG_SKIP_SAFE (1U<<30)
+#define FDT_TAG_DATA_MASK (3U<<28)
+#define FDT_TAG_DATA_NONE (0U<<28)
+#define FDT_TAG_DATA_1CELL (1U<<28)
+#define FDT_TAG_DATA_2CELLS (2U<<28)
+#define FDT_TAG_DATA_VARLEN (3U<<28)
+
+#define FDT_TAG_NO_SKIP(tag_data, tag_id) \
+ (FDT_TAG_STRUCTURED | tag_data | tag_id)
+
+#define FDT_TAG_CAN_SKIP(tag_data, tag_id) \
+ (FDT_TAG_STRUCTURED | FDT_TAG_SKIP_SAFE | tag_data | tag_id)
+
+/* Tests reserved tags */
+#define FDT_TEST_NONE_CAN_SKIP FDT_TAG_CAN_SKIP(FDT_TAG_DATA_NONE, 0)
+#define FDT_TEST_1CELL_CAN_SKIP FDT_TAG_CAN_SKIP(FDT_TAG_DATA_1CELL, 0)
+#define FDT_TEST_2CELLS_CAN_SKIP FDT_TAG_CAN_SKIP(FDT_TAG_DATA_2CELLS, 0)
+#define FDT_TEST_VARLEN_CAN_SKIP FDT_TAG_CAN_SKIP(FDT_TAG_DATA_VARLEN, 0)
+#define FDT_TEST_NONE_NO_SKIP FDT_TAG_NO_SKIP(FDT_TAG_DATA_NONE, 0)
+
#define FDT_V1_SIZE (7*sizeof(fdt32_t))
#define FDT_V2_SIZE (FDT_V1_SIZE + sizeof(fdt32_t))
#define FDT_V3_SIZE (FDT_V2_SIZE + sizeof(fdt32_t))
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 07/15] fdtdump: Handle unknown tags
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (5 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 06/15] Introduce structured tag value definition Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 08/15] flattree: " Herve Codina
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
The structured tag value definition introduced recently gives the
ability to ignore unknown tags without any error when they are read.
Add support for those structured tags in fdtdump and introduce a command
line option to dump unknown tags that should be ignored.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
fdtdump.c | 45 ++++++-
tests/Makefile.tests | 3 +-
tests/meson.build | 2 +
tests/run_tests.sh | 41 +++++++
tests/treegen.c | 162 +++++++++++++++++++++++++
tests/unknown_tags_can_skip.dtb.expect | 29 +++++
6 files changed, 278 insertions(+), 4 deletions(-)
create mode 100644 tests/unknown_tags_can_skip.dtb.expect
diff --git a/fdtdump.c b/fdtdump.c
index 0e7a2659..7a8b2784 100644
--- a/fdtdump.c
+++ b/fdtdump.c
@@ -44,7 +44,7 @@ static const char *tagname(uint32_t tag)
#define dumpf(fmt, args...) \
do { if (debug) printf("// " fmt, ## args); } while (0)
-static void dump_blob(void *blob, bool debug)
+static void dump_blob(void *blob, bool debug, int dump_unknown)
{
uintptr_t blob_off = (uintptr_t)blob;
struct fdt_header *bph = blob;
@@ -146,20 +146,55 @@ static void dump_blob(void *blob, bool debug)
continue;
}
+ if ((tag & FDT_TAG_STRUCTURED) && (tag & FDT_TAG_SKIP_SAFE)) {
+ sz = 0;
+ switch (tag & FDT_TAG_DATA_MASK) {
+ case FDT_TAG_DATA_NONE:
+ break;
+ case FDT_TAG_DATA_1CELL:
+ sz = FDT_CELLSIZE;
+ break;
+ case FDT_TAG_DATA_2CELLS:
+ sz = 2 * FDT_CELLSIZE;
+ break;
+ case FDT_TAG_DATA_VARLEN:
+ /* Get the length */
+ sz = fdt32_to_cpu(GET_CELL(p));
+ break;
+ }
+
+ if (dump_unknown) {
+ printf("%*s// Unknown tag ignored: 0x%08"PRIx32", data len %d",
+ depth * shift, "", tag, sz);
+ if (dump_unknown > 1 && sz != 0) {
+ printf(" ");
+ for (i = 0; i < sz; i++)
+ printf("%02hhx", *(p + i));
+ }
+ printf("\n");
+ }
+
+ /* Skip the data bytes */
+ p = PALIGN(p + sz, 4);
+ continue;
+ }
+
die("** Unknown tag 0x%08"PRIx32"\n", tag);
}
}
/* Usage related data. */
static const char usage_synopsis[] = "fdtdump [options] <file>";
-static const char usage_short_opts[] = "ds" USAGE_COMMON_SHORT_OPTS;
+static const char usage_short_opts[] = "dus" USAGE_COMMON_SHORT_OPTS;
static struct option const usage_long_opts[] = {
{"debug", no_argument, NULL, 'd'},
+ {"unknown", no_argument, NULL, 'u'},
{"scan", no_argument, NULL, 's'},
USAGE_COMMON_LONG_OPTS
};
static const char * const usage_opts_help[] = {
"Dump debug information while decoding the file",
+ "Dump unknown tags information while decoding the file (-uu to dump data)",
"Scan for an embedded fdt in file",
USAGE_COMMON_OPTS_HELP
};
@@ -183,6 +218,7 @@ int main(int argc, char *argv[])
const char *file;
char *buf;
bool debug = false;
+ int dump_unknown = 0;
bool scan = false;
size_t len;
@@ -198,6 +234,9 @@ int main(int argc, char *argv[])
case 'd':
debug = true;
break;
+ case 'u':
+ dump_unknown++;
+ break;
case 's':
scan = true;
break;
@@ -242,7 +281,7 @@ int main(int argc, char *argv[])
} else if (!valid_header(buf, len))
die("%s: header is not valid\n", file);
- dump_blob(buf, debug);
+ dump_blob(buf, debug, dump_unknown);
return 0;
}
diff --git a/tests/Makefile.tests b/tests/Makefile.tests
index af5d309c..63e201ae 100644
--- a/tests/Makefile.tests
+++ b/tests/Makefile.tests
@@ -44,7 +44,8 @@ TESTS = $(LIB_TESTS) $(DL_LIB_TESTS)
TESTS_TREES_L = test_tree1.dtb bad_node_char.dtb bad_node_format.dtb \
bad_prop_char.dtb ovf_size_strings.dtb truncated_property.dtb \
truncated_string.dtb truncated_memrsv.dtb unterminated_memrsv.dtb \
- two_roots.dtb named_root.dtb
+ two_roots.dtb named_root.dtb unknown_tags_can_skip.dtb \
+ unknown_tags_no_skip.dtb
TESTS_TREES = $(TESTS_TREES_L:%=$(TESTS_PREFIX)%)
TESTS_TARGETS = $(TESTS) $(TESTS_TREES)
diff --git a/tests/meson.build b/tests/meson.build
index c6ac2d7f..779e6bc7 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -17,6 +17,8 @@ treegen_dtb = custom_target(
'unterminated_memrsv.dtb',
'two_roots.dtb',
'named_root.dtb',
+ 'unknown_tags_can_skip.dtb',
+ 'unknown_tags_no_skip.dtb',
]
)
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 842b5430..f3647e63 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -196,6 +196,40 @@ check_align () {
)
}
+# $1: generated file
+# $2: expected file
+check_diff () {
+ printf "check_diff $1 $2: "
+ local fgen="$1"
+ local fref="$2"
+ (
+ if diff $fref $fgen >/dev/null; then
+ PASS
+ else
+ if [ -z "$QUIET_TEST" ]; then
+ echo "DIFF :-:"
+ diff -u $fref $fgen
+ fi
+ FAIL "Results differ from expected"
+ fi
+ )
+}
+
+# $1: dtb file
+# $2: out file
+wrap_fdtdump () {
+ printf "wrap_fdtdump -uu $1: "
+ local dtb="$1"
+ local out="$2"
+ (
+ if $FDTDUMP -uu ${dtb} 2>/dev/null >${out}; then
+ PASS
+ else
+ FAIL
+ fi
+ )
+}
+
run_dtc_test () {
printf "dtc $*: "
base_run_test wrap_test $VALGRIND $DTC "$@"
@@ -1008,6 +1042,13 @@ utilfdt_tests () {
fdtdump_tests () {
run_fdtdump_test "$SRCDIR/fdtdump.dts"
+
+ base_run_test wrap_fdtdump unknown_tags_can_skip.dtb unknown_tags_can_skip.dtb.out
+ # Remove unneeded comments
+ sed -i '/^\/\/ [^U]/d' unknown_tags_can_skip.dtb.out
+ base_run_test check_diff unknown_tags_can_skip.dtb.out "$SRCDIR/unknown_tags_can_skip.dtb.expect"
+
+ run_wrap_error_test $FDTDUMP unknown_tags_no_skip.dtb
}
fdtoverlay_tests() {
diff --git a/tests/treegen.c b/tests/treegen.c
index 28943d43..f07c8963 100644
--- a/tests/treegen.c
+++ b/tests/treegen.c
@@ -707,6 +707,166 @@ static struct buf make_named_root(void)
return b;
}
+/* Tree with "unknown" tags that can be skipped
+ * Use a really future dtb version to check version downgrade on
+ * modification.
+ */
+static struct buf make_unknown_tags_can_skip(void)
+{
+ struct buf b = buf_init();
+ size_t hdr;
+ size_t p_int, p_str;
+ size_t p_sn1_int;
+ size_t p_sn2_int1, p_sn2_int2;
+ size_t p_sn2ssn_bool;
+
+ hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10);
+ emit_align(&b, 8);
+
+ emit_rsvmap_empty(&b, hdr);
+
+ {
+ size_t ss = start_block(&b);
+
+ emit_u32(&b, FDT_TEST_1CELL_CAN_SKIP);
+ emit_u32(&b, 0x1);
+
+ emit_begin_node(&b, "");
+ emit_u32(&b, FDT_TEST_NONE_CAN_SKIP);
+
+ p_int = emit_prop_u32(&b, 0, 0x3201);
+
+ emit_u32(&b, FDT_TEST_1CELL_CAN_SKIP);
+ emit_u32(&b, 0x110);
+
+ p_str = emit_prop_str(&b, 0, "abcd");
+
+ emit_u32(&b, FDT_TEST_2CELLS_CAN_SKIP);
+ emit_u32(&b, 0x120);
+ emit_u32(&b, 0x121);
+
+ emit_u32(&b, FDT_TEST_VARLEN_CAN_SKIP);
+ emit_u32(&b, 3);
+ emit_bytes(&b, (const uint8_t []){0x10, 0x11, 0x12}, 3);
+ emit_align(&b, FDT_TAGSIZE);
+
+ emit_begin_node(&b, "subnode1");
+ p_sn1_int = emit_prop_u64(&b, 0, 0x640100006402);
+ emit_u32(&b, FDT_TEST_NONE_CAN_SKIP);
+ emit_end_node(&b);
+
+ emit_begin_node(&b, "subnode2");
+ emit_u32(&b, FDT_TEST_1CELL_CAN_SKIP);
+ emit_u32(&b, 0x121);
+
+ p_sn2_int1 = emit_prop_u64(&b, 0, 0x6402000064021);
+
+ emit_u32(&b, FDT_TEST_2CELLS_CAN_SKIP);
+ emit_u32(&b, 0x1220);
+ emit_u32(&b, 0x1221);
+
+ p_sn2_int2 = emit_prop_u32(&b, 0, 0x32022);
+
+ emit_begin_node(&b, "subsubnode");
+ emit_u32(&b, FDT_TEST_2CELLS_CAN_SKIP);
+ emit_u32(&b, 0x1230);
+ emit_u32(&b, 0x1231);
+ p_sn2ssn_bool = emit_prop_nil(&b, 0);
+ emit_end_node(&b);
+
+ emit_u32(&b, FDT_TEST_VARLEN_CAN_SKIP);
+ emit_u32(&b, 3);
+ emit_bytes(&b, (const uint8_t []){0x21, 0x22, 0x23}, 3);
+ emit_align(&b, FDT_TAGSIZE);
+ emit_end_node(&b);
+
+ emit_u32(&b, FDT_TEST_VARLEN_CAN_SKIP);
+ emit_u32(&b, 4);
+ emit_bytes(&b, (const uint8_t []){0x31, 0x32, 0x33, 0x34}, 4);
+ emit_align(&b, FDT_TAGSIZE);
+ emit_end_node(&b);
+
+ emit_u32(&b, FDT_TEST_1CELL_CAN_SKIP);
+ emit_u32(&b, 0x2);
+
+ emit_u32(&b, FDT_TEST_VARLEN_CAN_SKIP);
+ emit_u32(&b, 2);
+ emit_bytes(&b, (const uint8_t []){0x40, 0x41}, 2);
+ emit_align(&b, FDT_TAGSIZE);
+
+ emit_fdt_end(&b);
+ finish_struct_block(&b, hdr, ss);
+ }
+
+ {
+ size_t strs = start_block(&b);
+ size_t s;
+
+ s = emit_string(&b, "prop-int");
+ fill_prop_name(&b, strs, p_int, s);
+ fill_prop_name(&b, strs, p_sn1_int, s);
+
+ s = emit_string(&b, "prop-str");
+ fill_prop_name(&b, strs, p_str, s);
+
+ s = emit_string(&b, "prop-int1");
+ fill_prop_name(&b, strs, p_sn2_int1, s);
+
+ s = emit_string(&b, "prop-int2");
+ fill_prop_name(&b, strs, p_sn2_int2, s);
+
+ s = emit_string(&b, "prop-bool");
+ fill_prop_name(&b, strs, p_sn2ssn_bool, s);
+
+ finish_strings_block(&b, hdr, strs);
+ }
+
+ finish_totalsize(&b, hdr);
+
+ return b;
+}
+
+/* Tree with "unknown" tags that cannot be skipped */
+static struct buf make_unknown_tags_no_skip(void)
+{
+ struct buf b = buf_init();
+ size_t hdr;
+ size_t p_prop_u64;
+
+ hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10);
+ emit_align(&b, 8);
+
+ emit_rsvmap_empty(&b, hdr);
+
+ {
+ size_t ss = start_block(&b);
+
+ emit_begin_node(&b, "");
+ emit_u32(&b, FDT_TEST_NONE_NO_SKIP);
+
+ emit_begin_node(&b, "subnode1");
+ p_prop_u64 = emit_prop_u64(&b, 0, 0x100000002);
+ emit_end_node(&b);
+ emit_end_node(&b);
+ emit_fdt_end(&b);
+ finish_struct_block(&b, hdr, ss);
+ }
+
+ {
+ size_t strs = start_block(&b);
+ size_t s;
+
+ s = emit_string(&b, "prop-int");
+ fill_prop_name(&b, strs, p_prop_u64, s);
+
+ finish_strings_block(&b, hdr, strs);
+ }
+
+ finish_totalsize(&b, hdr);
+
+ return b;
+}
+
/* Tree table and main */
static struct {
@@ -722,6 +882,8 @@ static struct {
TREE(unterminated_memrsv),
TREE(two_roots),
TREE(named_root),
+ TREE(unknown_tags_can_skip),
+ TREE(unknown_tags_no_skip),
};
int main(int argc, char *argv[])
diff --git a/tests/unknown_tags_can_skip.dtb.expect b/tests/unknown_tags_can_skip.dtb.expect
new file mode 100644
index 00000000..5ad9964e
--- /dev/null
+++ b/tests/unknown_tags_can_skip.dtb.expect
@@ -0,0 +1,29 @@
+/dts-v1/;
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 08/15] flattree: Handle unknown tags
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (6 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 07/15] fdtdump: Handle unknown tags Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 09/15] libfdt: Handle unknown tags in fdt_next_tag() Herve Codina
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
The structured tag value definition introduced recently gives the
ability to ignore unknown tags without any error when they are read.
Handle those structured tag.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
flattree.c | 65 ++++++++++++++++++++--
tests/run_tests.sh | 5 ++
tests/unknown_tags_can_skip.dtb.dts.expect | 19 +++++++
3 files changed, 84 insertions(+), 5 deletions(-)
create mode 100644 tests/unknown_tags_can_skip.dtb.dts.expect
diff --git a/flattree.c b/flattree.c
index f3b698c1..88dbfa7e 100644
--- a/flattree.c
+++ b/flattree.c
@@ -579,7 +579,8 @@ static void flat_read_chunk(struct inbuf *inb, void *p, int len)
if ((inb->ptr + len) > inb->limit)
die("Premature end of data parsing flat device tree\n");
- memcpy(p, inb->ptr, len);
+ if (p)
+ memcpy(p, inb->ptr, len);
inb->ptr += len;
}
@@ -604,6 +605,61 @@ static void flat_realign(struct inbuf *inb, int align)
die("Premature end of data parsing flat device tree\n");
}
+static bool flat_skip_unknown_tag(struct inbuf *inb, uint32_t tag)
+{
+ uint32_t lng;
+
+ if (!(tag & FDT_TAG_STRUCTURED) || !(tag & FDT_TAG_SKIP_SAFE))
+ return false;
+
+ switch (tag & FDT_TAG_DATA_MASK) {
+ case FDT_TAG_DATA_NONE:
+ break;
+
+ case FDT_TAG_DATA_1CELL:
+ flat_read_word(inb);
+ break;
+
+ case FDT_TAG_DATA_2CELLS:
+ flat_read_word(inb);
+ flat_read_word(inb);
+ break;
+
+ case FDT_TAG_DATA_VARLEN:
+ /* Get the length */
+ lng = flat_read_word(inb);
+
+ /* Skip the following length bytes */
+ flat_read_chunk(inb, NULL, lng);
+
+ flat_realign(inb, sizeof(uint32_t));
+ break;
+ }
+
+ return true;
+}
+
+static uint32_t flat_read_tag(struct inbuf *inb)
+{
+ uint32_t tag;
+
+ do {
+ tag = flat_read_word(inb);
+ switch (tag) {
+ case FDT_BEGIN_NODE:
+ case FDT_END_NODE:
+ case FDT_PROP:
+ case FDT_NOP:
+ case FDT_END:
+ return tag;
+ default:
+ break;
+ }
+ } while (flat_skip_unknown_tag(inb, tag));
+
+ die("Cannot skip unknown tag 0x%08x\n", tag);
+}
+
static const char *flat_read_string(struct inbuf *inb)
{
int len = 0;
@@ -750,7 +806,7 @@ static struct node *unflatten_tree(struct inbuf *dtbuf,
struct property *prop;
struct node *child;
- val = flat_read_word(dtbuf);
+ val = flat_read_tag(dtbuf);
switch (val) {
case FDT_PROP:
if (node->children)
@@ -905,14 +961,13 @@ struct dt_info *dt_from_blob(const char *fname)
reservelist = flat_read_mem_reserve(&memresvbuf);
- val = flat_read_word(&dtbuf);
-
+ val = flat_read_tag(&dtbuf);
if (val != FDT_BEGIN_NODE)
die("Device tree blob doesn't begin with FDT_BEGIN_NODE (begins with 0x%08x)\n", val);
tree = unflatten_tree(&dtbuf, &strbuf, "", flags);
- val = flat_read_word(&dtbuf);
+ val = flat_read_tag(&dtbuf);
if (val != FDT_END)
die("Device tree blob doesn't end with FDT_END\n");
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index f3647e63..8fc23cb7 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -882,6 +882,11 @@ dtc_tests () {
# Tests for overlay/plugin generation
dtc_overlay_tests
+
+ # Tests with "unknown tags"
+ run_dtc_test -I dtb -O dts -o unknown_tags_can_skip.dtb.dts unknown_tags_can_skip.dtb
+ base_run_test check_diff unknown_tags_can_skip.dtb.dts "$SRCDIR/unknown_tags_can_skip.dtb.dts.expect"
+ run_wrap_error_test $DTC -I dtb -O dts -o unknown_tags_no_skip.dtb.dts unknown_tags_no_skip.dtb
}
cmp_tests () {
diff --git a/tests/unknown_tags_can_skip.dtb.dts.expect b/tests/unknown_tags_can_skip.dtb.dts.expect
new file mode 100644
index 00000000..2194025b
--- /dev/null
+++ b/tests/unknown_tags_can_skip.dtb.dts.expect
@@ -0,0 +1,19 @@
+/dts-v1/;
+
+/ {
+ prop-int = <0x3201>;
+ prop-str = "abcd";
+
+ subnode1 {
+ prop-int = <0x6401 0x6402>;
+ };
+
+ subnode2 {
+ prop-int1 = <0x64020 0x64021>;
+ prop-int2 = <0x32022>;
+
+ subsubnode {
+ prop-bool;
+ };
+ };
+};
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 09/15] libfdt: Handle unknown tags in fdt_next_tag()
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (7 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 08/15] flattree: " Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 10/15] libfdt: Introduce fdt_ptr_offset_() Herve Codina
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
The structured tag value definition introduced recently gives the
ability to ignore unknown tags without any error when they are read.
libfdt uses fdt_next_tag() to get a tag.
Filtering out tags that should be ignored in fdt_next_tag() allows to
have the filtering done globally and allows, in future releases, to have
a central place to add new known tags that should not be filtered out.
An already known tag exists with the meaning of "just ignore". This tag
is FDT_NOP. fdt_next_tag() callers already handle the FDT_NOP tag.
Avoid unneeded modification at callers side and use a fake FDT_NOP tag
when an unknown tag that should be ignored is encountered.
Add also fdt_next_tag_() internal function for callers who need to know
if the FDT_NOP tag returned is a real FDT_NOP or a fake FDT_NOP due to
an unknown tag.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
libfdt/fdt.c | 75 ++++++++++++++++++++++++++++++++++++++--
libfdt/libfdt_internal.h | 3 ++
tests/run_tests.sh | 9 +++--
3 files changed, 83 insertions(+), 4 deletions(-)
diff --git a/libfdt/fdt.c b/libfdt/fdt.c
index eb803e8a..506e0dd3 100644
--- a/libfdt/fdt.c
+++ b/libfdt/fdt.c
@@ -167,7 +167,7 @@ const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int len)
return fdt_offset_ptr_(fdt, offset);
}
-uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
+static uint32_t fdt_next_tag_all(const void *fdt, int startoffset, int *nextoffset)
{
const fdt32_t *tagp, *lenp;
uint32_t tag, len, sum;
@@ -218,7 +218,37 @@ uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
break;
default:
- return FDT_END;
+ if (!(tag & FDT_TAG_STRUCTURED) || !(tag & FDT_TAG_SKIP_SAFE))
+ return FDT_END;
+
+ switch (tag & FDT_TAG_DATA_MASK) {
+ case FDT_TAG_DATA_NONE:
+ break;
+ case FDT_TAG_DATA_1CELL:
+ offset += FDT_CELLSIZE;
+ break;
+ case FDT_TAG_DATA_2CELLS:
+ offset += 2 * FDT_CELLSIZE;
+ break;
+ case FDT_TAG_DATA_VARLEN:
+ /* Get the length */
+ lenp = fdt_offset_ptr(fdt, offset, sizeof(*lenp));
+ if (!can_assume(VALID_DTB) && !lenp)
+ return FDT_END; /* premature end */
+ len = fdt32_to_cpu(*lenp);
+ /*
+ * Skip the cell encoding the length and the
+ * following length bytes
+ */
+ len += sizeof(*lenp);
+ sum = len + offset;
+ if (!can_assume(VALID_DTB) &&
+ (sum >= INT_MAX || sum < (uint32_t) offset))
+ return FDT_END; /* premature end */
+
+ offset += len;
+ break;
+ }
}
if (!fdt_offset_ptr(fdt, startoffset, offset - startoffset))
@@ -228,6 +258,47 @@ uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
return tag;
}
+static bool fdt_tag_is_unknown(uint32_t tag)
+{
+ switch (tag) {
+ case FDT_BEGIN_NODE:
+ case FDT_END_NODE:
+ case FDT_PROP:
+ case FDT_NOP:
+ case FDT_END:
+ return false;
+ default:
+ break;
+ }
+ return true;
+}
+
+uint32_t fdt_next_tag_(const void *fdt, int startoffset, int *nextoffset, bool *is_unknown)
+{
+ uint32_t tag;
+ bool unknown = false;
+
+ /* Retrieve next tag */
+ tag = fdt_next_tag_all(fdt, startoffset, nextoffset);
+ if (tag == FDT_END)
+ goto end;
+
+ if (fdt_tag_is_unknown(tag)) {
+ unknown = true;
+ /* Use a known tag that should be skipped by the caller */
+ tag = FDT_NOP;
+ }
+end:
+ if (is_unknown)
+ *is_unknown = unknown;
+ return tag;
+}
+
+uint32_t fdt_next_tag(const void *fdt, int startoffset, int *nextoffset)
+{
+ return fdt_next_tag_(fdt, startoffset, nextoffset, NULL);
+}
+
int fdt_check_node_offset_(const void *fdt, int offset)
{
if (!can_assume(VALID_INPUT)
diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
index 0e103caf..f2e30ce8 100644
--- a/libfdt/libfdt_internal.h
+++ b/libfdt/libfdt_internal.h
@@ -20,6 +20,9 @@ int32_t fdt_ro_probe_(const void *fdt);
} \
}
+uint32_t fdt_next_tag_(const void *fdt, int startoffset, int *nextoffset,
+ bool *is_unknown);
+
int fdt_check_node_offset_(const void *fdt, int offset);
int fdt_check_prop_offset_(const void *fdt, int offset);
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 8fc23cb7..225c22f8 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -577,11 +577,12 @@ libfdt_tests () {
run_test dtbs_equal_ordered cell-overflow.test.dtb cell-overflow-results.test.dtb
# check full tests
- for good in test_tree1.dtb; do
+ for good in test_tree1.dtb unknown_tags_can_skip.dtb; do
run_test check_full $good
done
for bad in truncated_property.dtb truncated_string.dtb \
- truncated_memrsv.dtb two_roots.dtb named_root.dtb; do
+ truncated_memrsv.dtb two_roots.dtb named_root.dtb \
+ unknown_tags_no_skip.dtb; do
run_test check_full -n $bad
done
}
@@ -962,6 +963,10 @@ fdtget_tests () {
run_fdtget_test "<the dead silence>" -tx \
-d "<the dead silence>" $dtb /randomnode doctor-who
run_fdtget_test "<blink>" -tx -d "<blink>" $dtb /memory doctor-who
+
+ # test with unknown tags involved
+ run_fdtget_test "25601 25602" unknown_tags_can_skip.dtb /subnode1 prop-int
+ run_wrap_error_test $DTGET unknown_tags_no_skip.dtb /subnode1 prop-int
}
fdtput_tests () {
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 10/15] libfdt: Introduce fdt_ptr_offset_()
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (8 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 09/15] libfdt: Handle unknown tags in fdt_next_tag() Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 11/15] libfdt: Introduce fdt_getprop_by_offset_w() Herve Codina
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
libfdt provides internal helpers to convert an offset to a pointer but
nothing to do the reverse operation.
Introduce the fdt_ptr_offset_() internal helper to convert a pointer to
an offset.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
libfdt/libfdt_internal.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
index f2e30ce8..3c83d9a7 100644
--- a/libfdt/libfdt_internal.h
+++ b/libfdt/libfdt_internal.h
@@ -46,6 +46,11 @@ static inline void *fdt_offset_ptr_w_(void *fdt, int offset)
return (void *)(uintptr_t)fdt_offset_ptr_(fdt, offset);
}
+static inline int fdt_ptr_offset_(const void *fdt, const void *ptr)
+{
+ return (const char *)ptr - (const char *)fdt_offset_ptr_(fdt, 0);
+}
+
static inline const struct fdt_reserve_entry *fdt_mem_rsv_(const void *fdt, int n)
{
const struct fdt_reserve_entry *rsv_table =
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 11/15] libfdt: Introduce fdt_getprop_by_offset_w()
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (9 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 10/15] libfdt: Introduce fdt_ptr_offset_() Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 12/15] libfdt: Introduce fdt_getprop_offset_namelen() Herve Codina
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
Future operations, such as handling unknown tags on dtb modifications,
need to modify properties retrieved by their offset.
fdt_getprop_by_offset() already exists to get a preperty by its offset
but the property returned is read-only. A writable returned property is
needed.
Fill the lack and introduce fdt_getprop_by_offset_w(), the write enabled
variant of fdt_getprop_by_offset().
Add also its related test.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
libfdt/libfdt.h | 6 +++
tests/.gitignore | 1 +
tests/Makefile.tests | 2 +-
tests/get_prop_offset_w.c | 84 +++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
tests/run_tests.sh | 1 +
tests/tests.h | 1 +
tests/testutils.c | 18 +++++++++
8 files changed, 113 insertions(+), 1 deletion(-)
create mode 100644 tests/get_prop_offset_w.c
diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
index 7a1915a5..82965e32 100644
--- a/libfdt/libfdt.h
+++ b/libfdt/libfdt.h
@@ -856,6 +856,12 @@ static inline struct fdt_property *fdt_get_property_w(void *fdt, int nodeoffset,
#ifndef SWIG /* This function is not useful in Python */
const void *fdt_getprop_by_offset(const void *fdt, int offset,
const char **namep, int *lenp);
+static inline void *fdt_getprop_by_offset_w(const void *fdt, int offset,
+ const char **namep, int *lenp)
+{
+ return (void *)(uintptr_t)fdt_getprop_by_offset(fdt, offset, namep,
+ lenp);
+}
#endif
/**
diff --git a/tests/.gitignore b/tests/.gitignore
index 69693129..1091174a 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -30,6 +30,7 @@ tmp.*
/get_phandle
/getprop
/get_prop_offset
+/get_prop_offset_w
/incbin
/integer-expressions
/fs_tree1
diff --git a/tests/Makefile.tests b/tests/Makefile.tests
index 63e201ae..0d4d399f 100644
--- a/tests/Makefile.tests
+++ b/tests/Makefile.tests
@@ -16,7 +16,7 @@ LIB_TESTS_L = get_mem_rsv \
sw_tree1 sw_states \
move_and_save mangle-layout nopulate \
open_pack rw_tree1 rw_oom set_name setprop del_property del_node \
- appendprop1 appendprop2 propname_escapes \
+ appendprop1 appendprop2 propname_escapes get_prop_offset_w \
string_escapes references path-references phandle_format \
boot-cpuid incbin relref_merge \
extra-terminating-null \
diff --git a/tests/get_prop_offset_w.c b/tests/get_prop_offset_w.c
new file mode 100644
index 00000000..dbfa5dd7
--- /dev/null
+++ b/tests/get_prop_offset_w.c
@@ -0,0 +1,84 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
+/*
+ * libfdt - Flat Device Tree manipulation
+ * Testcase for fdt_getprop_by_offset_w()
+ * Copyright (C) 2026 Bootlin.
+ */
+
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <stdint.h>
+
+#include <libfdt.h>
+
+#include "tests.h"
+#include "testdata.h"
+
+#define SPACE 65536
+
+int main(int argc, char *argv[])
+{
+ const void *exp_val;
+ const char *name;
+ char *modif_val;
+ void *propval;
+ int proplen;
+ int exp_len;
+ int poffset;
+ void *fdt;
+ void *buf;
+ int err;
+
+ test_init(argc, argv);
+ fdt = load_blob_arg(argc, argv);
+
+ buf = xmalloc(SPACE);
+
+ err = fdt_open_into(fdt, buf, SPACE);
+ if (err)
+ FAIL("fdt_open_into(): %s", fdt_strerror(err));
+
+ free(fdt);
+ fdt = buf;
+
+ /* Retrieve the offset of the 'prop-str' property */
+ poffset = get_poffset(fdt, 0, "prop-str");
+ if (poffset < 0)
+ FAIL("Property 'prop-str' not found");
+
+ /* Get the property value for modification */
+ propval = fdt_getprop_by_offset_w(fdt, poffset, &name, &proplen);
+ if (!propval)
+ FAIL("fdt_getprop_by_offset_w(%d): %s", poffset,
+ fdt_strerror(proplen));
+
+ /* Check original values */
+ if (strcmp(name, "prop-str"))
+ FAIL("Name mismatch : %s instead of prop-str", name);
+
+ exp_len = strlen(TEST_STRING_1) + 1;
+ if (proplen != exp_len)
+ FAIL("Original size mismatch on property \"%s\": %d instead of %d",
+ name, proplen, exp_len);
+
+ exp_val = TEST_STRING_1;
+ if (memcmp(exp_val, propval, exp_len))
+ FAIL("Original data mismatch on property \"%s\"", name);
+
+ if (exp_len < 4)
+ CONFIG("Property \"%s\" should be at least 4 bytes", name);
+
+ /* Modify the property value */
+ modif_val = xmalloc(proplen);
+ memcpy(modif_val, propval, proplen);
+ modif_val[1] = (modif_val[1] != 'A') ? 'A' : 'a';
+ modif_val[3] = (modif_val[3] != 'B') ? 'B' : 'b';
+ memcpy(propval, modif_val, exp_len);
+
+ /* Check that the modified value is taken into account */
+ if (!check_get_prop_offset(fdt, poffset, "prop-str", exp_len, modif_val))
+ FAIL("Modified property 'prop-str' not found");
+
+ PASS();
+}
diff --git a/tests/meson.build b/tests/meson.build
index 779e6bc7..dae6a941 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -50,6 +50,7 @@ tests = [
'get_path',
'get_phandle',
'get_prop_offset',
+ 'get_prop_offset_w',
'get_next_tag_invalid_prop_len',
'getprop',
'incbin',
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 225c22f8..419a24d8 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -419,6 +419,7 @@ tree1_tests_rw () {
run_test setprop $TREE
run_test del_property $TREE
run_test del_node $TREE
+ run_test get_prop_offset_w $TREE
}
check_tests () {
diff --git a/tests/tests.h b/tests/tests.h
index 578d8c1a..37ed3394 100644
--- a/tests/tests.h
+++ b/tests/tests.h
@@ -109,6 +109,7 @@ const void *check_get_prop_offset(void *fdt, int poffset, const char *in_name,
const void *check_getprop_addrrange(void *fdt, int parent, int nodeoffset,
const char *name, int num);
+int get_poffset(void *fdt, int nodeoffset, const char *propname);
int nodename_eq(const char *s1, const char *s2);
void vg_prepare_blob(void *fdt, size_t bufsize);
void *load_blob(const char *filename);
diff --git a/tests/testutils.c b/tests/testutils.c
index 6d69e872..d35a1978 100644
--- a/tests/testutils.c
+++ b/tests/testutils.c
@@ -230,6 +230,24 @@ const void *check_getprop_addrrange(void *fdt, int parent, int nodeoffset,
return propval;
}
+int get_poffset(void *fdt, int nodeoffset, const char *propname)
+{
+ const char *name;
+ int poffset;
+
+ fdt_for_each_property_offset(poffset, fdt, nodeoffset) {
+ if (fdt_getprop_by_offset(fdt, poffset, &name, NULL)) {
+ if (!strcmp(name, propname))
+ return poffset;
+ }
+ }
+
+ if (poffset < 0)
+ return poffset;
+
+ return -FDT_ERR_NOTFOUND;
+}
+
int nodename_eq(const char *s1, const char *s2)
{
int len = strlen(s2);
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 12/15] libfdt: Introduce fdt_getprop_offset_namelen()
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (10 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 11/15] libfdt: Introduce fdt_getprop_by_offset_w() Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 13/15] tests: Add wip_func utility Herve Codina
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
Future operations, such as handling unknown tags on dtb modifications,
need to get an offset to a property based on the node offset and the
property name.
Several function exists to get a property based on the node offset
and the property name but none of them allows to get the property
offset.
Fill the lack and introduce fdt_getprop_offset_namelen() and its
simple variant fdt_getprop_offset().
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
libfdt/fdt_ro.c | 13 +++++++++++++
libfdt/libfdt_internal.h | 8 ++++++++
2 files changed, 21 insertions(+)
diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
index 856c62f1..50c0a8bc 100644
--- a/libfdt/fdt_ro.c
+++ b/libfdt/fdt_ro.c
@@ -536,6 +536,19 @@ const void *fdt_getprop(const void *fdt, int nodeoffset,
return fdt_getprop_namelen(fdt, nodeoffset, name, strlen(name), lenp);
}
+int fdt_getprop_offset_namelen(const void *fdt, int nodeoffset,
+ const char *name, int namelen)
+{
+ const struct fdt_property *prop;
+ int lenp, offset;
+
+ prop = fdt_get_property_namelen_(fdt, nodeoffset, name, namelen,
+ &lenp, &offset);
+ if (!prop)
+ return lenp;
+ return offset;
+}
+
uint32_t fdt_get_phandle(const void *fdt, int nodeoffset)
{
const fdt32_t *php;
diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
index 3c83d9a7..e3923629 100644
--- a/libfdt/libfdt_internal.h
+++ b/libfdt/libfdt_internal.h
@@ -26,6 +26,14 @@ uint32_t fdt_next_tag_(const void *fdt, int startoffset, int *nextoffset,
int fdt_check_node_offset_(const void *fdt, int offset);
int fdt_check_prop_offset_(const void *fdt, int offset);
+int fdt_getprop_offset_namelen(const void *fdt, int nodeoffset,
+ const char *name, int namelen);
+static inline int fdt_getprop_offset(const void *fdt, int nodeoffset,
+ const char *name)
+{
+ return fdt_getprop_offset_namelen(fdt, nodeoffset, name, strlen(name));
+}
+
const char *fdt_find_string_len_(const char *strtab, int tabsize, const char *s,
int s_len);
static inline const char *fdt_find_string_(const char *strtab, int tabsize,
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 13/15] tests: Add wip_func utility
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (11 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 12/15] libfdt: Introduce fdt_getprop_offset_namelen() Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 14/15] libfdt: Handle unknown tags on dtb modifications Herve Codina
2026-08-26 8:31 ` [PATCH v3 15/15] Introduce v18 dtb version Herve Codina
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
wip_func is a test utility allowing to wrap the write inplace functions.
It allows to create tests with custom wip write sequence.
Also the modified dtb is saved allowing to perform later checks on this
modified dtb.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
tests/Makefile.tests | 3 +-
tests/meson.build | 1 +
tests/wip_func.c | 127 +++++++++++++++++++++++++++++++++++++++++++
3 files changed, 130 insertions(+), 1 deletion(-)
create mode 100644 tests/wip_func.c
diff --git a/tests/Makefile.tests b/tests/Makefile.tests
index 0d4d399f..a71c4cbf 100644
--- a/tests/Makefile.tests
+++ b/tests/Makefile.tests
@@ -31,7 +31,8 @@ LIB_TESTS_L = get_mem_rsv \
check_path check_header check_full \
fs_tree1 \
truncated_property truncated_string \
- truncated_memrsv unterminated_memrsv
+ truncated_memrsv unterminated_memrsv \
+ wip_func
LIB_TESTS = $(LIB_TESTS_L:%=$(TESTS_PREFIX)%)
ifneq ($(STATIC_BUILD),1)
diff --git a/tests/meson.build b/tests/meson.build
index dae6a941..e7a88936 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -96,6 +96,7 @@ tests = [
'truncated_string',
'unterminated_memrsv',
'utilfdt_test',
+ 'wip_func',
]
test_deps = [testutil_dep, util_dep, libfdt_dep]
diff --git a/tests/wip_func.c b/tests/wip_func.c
new file mode 100644
index 00000000..3becc4f1
--- /dev/null
+++ b/tests/wip_func.c
@@ -0,0 +1,127 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
+/*
+ * libfdt - Flat Device Tree manipulation
+ * Wrapper wip functions family
+ * Copyright (C) 2026 Herve Codina, Bootlin.
+ */
+
+#include <inttypes.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <ctype.h>
+#include <stdint.h>
+#include <errno.h>
+
+#include <libfdt.h>
+
+#include "tests.h"
+
+struct args {
+ char *dtb_path;
+ enum {
+ NOP_NODE,
+ NOP_PROP,
+ SET_PROP,
+ } op;
+ char *node_path;
+ char *prop_name;
+ int index;
+ char *value;
+};
+
+const char *usage_txt = "Usage:\n"
+ " - wip_func <dtb> nop_node <node_path>\n"
+ " - wip_func <dtb> nop_prop <node_path> <prop_name>\n"
+ " - wip_func <dtb> set_prop <node_path> <prop_name> <index> <str>\n"
+ ;
+
+static void parse_args(struct args *args, int argc, char *argv[])
+{
+ char *endptr;
+
+ memset(args, 0, sizeof(*args));
+
+ if (argc < 3)
+ goto fail;
+
+ args->dtb_path = argv[1];
+
+ if (!strcmp(argv[2], "nop_node")) {
+ args->op = NOP_NODE;
+ if (argc != 4)
+ goto fail;
+ args->node_path = argv[3];
+ } else if (!strcmp(argv[2], "nop_prop")) {
+ args->op = NOP_PROP;
+ if (argc != 5)
+ goto fail;
+ args->node_path = argv[3];
+ args->prop_name = argv[4];
+ } else if (!strcmp(argv[2], "set_prop")) {
+ args->op = SET_PROP;
+ if (argc != 7)
+ goto fail;
+ args->node_path = argv[3];
+ args->prop_name = argv[4];
+ errno = 0;
+ args->index = strtol(argv[5], &endptr, 0);
+ if (*endptr != '\0' || errno)
+ goto fail;
+ args->value = argv[6];
+ } else {
+ goto fail;
+ }
+
+ return;
+
+fail:
+ CONFIG("%s\n", usage_txt);
+}
+
+int main(int argc, char *argv[])
+{
+ struct args args;
+ void *fdt;
+ int node;
+ int err;
+
+ test_init(argc, argv);
+
+ parse_args(&args, argc, argv);
+
+ fdt = load_blob(args.dtb_path);
+
+ node = fdt_path_offset(fdt, args.node_path);
+ if (node < 0)
+ FAIL("Fail to get '%s': %s", args.node_path, fdt_strerror(node));
+
+ switch (args.op) {
+ case NOP_NODE:
+ err = fdt_nop_node(fdt, node);
+ if (err)
+ FAIL("fdt_nop_node('%s'): %s", args.node_path, fdt_strerror(err));
+ break;
+
+ case NOP_PROP:
+ err = fdt_nop_property(fdt, node, args.prop_name);
+ if (err)
+ FAIL("fdt_nop_node('%s', '%s'): %s", args.node_path,
+ args.prop_name, fdt_strerror(err));
+ break;
+
+ case SET_PROP:
+ err = fdt_setprop_inplace_namelen_partial(fdt, node,
+ args.prop_name, strlen(args.prop_name), args.index,
+ args.value, strlen(args.value) + 1);
+ if (err)
+ FAIL("fdt_setprop_inplace_namelen_partial('%s', '%s', %d, \"%s\"): %s",
+ args.node_path, args.prop_name, args.index,
+ args.value, fdt_strerror(err));
+ break;
+ }
+
+ save_blob(args.dtb_path, fdt);
+
+ PASS();
+}
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 14/15] libfdt: Handle unknown tags on dtb modifications
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (12 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 13/15] tests: Add wip_func utility Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
2026-08-26 8:31 ` [PATCH v3 15/15] Introduce v18 dtb version Herve Codina
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina
The structured tag value definition introduced recently gives the
ability to ignore unknown tags without any error.
When the dtb is modified those unknown tags have to be taken into
account.
First, depending on the unknown tag location, the item associated with
the tag is identified:
- An unknown tag located just after a FDT_BEGIN_NODE is related to the
node.
- An unknown tag located just after a FDT_PROP is related to the
property.
- An unknown tag out of any node (i.e located before the first
FDT_BEGIN_NODE or after the last FDT_END_NODE) is a global tag
related to the dtb itself.
Then, if we are allowed to write a dtb containing unknown tags, the
following rules are used:
- When a property is modified, tags related to this property are
removed and the dtb version is downgraded.
- When a property is removed, tags related to this property are
obviously removed. The dtb version is kept unchanged.
- When a property or a node is added, obviously no unknown tags are
added and the dtb version is kept unchanged.
- When a node is removed, tags related to this node are obviously
removed. The dtb version is kept unchanged.
- Adding, removing or modifying a property is not considered as a node
modification and so, those operations have no impacts on unknown
tags related to the node. Those node related tags are kept unchanged.
- The only modification considered as a node modification is setting
its name. We consider that this operation has no impact on tags
related to the node. Here also, those node related tags and the
dtb version are kept unchanged.
- Global (dtb related) unknown tags are kept unchanged regardless the
modification done.
Implement those rules when a dtb is modified.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
libfdt/fdt_rw.c | 129 +++++++++++++++++-
libfdt/fdt_wip.c | 28 +++-
libfdt/libfdt_internal.h | 3 +
tests/run_tests.sh | 78 +++++++++++
...own_tags_can_skip.fdtput.test.dtb.0.expect | 31 +++++
...own_tags_can_skip.fdtput.test.dtb.1.expect | 35 +++++
...own_tags_can_skip.fdtput.test.dtb.2.expect | 33 +++++
...own_tags_can_skip.fdtput.test.dtb.3.expect | 35 +++++
...own_tags_can_skip.fdtput.test.dtb.4.expect | 34 +++++
...own_tags_can_skip.fdtput.test.dtb.5.expect | 32 +++++
...own_tags_can_skip.fdtput.test.dtb.6.expect | 27 ++++
...nknown_tags_can_skip.wip.test.dtb.0.expect | 31 +++++
...nknown_tags_can_skip.wip.test.dtb.1.expect | 35 +++++
...nknown_tags_can_skip.wip.test.dtb.2.expect | 37 +++++
...nknown_tags_can_skip.wip.test.dtb.3.expect | 38 ++++++
15 files changed, 603 insertions(+), 3 deletions(-)
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect
create mode 100644 tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect
create mode 100644 tests/unknown_tags_can_skip.wip.test.dtb.0.expect
create mode 100644 tests/unknown_tags_can_skip.wip.test.dtb.1.expect
create mode 100644 tests/unknown_tags_can_skip.wip.test.dtb.2.expect
create mode 100644 tests/unknown_tags_can_skip.wip.test.dtb.3.expect
diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c
index ceef49b8..87776609 100644
--- a/libfdt/fdt_rw.c
+++ b/libfdt/fdt_rw.c
@@ -197,10 +197,69 @@ int fdt_del_mem_rsv(void *fdt, int n)
return fdt_splice_mem_rsv_(fdt, re, 1, 0);
}
+static void fdt_nopify_area(void *fdt, int start_offset, int next_offset)
+{
+ int count = (next_offset - start_offset) / sizeof(fdt32_t);
+ fdt32_t fdt32_nop = cpu_to_fdt32(FDT_NOP);
+ fdt32_t *ptr;
+
+ ptr = fdt_offset_ptr_w_(fdt, start_offset);
+ while (count--)
+ *(ptr++) = fdt32_nop;
+};
+
+int fdt_prop_remove_unknown_tags(void *fdt, bool force_inplace,
+ int prop_offset, bool downgrade_version)
+{
+ int nextoffset, offset;
+ bool is_unknown;
+ uint32_t tag;
+
+ /*
+ * Only inplace using nopify is supported even if we could use an other
+ * method involving splices if force_inplace is set to false.
+ */
+
+ tag = fdt_next_tag(fdt, prop_offset, &nextoffset);
+ if (tag == FDT_END)
+ return nextoffset;
+
+ /*
+ * Look at all tags related to the current property. I.e. tags after the
+ * current property and before either the next property, a sub-node or
+ * the end of current node
+ */
+ do {
+ offset = nextoffset;
+ tag = fdt_next_tag_(fdt, offset, &nextoffset, &is_unknown);
+ if (tag == FDT_END)
+ return nextoffset;
+
+ /*
+ * Unknown tags are returned as NOP. Force FDT_NOP to be really
+ * present in the area to remove the unknown tag and its related
+ * data. Also, as a tag is removed, downgrade the dtb version
+ * if asked for.
+ */
+ if (tag == FDT_NOP) {
+ if (is_unknown) {
+ if (downgrade_version)
+ fdt_downgrade_version(fdt);
+ fdt_nopify_area(fdt, offset, nextoffset);
+ }
+ }
+
+ } while ((tag != FDT_PROP) && (tag != FDT_BEGIN_NODE) &&
+ (tag != FDT_END_NODE));
+
+ return 0;
+}
+
static int fdt_resize_property_(void *fdt, int nodeoffset,
const char *name, int namelen,
int len, struct fdt_property **prop)
{
+ int prop_offset;
int oldlen;
int err;
@@ -209,6 +268,15 @@ static int fdt_resize_property_(void *fdt, int nodeoffset,
if (!*prop)
return oldlen;
+ /*
+ * The property is resized. Remove possible unknown tags related to the
+ * property downgrading the dtb version.
+ */
+ prop_offset = fdt_ptr_offset_(fdt, *prop);
+ err = fdt_prop_remove_unknown_tags(fdt, false, prop_offset, true);
+ if (err)
+ return err;
+
if ((err = fdt_splice_struct_(fdt, (*prop)->data, FDT_TAGALIGN(oldlen),
FDT_TAGALIGN(len))))
return err;
@@ -217,6 +285,29 @@ static int fdt_resize_property_(void *fdt, int nodeoffset,
return 0;
}
+static int fdt_node_skip_unknown_tags(void *fdt, int next)
+{
+ int nextoffset = next;
+ int offset;
+ uint32_t tag;
+
+ /*
+ * Skip all tags related to the current node. I.e. tags after the
+ * current node and before either the next property, a sub-node or the
+ * end of current node.
+ */
+ do {
+ offset = nextoffset;
+ tag = fdt_next_tag(fdt, offset, &nextoffset);
+ if (tag == FDT_END)
+ return nextoffset;
+
+ } while ((tag != FDT_PROP) && (tag != FDT_BEGIN_NODE) &&
+ (tag != FDT_END_NODE));
+
+ return offset;
+}
+
static int fdt_add_property_(void *fdt, int nodeoffset, const char *name,
int namelen, int len, struct fdt_property **prop)
{
@@ -235,6 +326,15 @@ static int fdt_add_property_(void *fdt, int nodeoffset, const char *name,
if ((nextoffset = fdt_check_node_offset_(fdt, nodeoffset)) < 0)
return nextoffset;
+ /*
+ * nextoffset it at the first tag after the node.
+ * Skip possible unknown tags related to the node in order to add the
+ * property after those tags.
+ */
+ nextoffset = fdt_node_skip_unknown_tags(fdt, nextoffset);
+ if (nextoffset < 0)
+ return nextoffset;
+
namestroff = fdt_find_add_string_(fdt, name, namelen, &allocated);
if (namestroff < 0)
return namestroff;
@@ -333,11 +433,22 @@ int fdt_appendprop(void *fdt, int nodeoffset, const char *name,
{
struct fdt_property *prop;
int err, oldlen, newlen;
+ int prop_offset;
FDT_RW_PROBE(fdt);
prop = fdt_get_property_w(fdt, nodeoffset, name, &oldlen);
if (prop) {
+ /*
+ * The property is going to be modified. Remove possible unknown
+ * tags related to this property downgrading the dtb version.
+ */
+ prop_offset = fdt_ptr_offset_(fdt, prop);
+ err = fdt_prop_remove_unknown_tags(fdt, false, prop_offset,
+ true);
+ if (err)
+ return err;
+
newlen = len + oldlen;
err = fdt_splice_struct_(fdt, prop->data,
FDT_TAGALIGN(oldlen),
@@ -360,6 +471,8 @@ int fdt_delprop(void *fdt, int nodeoffset, const char *name)
{
struct fdt_property *prop;
int len, proplen;
+ int prop_offset;
+ int err;
FDT_RW_PROBE(fdt);
@@ -367,6 +480,15 @@ int fdt_delprop(void *fdt, int nodeoffset, const char *name)
if (!prop)
return len;
+ /*
+ * The property is going to be removed. Remove also possible unknown
+ * tags related to this property. Keep the dtb version unchanged.
+ */
+ prop_offset = fdt_ptr_offset_(fdt, prop);
+ err = fdt_prop_remove_unknown_tags(fdt, false, prop_offset, false);
+ if (err)
+ return err;
+
proplen = sizeof(*prop) + FDT_TAGALIGN(len);
return fdt_splice_struct_(fdt, prop, proplen, 0);
}
@@ -395,7 +517,12 @@ int fdt_add_subnode_namelen(void *fdt, int parentoffset,
else if (offset != -FDT_ERR_NOTFOUND)
return offset;
- /* Try to place the new node after the parent's properties */
+ /*
+ * Try to place the new node after the parent's properties and unknown
+ * tags related to those properties.
+ * Unknown tags are reported as FDT_NOP tags by fdt_next_tag.
+ * Skipping FDT_NOP tags will correctly skip unknown tags.
+ */
tag = fdt_next_tag(fdt, parentoffset, &nextoffset);
/* the fdt_subnode_offset_namelen() should ensure this never hits */
if (!can_assume(LIBFDT_FLAWLESS) && (tag != FDT_BEGIN_NODE))
diff --git a/libfdt/fdt_wip.c b/libfdt/fdt_wip.c
index c2d7566a..7ca3ffbc 100644
--- a/libfdt/fdt_wip.c
+++ b/libfdt/fdt_wip.c
@@ -15,17 +15,30 @@ int fdt_setprop_inplace_namelen_partial(void *fdt, int nodeoffset,
uint32_t idx, const void *val,
int len)
{
+ int prop_offset;
void *propval;
int proplen;
+ int err;
- propval = fdt_getprop_namelen_w(fdt, nodeoffset, name, namelen,
- &proplen);
+ prop_offset = fdt_getprop_offset_namelen(fdt, nodeoffset, name, namelen);
+ if (prop_offset < 0)
+ return prop_offset;
+
+ propval = fdt_getprop_by_offset_w(fdt, prop_offset, NULL, &proplen);
if (!propval)
return proplen;
if ((unsigned)proplen < (len + idx))
return -FDT_ERR_NOSPACE;
+ /*
+ * Remove unknown tags related to the property downgrading the dtb
+ * version.
+ */
+ err = fdt_prop_remove_unknown_tags(fdt, true, prop_offset, true);
+ if (err)
+ return err;
+
memcpy((char *)propval + idx, val, len);
return 0;
}
@@ -59,12 +72,23 @@ static void fdt_nop_region_(void *start, int len)
int fdt_nop_property(void *fdt, int nodeoffset, const char *name)
{
struct fdt_property *prop;
+ int prop_offset;
int len;
+ int err;
prop = fdt_get_property_w(fdt, nodeoffset, name, &len);
if (!prop)
return len;
+ /*
+ * The property is going to be removed (nopified). Remove unknown tags
+ * related to this property. Keep the dtb version unchanged.
+ */
+ prop_offset = fdt_ptr_offset_(fdt, prop);
+ err = fdt_prop_remove_unknown_tags(fdt, true, prop_offset, false);
+ if (err)
+ return err;
+
fdt_nop_region_(prop, len + sizeof(*prop));
return 0;
diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
index e3923629..ce128fda 100644
--- a/libfdt/libfdt_internal.h
+++ b/libfdt/libfdt_internal.h
@@ -26,6 +26,9 @@ uint32_t fdt_next_tag_(const void *fdt, int startoffset, int *nextoffset,
int fdt_check_node_offset_(const void *fdt, int offset);
int fdt_check_prop_offset_(const void *fdt, int offset);
+int fdt_prop_remove_unknown_tags(void *fdt, bool force_inplace,
+ int prop_offset, bool downgrade_version);
+
int fdt_getprop_offset_namelen(const void *fdt, int nodeoffset,
const char *name, int namelen);
static inline int fdt_getprop_offset(const void *fdt, int nodeoffset,
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 419a24d8..980ed6a0 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -586,6 +586,34 @@ libfdt_tests () {
unknown_tags_no_skip.dtb; do
run_test check_full -n $bad
done
+
+ # Check inplace modification with "unknown" tags that can be skipped
+ dtb=unknown_tags_can_skip.wip.test.dtb
+ cp unknown_tags_can_skip.dtb $dtb
+ base_run_test wrap_fdtdump $dtb $dtb.0.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.0.out
+ base_run_test check_diff $dtb.0.out "$SRCDIR/$dtb.0.expect"
+
+ run_test wip_func $dtb set_prop / prop-str 0 "vwxy"
+ base_run_test wrap_fdtdump $dtb $dtb.1.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.1.out
+ base_run_test check_diff $dtb.1.out "$SRCDIR/$dtb.1.expect"
+
+ cp unknown_tags_can_skip.dtb $dtb
+ run_test wip_func $dtb nop_prop /subnode2 prop-int1
+ base_run_test wrap_fdtdump $dtb $dtb.2.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.2.out
+ base_run_test check_diff $dtb.2.out "$SRCDIR/$dtb.2.expect"
+
+ cp unknown_tags_can_skip.dtb $dtb
+ run_test wip_func $dtb nop_node /subnode2/subsubnode
+ base_run_test wrap_fdtdump $dtb $dtb.3.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.3.out
+ base_run_test check_diff $dtb.3.out "$SRCDIR/$dtb.3.expect"
}
dtc_tests () {
@@ -1045,6 +1073,56 @@ fdtput_tests () {
run_wrap_error_test $DTPUT $dtb -d /chosen non-existent-prop
# TODO: Add tests for verbose mode?
+
+ # Modify a dtb containing some "unknown" tags that can be skipped
+ dtb=unknown_tags_can_skip.fdtput.test.dtb
+ cp unknown_tags_can_skip.dtb $dtb
+ base_run_test wrap_fdtdump $dtb $dtb.0.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.0.out
+ base_run_test check_diff $dtb.0.out "$SRCDIR/$dtb.0.expect"
+
+ run_fdtput_test "vwxyz" $dtb / prop-str -ts "vwxyz"
+ base_run_test wrap_fdtdump $dtb $dtb.1.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.1.out
+ base_run_test check_diff $dtb.1.out "$SRCDIR/$dtb.1.expect"
+
+ cp unknown_tags_can_skip.dtb $dtb
+ run_wrap_test $DTPUT $dtb -c /tst-fdtput
+ base_run_test wrap_fdtdump $dtb $dtb.2.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.2.out
+ base_run_test check_diff $dtb.2.out "$SRCDIR/$dtb.2.expect"
+ run_wrap_test $DTPUT $dtb -c /tst-fdtput/n1 /tst-fdtput/n2 /tst-fdtput/n3
+ run_wrap_test $DTPUT $dtb -r /tst-fdtput/n1 /tst-fdtput/n3
+ run_fdtget_test "n2" $dtb -l /tst-fdtput
+ base_run_test wrap_fdtdump $dtb $dtb.3.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.3.out
+ base_run_test check_diff $dtb.3.out "$SRCDIR/$dtb.3.expect"
+
+ cp unknown_tags_can_skip.dtb $dtb
+ run_wrap_test $DTPUT $dtb -d / prop-str
+ run_fdtget_test "prop-int" $dtb -p /
+ base_run_test wrap_fdtdump $dtb $dtb.4.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.4.out
+ base_run_test check_diff $dtb.4.out "$SRCDIR/$dtb.4.expect"
+
+ cp unknown_tags_can_skip.dtb $dtb
+ run_wrap_test $DTPUT $dtb /subnode2 prop-tst-fdtput -ts "Test fdtput"
+ base_run_test wrap_fdtdump $dtb $dtb.5.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.5.out
+ base_run_test check_diff $dtb.5.out "$SRCDIR/$dtb.5.expect"
+
+ cp unknown_tags_can_skip.dtb $dtb
+ run_wrap_test $DTPUT $dtb -r /subnode2/subsubnode
+ base_run_test wrap_fdtdump $dtb $dtb.6.out
+ # Remove unneeded header fields (keep those related to versions)
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.6.out
+ base_run_test check_diff $dtb.6.out "$SRCDIR/$dtb.6.expect"
}
utilfdt_tests () {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect
new file mode 100644
index 00000000..75883593
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect
@@ -0,0 +1,31 @@
+/dts-v1/;
+// version: 4294967295
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect
new file mode 100644
index 00000000..b4d3ae29
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect
@@ -0,0 +1,35 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "vwxyz";
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect
new file mode 100644
index 00000000..a196bed3
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect
@@ -0,0 +1,33 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ tst-fdtput {
+ };
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect
new file mode 100644
index 00000000..52faa1dd
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect
@@ -0,0 +1,35 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ tst-fdtput {
+ n2 {
+ };
+ };
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect
new file mode 100644
index 00000000..1ddc694b
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect
@@ -0,0 +1,34 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect
new file mode 100644
index 00000000..f955ac1c
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect
@@ -0,0 +1,32 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-tst-fdtput = "Test fdtput";
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect
new file mode 100644
index 00000000..59247478
--- /dev/null
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect
@@ -0,0 +1,27 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.0.expect b/tests/unknown_tags_can_skip.wip.test.dtb.0.expect
new file mode 100644
index 00000000..75883593
--- /dev/null
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.0.expect
@@ -0,0 +1,31 @@
+/dts-v1/;
+// version: 4294967295
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.1.expect b/tests/unknown_tags_can_skip.wip.test.dtb.1.expect
new file mode 100644
index 00000000..2a0dd4a0
--- /dev/null
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.1.expect
@@ -0,0 +1,35 @@
+/dts-v1/;
+// version: 17
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "vwxy";
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.2.expect b/tests/unknown_tags_can_skip.wip.test.dtb.2.expect
new file mode 100644
index 00000000..bc08885b
--- /dev/null
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.2.expect
@@ -0,0 +1,37 @@
+/dts-v1/;
+// version: 4294967295
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ prop-int2 = <0x00032022>;
+ subsubnode {
+ // Unknown tag ignored: 0xe0000000, data len 8 0000123000001231
+ prop-bool;
+ };
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.3.expect b/tests/unknown_tags_can_skip.wip.test.dtb.3.expect
new file mode 100644
index 00000000..aa6e9394
--- /dev/null
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.3.expect
@@ -0,0 +1,38 @@
+/dts-v1/;
+// version: 4294967295
+// last_comp_version: 16
+
+// Unknown tag ignored: 0xd0000000, data len 4 00000001
+/ {
+ // Unknown tag ignored: 0xc0000000, data len 0
+ prop-int = <0x00003201>;
+ // Unknown tag ignored: 0xd0000000, data len 4 00000110
+ prop-str = "abcd";
+ // Unknown tag ignored: 0xe0000000, data len 8 0000012000000121
+ // Unknown tag ignored: 0xf0000000, data len 3 101112
+ subnode1 {
+ prop-int = <0x00006401 0x00006402>;
+ // Unknown tag ignored: 0xc0000000, data len 0
+ };
+ subnode2 {
+ // Unknown tag ignored: 0xd0000000, data len 4 00000121
+ prop-int1 = <0x00064020 0x00064021>;
+ // Unknown tag ignored: 0xe0000000, data len 8 0000122000001221
+ prop-int2 = <0x00032022>;
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // [NOP]
+ // Unknown tag ignored: 0xf0000000, data len 3 212223
+ };
+ // Unknown tag ignored: 0xf0000000, data len 4 31323334
+};
+// Unknown tag ignored: 0xd0000000, data len 4 00000002
+// Unknown tag ignored: 0xf0000000, data len 2 4041
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v3 15/15] Introduce v18 dtb version
2026-08-26 8:31 [PATCH v3 00/15] Add support for structured tags and v18 dtb version Herve Codina
` (13 preceding siblings ...)
2026-08-26 8:31 ` [PATCH v3 14/15] libfdt: Handle unknown tags on dtb modifications Herve Codina
@ 2026-08-26 8:31 ` Herve Codina
14 siblings, 0 replies; 16+ messages in thread
From: Herve Codina @ 2026-08-26 8:31 UTC (permalink / raw)
To: David Gibson, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Laurent Pinchart, David Lechner, Ayush Singh, Geert Uytterhoeven,
devicetree-compiler, devicetree, linux-kernel, devicetree-spec,
Hui Pu, Ian Ray, Luca Ceresoli, Thomas Petazzoni, Herve Codina,
Frank Li
This v18 version will add support for
- Structured tags.
Those tags value definition will allow "old" libfdt, dtc and other
tools to skip unknown tags if encountered in future dtb version.
libfdt, dtc and other tools implementing version v18 will be able to
skip unknown tags available in dtbd generated with later version of
dtc.
- dt_flags header field.
For now this flag field is set to 0. It is a placeholder for future
dtb version and could be used to store some dtb related information
such as the kind of dtb. For instance, the future addons format will
use this field to clearly identify that the dtb is an addon dtb.
- last_comp_version_w header field.
This field is similar to last_comp_version but for writing.
It contains the lowest version of the devicetree data structure with
which the version used can safely perform modifications (taking into
account following rules related to unknown tags).
If this lowest version is greater than the last known supported
version, modification are simply forbidden and lead to a
FDT_ERR_BADVERSION error.
For modification, when an unknown tag that can be skipped is involved
and last_comp_version_w allows modifications, the following rules
apply:
- When a property is modified, tags related to this property are
removed and the dtb version is downgraded.
- When a property is removed, tags related to this property are
obviously removed. The dtb version is kept unchanged.
- When a property or a node is added, obviously no unknown tags are
added and the dtb version is kept unchanged.
- When a node is removed, tags related to this node are obviously
removed. The dtb version is kept unchanged.
- Adding, removing or modifying a property is not considered as a node
modification and so, those operations have no impacts on unknown
tags related to the node. Those node related tags are kept
unchanged.
- The only modification considered as a node modification is setting
its name. We consider that this operation has no impact on tags
related to the node. Here also, those node related tags and the dtb
version are kept unchanged.
- Global (dtb related) unknown tags are kept unchanged regardless the
modification done.
In all cases, if unknown tags are not involved in a modification, the
dtb version is not downgraded when the modification is made.
It is worth noting that with this v18 version, the dtb version is not
downgraded for any modification but only when unknown tags are removed
due to a property modification. In v17 or older version any modification
led to a dtb version downgrade.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
dtc.h | 2 +-
fdtdump.c | 8 ++-
flattree.c | 37 ++++++++++---
libfdt/fdt.h | 5 ++
libfdt/fdt_rw.c | 20 +++++--
libfdt/fdt_sw.c | 3 ++
libfdt/libfdt.h | 7 ++-
pylibfdt/libfdt.i | 18 +++++++
tests/Makefile.tests | 2 +-
tests/dtflags_default.dtb.expect | 1 +
tests/dtflags_default.dts | 10 ++++
tests/meson.build | 1 +
tests/pylibfdt_tests.py | 10 ++--
tests/run_tests.sh | 42 ++++++++++-----
tests/testutils.c | 2 +-
tests/treegen.c | 53 +++++++++++++++++--
...own_tags_can_skip.fdtput.test.dtb.0.expect | 1 +
...own_tags_can_skip.fdtput.test.dtb.1.expect | 3 +-
...own_tags_can_skip.fdtput.test.dtb.2.expect | 3 +-
...own_tags_can_skip.fdtput.test.dtb.3.expect | 3 +-
...own_tags_can_skip.fdtput.test.dtb.4.expect | 3 +-
...own_tags_can_skip.fdtput.test.dtb.5.expect | 3 +-
...own_tags_can_skip.fdtput.test.dtb.6.expect | 3 +-
...nknown_tags_can_skip.wip.test.dtb.0.expect | 1 +
...nknown_tags_can_skip.wip.test.dtb.1.expect | 3 +-
...nknown_tags_can_skip.wip.test.dtb.2.expect | 1 +
...nknown_tags_can_skip.wip.test.dtb.3.expect | 1 +
27 files changed, 202 insertions(+), 44 deletions(-)
create mode 100644 tests/dtflags_default.dtb.expect
create mode 100644 tests/dtflags_default.dts
diff --git a/dtc.h b/dtc.h
index 473552eb..f0c2cde6 100644
--- a/dtc.h
+++ b/dtc.h
@@ -29,7 +29,7 @@
#define debug(...)
#endif
-#define DEFAULT_FDT_VERSION 17
+#define DEFAULT_FDT_VERSION 18
/*
* Command line options
diff --git a/fdtdump.c b/fdtdump.c
index 7a8b2784..5994e1d7 100644
--- a/fdtdump.c
+++ b/fdtdump.c
@@ -18,7 +18,7 @@
#include "util.h"
#define FDT_MAGIC_SIZE 4
-#define MAX_VERSION 17U
+#define MAX_VERSION 18U
#define ALIGN(x, a) (((x) + ((a) - 1)) & ~((a) - 1))
#define PALIGN(p, a) ((void *)(ALIGN((uintptr_t)(p), (a))))
@@ -86,6 +86,12 @@ static void dump_blob(void *blob, bool debug, int dump_unknown)
if (version >= 17)
printf("// size_dt_struct:\t0x%"PRIx32"\n",
fdt32_to_cpu(bph->size_dt_struct));
+ if (version >= 18) {
+ printf("// dt_flags:\t\t0x%"PRIx32"\n",
+ fdt32_to_cpu(bph->dt_flags));
+ printf("// last_comp_version_w:\t%"PRIu32"\n",
+ fdt32_to_cpu(bph->last_comp_version_w));
+ }
printf("\n");
for (i = 0; ; i++) {
diff --git a/flattree.c b/flattree.c
index 88dbfa7e..ff57fc5d 100644
--- a/flattree.c
+++ b/flattree.c
@@ -13,23 +13,29 @@
#define FTF_STRTABSIZE 0x10
#define FTF_STRUCTSIZE 0x20
#define FTF_NOPS 0x40
+#define FTF_DTFLAGS 0x80
+#define FTF_LCVERSW 0x100
static struct version_info {
int version;
int last_comp_version;
+ int last_comp_version_w;
int hdr_size;
int flags;
} version_table[] = {
- {1, 1, FDT_V1_SIZE,
+ {1, 1, 0, FDT_V1_SIZE,
FTF_FULLPATH|FTF_VARALIGN|FTF_NAMEPROPS},
- {2, 1, FDT_V2_SIZE,
+ {2, 1, 0, FDT_V2_SIZE,
FTF_FULLPATH|FTF_VARALIGN|FTF_NAMEPROPS|FTF_BOOTCPUID},
- {3, 1, FDT_V3_SIZE,
+ {3, 1, 0, FDT_V3_SIZE,
FTF_FULLPATH|FTF_VARALIGN|FTF_NAMEPROPS|FTF_BOOTCPUID|FTF_STRTABSIZE},
- {16, 16, FDT_V3_SIZE,
+ {16, 16, 0, FDT_V3_SIZE,
FTF_BOOTCPUID|FTF_STRTABSIZE|FTF_NOPS},
- {17, 16, FDT_V17_SIZE,
+ {17, 16, 0, FDT_V17_SIZE,
FTF_BOOTCPUID|FTF_STRTABSIZE|FTF_STRUCTSIZE|FTF_NOPS},
+ {18, 16, 17, FDT_V18_SIZE,
+ FTF_BOOTCPUID|FTF_STRTABSIZE|FTF_STRUCTSIZE|FTF_NOPS|FTF_DTFLAGS|
+ FTF_LCVERSW},
};
struct emitter {
@@ -314,7 +320,7 @@ static struct data flatten_reserve_list(struct reserve_info *reservelist,
static void make_fdt_header(struct fdt_header *fdt,
struct version_info *vi,
int reservesize, int dtsize, int strsize,
- int boot_cpuid_phys)
+ int boot_cpuid_phys, uint32_t dt_flags)
{
int reserve_off;
@@ -341,6 +347,10 @@ static void make_fdt_header(struct fdt_header *fdt,
fdt->size_dt_strings = cpu_to_fdt32(strsize);
if (vi->flags & FTF_STRUCTSIZE)
fdt->size_dt_struct = cpu_to_fdt32(dtsize);
+ if (vi->flags & FTF_DTFLAGS)
+ fdt->dt_flags = cpu_to_fdt32(dt_flags);
+ if (vi->flags & FTF_LCVERSW)
+ fdt->last_comp_version_w = cpu_to_fdt32(vi->last_comp_version_w);
}
void dt_to_blob(FILE *f, struct dt_info *dti, int version)
@@ -368,7 +378,7 @@ void dt_to_blob(FILE *f, struct dt_info *dti, int version)
/* Make header */
make_fdt_header(&fdt, vi, reservebuf.len, dtbuf.len, strbuf.len,
- dti->boot_cpuid_phys);
+ dti->boot_cpuid_phys, 0);
/*
* If the user asked for more space than is used, adjust the totalsize.
@@ -499,6 +509,16 @@ void dt_to_asm(FILE *f, struct dt_info *dti, int version)
symprefix, symprefix);
}
+ if (vi->flags & FTF_DTFLAGS) {
+ fprintf(f, "\t/* dt_flags */\n");
+ asm_emit_cell(f, 0);
+ }
+
+ if (vi->flags & FTF_LCVERSW) {
+ fprintf(f, "\t/* last_comp_version_w */\n");
+ asm_emit_cell(f, vi->last_comp_version_w);
+ }
+
/*
* Reserve map entries.
* Align the reserve map to a doubleword boundary.
@@ -955,6 +975,9 @@ struct dt_info *dt_from_blob(const char *fname)
flags |= FTF_NOPS;
}
+ if (version >= 18)
+ flags |= FTF_DTFLAGS | FTF_LCVERSW;
+
inbuf_init(&memresvbuf,
blob + off_mem_rsvmap, blob + totalsize);
inbuf_init(&dtbuf, blob + off_dt, blob + totalsize);
diff --git a/libfdt/fdt.h b/libfdt/fdt.h
index f41a355f..a43b85c1 100644
--- a/libfdt/fdt.h
+++ b/libfdt/fdt.h
@@ -26,6 +26,10 @@ struct fdt_header {
/* version 17 fields below */
fdt32_t size_dt_struct; /* size of the structure block */
+
+ /* version 18 fields below */
+ fdt32_t dt_flags; /* Ored value of FDT_FLAG_XXXX */
+ fdt32_t last_comp_version_w; /* last compatible version for writing */
};
struct fdt_reserve_entry {
@@ -85,5 +89,6 @@ struct fdt_property {
#define FDT_V3_SIZE (FDT_V2_SIZE + sizeof(fdt32_t))
#define FDT_V16_SIZE FDT_V3_SIZE
#define FDT_V17_SIZE (FDT_V16_SIZE + sizeof(fdt32_t))
+#define FDT_V18_SIZE (FDT_V17_SIZE + 2 * sizeof(fdt32_t))
#endif /* FDT_H */
diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c
index 87776609..005efde8 100644
--- a/libfdt/fdt_rw.c
+++ b/libfdt/fdt_rw.c
@@ -34,13 +34,17 @@ static int fdt_rw_probe_(void *fdt)
return 0;
FDT_RO_PROBE(fdt);
- if (!can_assume(LATEST) && fdt_version(fdt) < 17)
- return -FDT_ERR_BADVERSION;
+ if (!can_assume(LATEST)) {
+ if (fdt_version(fdt) < 17)
+ return -FDT_ERR_BADVERSION;
+ else if (fdt_version(fdt) >= 18 &&
+ fdt_last_comp_version_w(fdt) > FDT_LAST_SUPPORTED_VERSION)
+ return -FDT_ERR_BADVERSION;
+ }
if (fdt_blocks_misordered_(fdt, sizeof(struct fdt_reserve_entry),
fdt_size_dt_struct(fdt)))
return -FDT_ERR_BADLAYOUT;
- fdt_downgrade_version(fdt);
return 0;
}
@@ -624,7 +628,11 @@ int fdt_open_into(const void *fdt, void *buf, int bufsize)
err = fdt_move(fdt, buf, bufsize);
if (err)
return err;
- fdt_set_version(buf, 17);
+ if (can_assume(LATEST) || fdt_version(fdt) < 18) {
+ fdt_set_version(buf, 18);
+ fdt_set_dt_flags(buf, 0);
+ fdt_set_last_comp_version_w(buf, 17);
+ }
fdt_set_size_dt_struct(buf, struct_size);
fdt_set_totalsize(buf, bufsize);
return 0;
@@ -653,8 +661,10 @@ int fdt_open_into(const void *fdt, void *buf, int bufsize)
fdt_set_magic(buf, FDT_MAGIC);
fdt_set_totalsize(buf, bufsize);
- fdt_set_version(buf, 17);
+ fdt_set_version(buf, 18);
fdt_set_last_comp_version(buf, 16);
+ fdt_set_dt_flags(buf, 0);
+ fdt_set_last_comp_version_w(buf, 17);
fdt_set_boot_cpuid_phys(buf, fdt_boot_cpuid_phys(fdt));
return 0;
diff --git a/libfdt/fdt_sw.c b/libfdt/fdt_sw.c
index 96d4cf57..caafd60a 100644
--- a/libfdt/fdt_sw.c
+++ b/libfdt/fdt_sw.c
@@ -137,6 +137,9 @@ int fdt_create_with_flags(void *buf, int bufsize, uint32_t flags)
fdt_set_off_dt_struct(fdt, fdt_off_mem_rsvmap(fdt));
fdt_set_off_dt_strings(fdt, 0);
+ fdt_set_dt_flags(fdt, 0);
+ fdt_set_last_comp_version_w(fdt, FDT_LAST_COMPATIBLE_VERSION_W);
+
return 0;
}
diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
index 82965e32..8e99e644 100644
--- a/libfdt/libfdt.h
+++ b/libfdt/libfdt.h
@@ -15,7 +15,8 @@ extern "C" {
#define FDT_FIRST_SUPPORTED_VERSION 0x02
#define FDT_LAST_COMPATIBLE_VERSION 0x10
-#define FDT_LAST_SUPPORTED_VERSION 0x11
+#define FDT_LAST_COMPATIBLE_VERSION_W 0x11
+#define FDT_LAST_SUPPORTED_VERSION 0x12
/* Error codes: informative error codes */
#define FDT_ERR_NOTFOUND 1
@@ -284,6 +285,8 @@ int fdt_next_subnode(const void *fdt, int offset);
#define fdt_boot_cpuid_phys(fdt) (fdt_get_header(fdt, boot_cpuid_phys))
#define fdt_size_dt_strings(fdt) (fdt_get_header(fdt, size_dt_strings))
#define fdt_size_dt_struct(fdt) (fdt_get_header(fdt, size_dt_struct))
+#define fdt_dt_flags(fdt) (fdt_get_header(fdt, dt_flags))
+#define fdt_last_comp_version_w(fdt) (fdt_get_header(fdt, last_comp_version_w))
#define fdt_set_hdr_(name) \
static inline void fdt_set_##name(void *fdt, uint32_t val) \
@@ -301,6 +304,8 @@ fdt_set_hdr_(last_comp_version)
fdt_set_hdr_(boot_cpuid_phys)
fdt_set_hdr_(size_dt_strings)
fdt_set_hdr_(size_dt_struct)
+fdt_set_hdr_(dt_flags)
+fdt_set_hdr_(last_comp_version_w)
#undef fdt_set_hdr_
/**
diff --git a/pylibfdt/libfdt.i b/pylibfdt/libfdt.i
index b41c03f4..462fe28a 100644
--- a/pylibfdt/libfdt.i
+++ b/pylibfdt/libfdt.i
@@ -281,6 +281,22 @@ class FdtRo(object):
"""
return fdt_size_dt_struct(self._fdt)
+ def dt_flags(self):
+ """Return flags from the header
+
+ Returns:
+ flags value from the header
+ """
+ return fdt_dt_flags(self._fdt)
+
+ def last_comp_version_w(self):
+ """Return the last compatible version for writing of the device tree
+
+ Returns:
+ Last compatible version number for writing of the device tree
+ """
+ return fdt_last_comp_version_w(self._fdt)
+
def num_mem_rsv(self, quiet=()):
"""Return the number of memory reserve-map records
@@ -1287,6 +1303,8 @@ uint32_t fdt_last_comp_version(const void *fdt);
uint32_t fdt_boot_cpuid_phys(const void *fdt);
uint32_t fdt_size_dt_strings(const void *fdt);
uint32_t fdt_size_dt_struct(const void *fdt);
+uint32_t fdt_dt_flags(const void *fdt);
+uint32_t fdt_last_comp_version_w(const void *fdt);
int fdt_property_string(void *fdt, const char *name, const char *val);
int fdt_property_cell(void *fdt, const char *name, uint32_t val);
diff --git a/tests/Makefile.tests b/tests/Makefile.tests
index a71c4cbf..857e4899 100644
--- a/tests/Makefile.tests
+++ b/tests/Makefile.tests
@@ -46,7 +46,7 @@ TESTS_TREES_L = test_tree1.dtb bad_node_char.dtb bad_node_format.dtb \
bad_prop_char.dtb ovf_size_strings.dtb truncated_property.dtb \
truncated_string.dtb truncated_memrsv.dtb unterminated_memrsv.dtb \
two_roots.dtb named_root.dtb unknown_tags_can_skip.dtb \
- unknown_tags_no_skip.dtb
+ unknown_tags_no_skip.dtb last_comp_version_w_future.dtb
TESTS_TREES = $(TESTS_TREES_L:%=$(TESTS_PREFIX)%)
TESTS_TARGETS = $(TESTS) $(TESTS_TREES)
diff --git a/tests/dtflags_default.dtb.expect b/tests/dtflags_default.dtb.expect
new file mode 100644
index 00000000..cefed4d6
--- /dev/null
+++ b/tests/dtflags_default.dtb.expect
@@ -0,0 +1 @@
+// dt_flags: 0x0
diff --git a/tests/dtflags_default.dts b/tests/dtflags_default.dts
new file mode 100644
index 00000000..3ef867e8
--- /dev/null
+++ b/tests/dtflags_default.dts
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+/*
+ * Copyright (C) 2026 Bootlin
+ */
+
+/dts-v1/;
+
+/ {
+ prop = <1>;
+};
diff --git a/tests/meson.build b/tests/meson.build
index e7a88936..fcc73982 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -19,6 +19,7 @@ treegen_dtb = custom_target(
'named_root.dtb',
'unknown_tags_can_skip.dtb',
'unknown_tags_no_skip.dtb',
+ 'last_comp_version_w_future.dtb',
]
)
diff --git a/tests/pylibfdt_tests.py b/tests/pylibfdt_tests.py
index 0e166075..c3aaf00f 100644
--- a/tests/pylibfdt_tests.py
+++ b/tests/pylibfdt_tests.py
@@ -274,14 +274,16 @@ class PyLibfdtBasicTests(unittest.TestCase):
"""Test that we can access the header values"""
self.assertEqual(self.fdt.magic(), 0xd00dfeed)
self.assertEqual(self.fdt.totalsize(), len(self.fdt._fdt))
- self.assertEqual(self.fdt.off_dt_struct(), 88)
- self.assertEqual(self.fdt.off_dt_strings(), 652)
- self.assertEqual(self.fdt.off_mem_rsvmap(), 40)
- self.assertEqual(self.fdt.version(), 17)
+ self.assertEqual(self.fdt.off_dt_struct(), 96)
+ self.assertEqual(self.fdt.off_dt_strings(), 660)
+ self.assertEqual(self.fdt.off_mem_rsvmap(), 48)
+ self.assertEqual(self.fdt.version(), 18)
self.assertEqual(self.fdt.last_comp_version(), 16)
self.assertEqual(self.fdt.boot_cpuid_phys(), 0)
self.assertEqual(self.fdt.size_dt_strings(), 105)
self.assertEqual(self.fdt.size_dt_struct(), 564)
+ self.assertEqual(self.fdt.dt_flags(), 0)
+ self.assertEqual(self.fdt.last_comp_version_w(), 17)
def testPack(self):
"""Test that we can pack the tree after deleting something"""
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 980ed6a0..42b74e05 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -578,7 +578,8 @@ libfdt_tests () {
run_test dtbs_equal_ordered cell-overflow.test.dtb cell-overflow-results.test.dtb
# check full tests
- for good in test_tree1.dtb unknown_tags_can_skip.dtb; do
+ for good in test_tree1.dtb unknown_tags_can_skip.dtb \
+ last_comp_version_w_future.dtb; do
run_test check_full $good
done
for bad in truncated_property.dtb truncated_string.dtb \
@@ -592,27 +593,27 @@ libfdt_tests () {
cp unknown_tags_can_skip.dtb $dtb
base_run_test wrap_fdtdump $dtb $dtb.0.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.0.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.0.out
base_run_test check_diff $dtb.0.out "$SRCDIR/$dtb.0.expect"
run_test wip_func $dtb set_prop / prop-str 0 "vwxy"
base_run_test wrap_fdtdump $dtb $dtb.1.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.1.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.1.out
base_run_test check_diff $dtb.1.out "$SRCDIR/$dtb.1.expect"
cp unknown_tags_can_skip.dtb $dtb
run_test wip_func $dtb nop_prop /subnode2 prop-int1
base_run_test wrap_fdtdump $dtb $dtb.2.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.2.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.2.out
base_run_test check_diff $dtb.2.out "$SRCDIR/$dtb.2.expect"
cp unknown_tags_can_skip.dtb $dtb
run_test wip_func $dtb nop_node /subnode2/subsubnode
base_run_test wrap_fdtdump $dtb $dtb.3.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.3.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.3.out
base_run_test check_diff $dtb.3.out "$SRCDIR/$dtb.3.expect"
}
@@ -917,6 +918,14 @@ dtc_tests () {
run_dtc_test -I dtb -O dts -o unknown_tags_can_skip.dtb.dts unknown_tags_can_skip.dtb
base_run_test check_diff unknown_tags_can_skip.dtb.dts "$SRCDIR/unknown_tags_can_skip.dtb.dts.expect"
run_wrap_error_test $DTC -I dtb -O dts -o unknown_tags_no_skip.dtb.dts unknown_tags_no_skip.dtb
+
+ # Tests dt_flags header field (default value)
+ run_dtc_test -I dts -O dtb -o dtflags_default.dtb "$SRCDIR/dtflags_default.dts"
+ base_run_test wrap_fdtdump dtflags_default.dtb dtflags_default.dtb.out
+ # Keep only lines containing 'dt_flags'
+ sed -i '/dt_flags/!d' dtflags_default.dtb.out
+ base_run_test check_diff dtflags_default.dtb.out "$SRCDIR/dtflags_default.dtb.expect"
+ run_test check_full dtflags_default.dtb
}
cmp_tests () {
@@ -1074,32 +1083,41 @@ fdtput_tests () {
# TODO: Add tests for verbose mode?
+ # Not allowed to modify a dtb due to last_comp_version_w
+ # FDT_ERR_BADVERSION error code is returned
+ dtb=last_comp_version_w_future.fdtput.test.dtb
+ cp last_comp_version_w_future.dtb $dtb
+ run_wrap_error_test $DTPUT $dtb /subnode prop-int -tu 123
+ run_wrap_error_test $DTPUT $dtb -d /subnode prop-int
+ run_wrap_error_test $DTPUT $dtb -c /new-node
+ run_wrap_error_test $DTPUT $dtb -r /subnode
+
# Modify a dtb containing some "unknown" tags that can be skipped
dtb=unknown_tags_can_skip.fdtput.test.dtb
cp unknown_tags_can_skip.dtb $dtb
base_run_test wrap_fdtdump $dtb $dtb.0.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.0.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.0.out
base_run_test check_diff $dtb.0.out "$SRCDIR/$dtb.0.expect"
run_fdtput_test "vwxyz" $dtb / prop-str -ts "vwxyz"
base_run_test wrap_fdtdump $dtb $dtb.1.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.1.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.1.out
base_run_test check_diff $dtb.1.out "$SRCDIR/$dtb.1.expect"
cp unknown_tags_can_skip.dtb $dtb
run_wrap_test $DTPUT $dtb -c /tst-fdtput
base_run_test wrap_fdtdump $dtb $dtb.2.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.2.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.2.out
base_run_test check_diff $dtb.2.out "$SRCDIR/$dtb.2.expect"
run_wrap_test $DTPUT $dtb -c /tst-fdtput/n1 /tst-fdtput/n2 /tst-fdtput/n3
run_wrap_test $DTPUT $dtb -r /tst-fdtput/n1 /tst-fdtput/n3
run_fdtget_test "n2" $dtb -l /tst-fdtput
base_run_test wrap_fdtdump $dtb $dtb.3.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.3.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.3.out
base_run_test check_diff $dtb.3.out "$SRCDIR/$dtb.3.expect"
cp unknown_tags_can_skip.dtb $dtb
@@ -1107,21 +1125,21 @@ fdtput_tests () {
run_fdtget_test "prop-int" $dtb -p /
base_run_test wrap_fdtdump $dtb $dtb.4.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.4.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.4.out
base_run_test check_diff $dtb.4.out "$SRCDIR/$dtb.4.expect"
cp unknown_tags_can_skip.dtb $dtb
run_wrap_test $DTPUT $dtb /subnode2 prop-tst-fdtput -ts "Test fdtput"
base_run_test wrap_fdtdump $dtb $dtb.5.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.5.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.5.out
base_run_test check_diff $dtb.5.out "$SRCDIR/$dtb.5.expect"
cp unknown_tags_can_skip.dtb $dtb
run_wrap_test $DTPUT $dtb -r /subnode2/subsubnode
base_run_test wrap_fdtdump $dtb $dtb.6.out
# Remove unneeded header fields (keep those related to versions)
- sed -i '/^\/.*\(magic\|off\|size\|cpu\)/d' $dtb.6.out
+ sed -i '/^\/.*\(magic\|off\|size\|cpu\|flags\)/d' $dtb.6.out
base_run_test check_diff $dtb.6.out "$SRCDIR/$dtb.6.expect"
}
diff --git a/tests/testutils.c b/tests/testutils.c
index d35a1978..7df80f7c 100644
--- a/tests/testutils.c
+++ b/tests/testutils.c
@@ -354,7 +354,7 @@ void *open_blob_rw(const void *blob)
{
int err;
void *buf;
- int newsize = fdt_totalsize(blob) + 8;
+ int newsize = fdt_totalsize(blob) + 8 + 2 * 4;
buf = xmalloc(newsize);
err = fdt_open_into(blob, buf, newsize);
diff --git a/tests/treegen.c b/tests/treegen.c
index f07c8963..b0730ef6 100644
--- a/tests/treegen.c
+++ b/tests/treegen.c
@@ -106,7 +106,8 @@ static void fill_prop_name(struct buf *b, size_t strs, size_t prop, size_t strof
/* FDT structure helpers */
static size_t emit_fdt_header_vers(struct buf *b, uint32_t version,
- uint32_t last_comp_version)
+ uint32_t last_comp_version,
+ uint32_t last_comp_version_w)
{
size_t off = emit_u32(b, FDT_MAGIC);
@@ -119,12 +120,14 @@ static size_t emit_fdt_header_vers(struct buf *b, uint32_t version,
emit_u32(b, 0); /* boot_cpuid_phys */
emit_u32(b, 0); /* size_dt_strings */
emit_u32(b, 0); /* size_dt_struct */
+ emit_u32(b, 0); /* dt_flags */
+ emit_u32(b, last_comp_version_w); /* last_comp_version_w */
return off;
}
static size_t emit_fdt_header(struct buf *b)
{
- return emit_fdt_header_vers(b, 0x11, 0x10);
+ return emit_fdt_header_vers(b, 0x12, 0x10, 0x11);
}
static void finish_rsvmap(struct buf *b, size_t hdr, size_t rsvmap)
@@ -720,7 +723,7 @@ static struct buf make_unknown_tags_can_skip(void)
size_t p_sn2_int1, p_sn2_int2;
size_t p_sn2ssn_bool;
- hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10);
+ hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10, 0x11);
emit_align(&b, 8);
emit_rsvmap_empty(&b, hdr);
@@ -833,7 +836,7 @@ static struct buf make_unknown_tags_no_skip(void)
size_t hdr;
size_t p_prop_u64;
- hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10);
+ hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10, 0x11);
emit_align(&b, 8);
emit_rsvmap_empty(&b, hdr);
@@ -867,6 +870,47 @@ static struct buf make_unknown_tags_no_skip(void)
return b;
}
+/* Tree with "unknown" tags that can be skipped
+ * Use a really future dtb version to check version downgrade on
+ * modification.
+ */
+static struct buf make_last_comp_version_w_future(void)
+{
+ struct buf b = buf_init();
+ size_t hdr;
+ size_t p_int;
+
+ hdr = emit_fdt_header_vers(&b, 0xffffffff, 0x10, 0xffffffff);
+ emit_align(&b, 8);
+
+ emit_rsvmap_empty(&b, hdr);
+
+ {
+ size_t ss = start_block(&b);
+
+ emit_begin_node(&b, "");
+ p_int = emit_prop_u64(&b, 0, 0x100000002);
+ emit_end_node(&b);
+ emit_fdt_end(&b);
+
+ finish_struct_block(&b, hdr, ss);
+ }
+
+ {
+ size_t strs = start_block(&b);
+ size_t s;
+
+ s = emit_string(&b, "prop-int");
+ fill_prop_name(&b, strs, p_int, s);
+
+ finish_strings_block(&b, hdr, strs);
+ }
+
+ finish_totalsize(&b, hdr);
+
+ return b;
+}
+
/* Tree table and main */
static struct {
@@ -884,6 +928,7 @@ static struct {
TREE(named_root),
TREE(unknown_tags_can_skip),
TREE(unknown_tags_no_skip),
+ TREE(last_comp_version_w_future),
};
int main(int argc, char *argv[])
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect
index 75883593..42167271 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.0.expect
@@ -1,6 +1,7 @@
/dts-v1/;
// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect
index b4d3ae29..6d750f88 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.1.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 18
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect
index a196bed3..83bbfd1f 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.2.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect
index 52faa1dd..77b00d1d 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.3.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect
index 1ddc694b..93c7b750 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.4.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect
index f955ac1c..7ee385aa 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.5.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect b/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect
index 59247478..777443f3 100644
--- a/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect
+++ b/tests/unknown_tags_can_skip.fdtput.test.dtb.6.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.0.expect b/tests/unknown_tags_can_skip.wip.test.dtb.0.expect
index 75883593..42167271 100644
--- a/tests/unknown_tags_can_skip.wip.test.dtb.0.expect
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.0.expect
@@ -1,6 +1,7 @@
/dts-v1/;
// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.1.expect b/tests/unknown_tags_can_skip.wip.test.dtb.1.expect
index 2a0dd4a0..afd8a4af 100644
--- a/tests/unknown_tags_can_skip.wip.test.dtb.1.expect
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.1.expect
@@ -1,6 +1,7 @@
/dts-v1/;
-// version: 17
+// version: 18
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.2.expect b/tests/unknown_tags_can_skip.wip.test.dtb.2.expect
index bc08885b..53403228 100644
--- a/tests/unknown_tags_can_skip.wip.test.dtb.2.expect
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.2.expect
@@ -1,6 +1,7 @@
/dts-v1/;
// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
diff --git a/tests/unknown_tags_can_skip.wip.test.dtb.3.expect b/tests/unknown_tags_can_skip.wip.test.dtb.3.expect
index aa6e9394..89fde625 100644
--- a/tests/unknown_tags_can_skip.wip.test.dtb.3.expect
+++ b/tests/unknown_tags_can_skip.wip.test.dtb.3.expect
@@ -1,6 +1,7 @@
/dts-v1/;
// version: 4294967295
// last_comp_version: 16
+// last_comp_version_w: 17
// Unknown tag ignored: 0xd0000000, data len 4 00000001
/ {
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread