From: Milan Broz <gmazyland@gmail.com>
To: Dave Reisner <dreisner@archlinux.org>
Cc: dm-crypt@saout.de
Subject: Re: [dm-crypt] [PATCH] libdevmapper: correctly compare major and minor versions
Date: Thu, 14 Nov 2013 08:38:16 +0100 [thread overview]
Message-ID: <52847DE8.70502@gmail.com> (raw)
In-Reply-To: <1384378037-13519-1-git-send-email-dreisner@archlinux.org>
On 11/13/2013 10:27 PM, Dave Reisner wrote:
> Previously, this code could incorrectly identify a version of crypt or
> dm due to the way it compared versions. For example, if a feature was
> gated on crypt version 1.5, it would disable the feature for crypt
> version 2.2.
Yes, intention was just simple version check. Anyway, in most cases
code tries use feature, and only if it fails, it reports error
about missing support (this should prevent issues on some systems
with backported patches without module version changes).
Anyway, patch applied, thanks!
Milan
prev parent reply other threads:[~2013-11-14 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 21:27 [dm-crypt] [PATCH] libdevmapper: correctly compare major and minor versions Dave Reisner
2013-11-14 7:38 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52847DE8.70502@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-crypt@saout.de \
--cc=dreisner@archlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox