DM-Crypt Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Jonas Meurer <jonas@freesources.org>, dm-crypt@saout.de
Subject: Re: [dm-crypt] nuke password to delete luks header
Date: Mon, 27 Jan 2014 21:30:08 +0100	[thread overview]
Message-ID: <52E6C1D0.1000508@gmail.com> (raw)
In-Reply-To: <62a688cb4fb5803b21139dcc03342e05@imap.steindlberger.de>

On 01/27/2014 10:04 AM, Jonas Meurer wrote:
>> For 2, (aka self destroy passphrase) - I tried to read the discussion 
>> again
>> and I am really not convinced yet we want it.
> 
> Do you intend to protect the erase feature by asking for a password? In 
> that
> case it will be hard to build a nuke wrapper around 'cryptsetup erase'.
> Especially if the nuke password should not reveal access to encrypted 
> data
> and merely allow to erase LUKS header.

No, only usual YES/no question should (will) be there
(which can be switched off with batch -q option as in other commands).

The luksKillSlot is doing exactly the same, just for one keyslot.

Actually, it is just simple code as
  for all active keyslots:
     crypt_destroy_slot()

>> BTW original patch is INCOMPLETE and DANGEROUS.
>>
>> (For example, did anyone think about cryptsetup-reencrypt? Guess what 
>> will
>> happen if user try to *reencrypt* device with this destroy passphrase?
>> Try it... or better not ;-) And there are more missing code which just
>> do not convince me that it was properly thought-out work.
> 
> Isn't that a good argument for implementing it properly upstream? ;)

I think this argument was mentioned by me :) But I think we have found better
way how to implement it without this feature.
Avoiding upstream to become bloatware is also important ;-)

...

> While I see your argument, reencryption takes a lot more time than using 
> a
> nuke feature. Both features serve completely different purposes.

Sure, it was just a complain about features importance...

(And btw there is in git already function to change only header (hash)
without reencrypting the whole device. This will be a workaround
to solve bad gcrypt whirlpool case. Once gcrypt 1.6.1 is out...)
...

> And if you merely want to destroy access to the data, overwriting it is 
> still
> better than reencrypting, isn't it?

Yes, and removing key with "erase" command should do the same quickly as well.

Milan

  parent reply	other threads:[~2014-01-27 20:30 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14  2:10 [dm-crypt] nuke password to delete luks header Jim O'Gorman
2014-01-14  2:41 ` .. ink ..
2014-01-14  2:52   ` Jim O'Gorman
2014-01-14  4:04     ` .. ink ..
2014-01-14  4:36       ` Arno Wagner
2014-01-14  5:00         ` .. ink ..
2014-01-14  7:11           ` Arno Wagner
2014-01-14 12:05             ` .. ink ..
2014-01-14 14:34               ` Arno Wagner
2014-01-14 19:22                 ` .. ink ..
2014-01-15 19:36                   ` Milan Broz
2014-01-16 11:50                     ` Arno Wagner
2014-01-14  4:30     ` Arno Wagner
2014-01-14  5:01       ` Jim O'Gorman
2014-01-14  7:39         ` [dm-crypt] Re2: " Arno Wagner
2014-01-14 22:42           ` Jonas Meurer
2014-01-15  6:01             ` Arno Wagner
2014-01-15 10:00               ` Jonas Meurer
2014-01-15 10:47                 ` Arno Wagner
2014-01-15 11:39                 ` Matthias Schniedermeyer
2014-01-15 12:40                   ` Arno Wagner
2014-01-15 12:59                     ` Matthias Schniedermeyer
2014-01-15 13:38                       ` .. ink ..
2014-01-15 20:27       ` [dm-crypt] " Milan Broz
2014-01-16  9:50         ` Ondrej Kozina
2014-01-16 10:30           ` Thomas Bastiani
2014-01-16 13:09             ` Florian Junghanns
2014-01-16 19:33             ` Milan Broz
2014-01-16 20:09               ` helices
2014-01-16 20:11               ` Iggy
2014-01-16 21:36                 ` Matthias Schniedermeyer
2014-01-16 21:55                   ` Arno Wagner
2014-01-16 22:49                     ` Claudio Moretti
2014-01-17  8:17                       ` Thomas Bastiani
2014-01-17 23:18                         ` Claudio Moretti
2014-01-18  8:43                           ` Arno Wagner
2014-01-18 12:42                             ` Claudio Moretti
2014-01-18 19:18                               ` Arno Wagner
2014-01-16 20:18               ` Matthias Schniedermeyer
2014-01-16 20:28                 ` .. ink ..
2014-01-16 21:02                   ` Brian
2014-01-16 21:24                   ` Arno Wagner
2014-01-16 20:59                 ` Milan Broz
2014-01-16 21:43                   ` Arno Wagner
2014-01-17 12:43                 ` Jonas Meurer
2014-01-17 13:12                   ` Arno Wagner
2014-01-17 14:27                     ` Jonas Meurer
2014-01-17 15:16                       ` Matthias Schniedermeyer
2014-01-17 14:32                     ` Rick Moritz
2014-01-17 14:32                     ` Jonas Meurer
2014-01-17 14:57                       ` Arno Wagner
2014-01-17 14:51                     ` Heiko Rosemann
2014-01-17 15:10                       ` Arno Wagner
2014-01-16 12:01           ` Arno Wagner
2014-01-16 11:59         ` Arno Wagner
2014-01-21 22:40         ` Jonas
2014-01-23 21:26           ` Milan Broz
2014-01-23 22:11             ` .. ink ..
2014-01-23 22:30               ` Milan Broz
2014-01-23 23:43             ` Arno Wagner
2014-01-27  9:04             ` Jonas Meurer
2014-01-27 12:44               ` Arno Wagner
2014-01-27 20:30               ` Milan Broz [this message]
2014-01-28 10:28                 ` Jonas Meurer
  -- strict thread matches above, loose matches on Subject: below --
2014-01-06 21:01 R3s1stanc3
2014-01-06 21:39 ` Heinz Diehl
2014-01-06 21:44   ` R3s1stanc3
2014-01-06 23:33     ` Claudio Moretti
2014-01-06 23:38       ` R3s1stanc3
2014-01-07  0:03     ` Arno Wagner
2014-01-07  0:01 ` Arno Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E6C1D0.1000508@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=dm-crypt@saout.de \
    --cc=jonas@freesources.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox