From: Milan Broz <gmazyland@gmail.com>
To: Lars Winterfeld <lars.winterfeld@tu-ilmenau.de>, dm-crypt@saout.de
Subject: Re: [dm-crypt] goto patch for cryptsetup?
Date: Fri, 07 Mar 2014 06:23:41 +0100 [thread overview]
Message-ID: <531957DD.7020401@gmail.com> (raw)
In-Reply-To: <5318DCEF.5020004@tu-ilmenau.de>
On 03/06/2014 09:39 PM, Lars Winterfeld wrote:
> Hi,
>
> in light of the latest "goto fail"s out there, would you reject a patch
> replacing all 328 gotos with their semantic equivalents from structured
> C programming?
cryptsetup code uss goto for only one purpose: to have only one exit
place from a function (with check for errors, release memory).
Replacing it with anything else means duplicating of lot of code.
Read e.g. kernel code, you will se the same patern on many places.
Milan
next prev parent reply other threads:[~2014-03-07 5:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 20:39 [dm-crypt] goto patch for cryptsetup? Lars Winterfeld
2014-03-06 23:27 ` Arno Wagner
2014-03-07 5:23 ` Milan Broz [this message]
2014-03-07 10:52 ` Lars Winterfeld
2014-03-07 12:11 ` Arno Wagner
2014-03-07 12:16 ` .. ink ..
2014-03-07 16:11 ` Milan Broz
2014-03-08 16:20 ` Arno Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531957DD.7020401@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-crypt@saout.de \
--cc=lars.winterfeld@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox